Skip to content

Migrate Spring Boot RabbitMQ smoke test to JUnit - #12128

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
bbujon/smoke-tests-spring-boot-rabbit
Aug 25, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
bbujon/smoke-tests-spring-boot-rabbit

Conversation

@PerfectSlayer

@PerfectSlayer PerfectSlayer commented Aug 3, 2026 •

Copy link
Copy Markdown
Collaborator

What Does This Do

This PR migrates the Spring Boot RabbitMQ smoke tests to the new JUnit smoke test framework.

Motivation

The new tests checks the whole trace structures and span values, in addition to trace payload validity and invariants.
It also check that three round-trips are present (no only one) and the trace is fully-connected.

Additional Notes

Contributor Checklist

Jira ticket: APMLP-1247

@PerfectSlayer PerfectSlayer added type: feature Enhancements and improvements tag: no release notes Changes to exclude from release notes labels Aug 3, 2026
@PerfectSlayer
PerfectSlayer requested a review from a team as a code owner August 3, 2026 13:52
@PerfectSlayer PerfectSlayer added the inst: rabbitmq RabbitMQ instrumentation label Aug 3, 2026
@PerfectSlayer
PerfectSlayer requested review from vandonr and removed request for a team August 3, 2026 13:52
@PerfectSlayer PerfectSlayer added the inst: spring Spring instrumentation label Aug 3, 2026

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: FAIL

The migrated test changes RabbitMQ's known teardown-error allowlist from the actual client text occured to occurred. When either app is stopped, that disconnect log is treated as an unexpected error and the smoke test fails in teardown; restore the original spelling.

Open Bits AI session

🤖 Datadog Autotest · Commit 1201890 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1201890609

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dd-octo-sts

dd-octo-sts Bot commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.81 s 14.69 s [+0.0%; +1.6%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.52 s 13.72 s [-2.3%; -0.6%] (maybe better)
startup:petclinic:appsec:Agent 17.53 s 17.39 s [-0.2%; +1.8%] (no difference)
startup:petclinic:iast:Agent 17.44 s 16.88 s [-1.1%; +7.7%] (no difference)
startup:petclinic:profiling:Agent 17.48 s 17.42 s [-0.9%; +1.6%] (no difference)
startup:petclinic:sca:Agent 17.48 s 17.37 s [-0.3%; +1.7%] (no difference)
startup:petclinic:tracing:Agent 16.66 s 16.51 s [+0.1%; +1.7%] (maybe worse)

Commit: 8f3685a7 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@PerfectSlayer
PerfectSlayer requested review from a team as code owners August 4, 2026 11:30
@PerfectSlayer
PerfectSlayer requested review from mcculls and removed request for a team August 4, 2026 11:30
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-spring-boot-rabbit branch from 1201890 to 979b3f4 Compare August 5, 2026 05:28
@datadog-datadog-us1-prod

This comment has been minimized.

@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-spring-boot-rabbit branch from 979b3f4 to 353ea51 Compare August 5, 2026 15:48
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-spring-boot-rabbit branch 2 times, most recently from 3b1d4ed to bb468da Compare August 6, 2026 11:47
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-spring-boot-rabbit branch from bb468da to 2cb3514 Compare August 7, 2026 08:13
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-spring-boot-rabbit branch from 2cb3514 to 3053afc Compare August 11, 2026 09:55
@PerfectSlayer PerfectSlayer removed the tag: no release notes Changes to exclude from release notes label Aug 12, 2026

@bric3 bric3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few tidbits though.

@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-spring-boot-rabbit branch from 4d018c9 to 2f155a2 Compare August 20, 2026 16:15
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-spring-boot-rabbit branch from 2f155a2 to 9344887 Compare August 21, 2026 06:24
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-spring-boot-rabbit branch 2 times, most recently from 702d051 to a872484 Compare August 21, 2026 08:48
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-spring-boot-rabbit branch 2 times, most recently from f8ee1ab to c717be8 Compare August 21, 2026 11:27
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-spring-boot-rabbit branch from c717be8 to 8f3685a Compare August 24, 2026 16:40
@PerfectSlayer
PerfectSlayer requested a review from a team as a code owner August 24, 2026 16:40
@PerfectSlayer
PerfectSlayer requested review from mhdatie and removed request for a team August 24, 2026 16:40

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: FAIL

The new 12-span matcher cannot match the three trace chunks that the two JVMs send for each round trip. The smoke test waits for 60 seconds and then fails.

Open Bits AI session

🤖 Datadog Autotest · Commit 8f3685a · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@mhdatie mhdatie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few remarks but straightforward otherwise 👍

Base automatically changed from bbujon/smoke-tests-opentelemetry to master August 25, 2026 08:19
@PerfectSlayer

Copy link
Copy Markdown
Collaborator Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 25, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-25 08:50:26 UTC ℹ️ Start processing command /merge


2026-08-25 08:50:31 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-08-25 09:39:51 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit cd6ceab into master Aug 25, 2026
596 of 601 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bbujon/smoke-tests-spring-boot-rabbit branch August 25, 2026 09:39
@github-actions github-actions Bot added this to the 1.66.0 milestone Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: rabbitmq RabbitMQ instrumentation inst: spring Spring instrumentation tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants