Repository navigation
Migrate Spring Boot RabbitMQ smoke test to JUnit - #12128
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
Conversation
There was a problem hiding this comment.
The migrated test changes RabbitMQ's known teardown-error allowlist from the actual client text occured to occurred. When either app is stopped, that disconnect log is treated as an unexpected error and the smoke test fails in teardown; restore the original spelling.
🤖 Datadog Autotest · Commit 1201890 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1201890609
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
1201890 to
979b3f4
Compare
This comment has been minimized.
This comment has been minimized.
979b3f4 to
353ea51
Compare
3b1d4ed to
bb468da
Compare
bb468da to
2cb3514
Compare
2cb3514 to
3053afc
Compare
bric3
left a comment
There was a problem hiding this comment.
LGTM, a few tidbits though.
4d018c9 to
2f155a2
Compare
2f155a2 to
9344887
Compare
702d051 to
a872484
Compare
f8ee1ab to
c717be8
Compare
c717be8 to
8f3685a
Compare
There was a problem hiding this comment.
The new 12-span matcher cannot match the three trace chunks that the two JVMs send for each round trip. The smoke test waits for 60 seconds and then fails.
🤖 Datadog Autotest · Commit 8f3685a · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
mhdatie
left a comment
There was a problem hiding this comment.
Few remarks but straightforward otherwise 👍
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
cd6ceab
into
master
What Does This Do
This PR migrates the Spring Boot RabbitMQ smoke tests to the new JUnit smoke test framework.
Motivation
The new tests checks the whole trace structures and span values, in addition to trace payload validity and invariants.
It also check that three round-trips are present (no only one) and the trace is fully-connected.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMLP-1247