Skip to content

Migrate dynamic config smoke tests to JUnit - #12148

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bbujon/smoke-tests-dynamic-config
Aug 25, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bbujon/smoke-tests-dynamic-config

Conversation

@PerfectSlayer

@PerfectSlayer PerfectSlayer commented Aug 5, 2026 •

Copy link
Copy Markdown
Collaborator

What Does This Do

This PR migrates the dynamic config smoke tests to the new JUnit smoke test framework.

Motivation

The new tests checks the RC messages (payload and behavior) against the CI test agent, and no longer our own implementation, to avoid validating our implementation by ourselves.

Additional Notes

The CI test agent runs as side car in CI. It will be run using testcontainers on local environment.

Contributor Checklist

Jira ticket: APMLP-1247

@PerfectSlayer
PerfectSlayer requested a review from a team as a code owner August 5, 2026 15:57
@PerfectSlayer
PerfectSlayer requested a review from ygree August 5, 2026 15:57
@PerfectSlayer PerfectSlayer added type: feature Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: remote config Configuration at Runtime labels Aug 5, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eaee938397

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@datadog-official

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.06 s 13.95 s [-0.1%; +1.7%] (no difference)
startup:insecure-bank:tracing:Agent 12.91 s 13.00 s [-1.4%; +0.0%] (no difference)
startup:petclinic:appsec:Agent 16.98 s 16.88 s [-0.5%; +1.6%] (no difference)
startup:petclinic:iast:Agent 16.97 s 17.08 s [-1.4%; +0.2%] (no difference)
startup:petclinic:profiling:Agent 16.88 s 16.97 s [-1.6%; +0.6%] (no difference)
startup:petclinic:sca:Agent 16.82 s 16.82 s [-1.0%; +0.9%] (no difference)
startup:petclinic:tracing:Agent 16.21 s 16.18 s [-0.8%; +1.2%] (no difference)

Commit: 186a713a · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The JUnit migration preserves the prior RC assertions and compiles cleanly; shared smoke/backend tests also pass. The two changed smoke tests could not execute their child JVMs here because Docker is unavailable for TestAgentBackend, so end-to-end app behavior remains to be confirmed in CI.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit eaee938 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-dynamic-config branch from eaee938 to b3e4942 Compare August 6, 2026 11:24
@datadog-official

datadog-official Bot commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

View session in Datadog

Bits Code status: ✅ Done

Comment @DataDog to request changes

@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-dynamic-config branch from b3e4942 to 76437d7 Compare August 6, 2026 11:47
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-dynamic-config branch from 76437d7 to f71af08 Compare August 6, 2026 12:36
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-dynamic-config branch 2 times, most recently from 0779dd0 to bd8d890 Compare August 11, 2026 09:55
@PerfectSlayer PerfectSlayer added tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Aug 12, 2026
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-dynamic-config branch from bd8d890 to 5f71a88 Compare August 13, 2026 12:33

@sarahchen6 sarahchen6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the PR description needs an update, but otherwise LGTM!

Comment thread dd-smoke-tests/dynamic-config/build.gradle Outdated
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-dynamic-config branch from 5f71a88 to 5381d30 Compare August 20, 2026 16:15
@PerfectSlayer
PerfectSlayer requested a review from a team as a code owner August 20, 2026 16:15
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-dynamic-config branch from f551730 to 874a3c9 Compare August 21, 2026 08:10
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-dynamic-config branch from 874a3c9 to 2bd2176 Compare August 21, 2026 08:48
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-dynamic-config branch from 2bd2176 to 2bb986b Compare August 21, 2026 09:15
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-dynamic-config branch from 2bb986b to c3f4eae Compare August 21, 2026 11:27
@PerfectSlayer
PerfectSlayer requested review from a team as code owners August 24, 2026 16:40
@PerfectSlayer
PerfectSlayer requested review from bric3, dromanol, jandro996 and mcculls and removed request for a team August 24, 2026 16:40
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-dynamic-config branch from c3f4eae to 4ce14fb Compare August 24, 2026 16:40

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The JUnit migrations preserve the prior Remote Config behavior. The new tests also use the smoke-test backend lifecycle correctly.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 4ce14fb · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

Base automatically changed from bbujon/smoke-tests-spring-boot-rabbit to master August 25, 2026 09:39
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot requested a review from a team as a code owner August 25, 2026 09:39
Comment thread dd-smoke-tests/dynamic-config/build.gradle Outdated
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-dynamic-config branch from 4ce14fb to 186a713 Compare August 25, 2026 11:44
@PerfectSlayer

Copy link
Copy Markdown
Collaborator Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 25, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-25 12:29:00 UTC ℹ️ Start processing command /merge


2026-08-25 12:29:10 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-08-25 13:16:35 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 2f50f73 into master Aug 25, 2026
600 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bbujon/smoke-tests-dynamic-config branch August 25, 2026 13:16
@github-actions github-actions Bot added this to the 1.66.0 milestone Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: remote config Configuration at Runtime tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants