Repository navigation
Migrate dynamic config smoke tests to JUnit - #12148
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eaee938397
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
More details
The JUnit migration preserves the prior RC assertions and compiles cleanly; shared smoke/backend tests also pass. The two changed smoke tests could not execute their child JVMs here because Docker is unavailable for TestAgentBackend, so end-to-end app behavior remains to be confirmed in CI.
🤖 Datadog Autotest · Commit eaee938 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
eaee938 to
b3e4942
Compare
|
Bits Code status: ✅ Done Comment @DataDog to request changes |
b3e4942 to
76437d7
Compare
76437d7 to
f71af08
Compare
0779dd0 to
bd8d890
Compare
bd8d890 to
5f71a88
Compare
sarahchen6
left a comment
There was a problem hiding this comment.
Looks like the PR description needs an update, but otherwise LGTM!
5f71a88 to
5381d30
Compare
f551730 to
874a3c9
Compare
874a3c9 to
2bd2176
Compare
2bd2176 to
2bb986b
Compare
2bb986b to
c3f4eae
Compare
c3f4eae to
4ce14fb
Compare
There was a problem hiding this comment.
More details
The JUnit migrations preserve the prior Remote Config behavior. The new tests also use the smoke-test backend lifecycle correctly.
🤖 Datadog Autotest · Commit 4ce14fb · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
4ce14fb to
186a713
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
This PR migrates the dynamic config smoke tests to the new JUnit smoke test framework.
Motivation
The new tests checks the RC messages (payload and behavior) against the CI test agent, and no longer our own implementation, to avoid validating our implementation by ourselves.
Additional Notes
The CI test agent runs as side car in CI. It will be run using testcontainers on local environment.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMLP-1247