Repository navigation
Support OpenTelemetry deployment environment names - #12324
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
There was a problem hiding this comment.
More details
The change maps deployment.environment.name to the Datadog environment. It keeps deployment.environment as a fallback and removes both keys from generic tags.
🤖 Datadog Autotest · Commit 65b75ba · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
🎯 Code Coverage (details) 🔗 Commit SHA: 7c2b26c | Docs | View more details | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
zacharycmontoya
left a comment
There was a problem hiding this comment.
Functionally, LGTM so we can understand either OTel convention for specifying the application environment. I'd love to get a Java reviewer to confirm the testing strategy
mhlidd
left a comment
There was a problem hiding this comment.
LGTM following an additional test case.
65b75ba to
7c2b26c
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
…me, it's a workaround for
## Summary of changes Map `deployment.environment.name` to the Datadog environment. Keep `deployment.environment` as a fallback, and keep `DD_ENV` as the highest-precedence source. ## Reason for change OpenTelemetry stabilized the deployment environment semantic convention under `deployment.environment.name`. Related PRs: - DataDog/system-tests#7613 - DataDog/dd-trace-go#5285 - #9150 - DataDog/dd-trace-rb#6261 - DataDog/dd-trace-php#4148 - DataDog/dd-trace-js#10050 - DataDog/dd-trace-rs#300 - DataDog/dd-trace-java#12324 - DataDog/dd-trace-py#19901 ## Implementation details The resource attribute mapper tracks the stable and legacy values separately, then chooses the stable value regardless of input order. It removes both source aliases after promotion and leaves unrelated attributes alone. ## Test coverage Five focused mapping cases and 182 adjacent configuration tests passed locally. Formatting checks also passed. ## Other details None. --------- Co-authored-by: Zach Montoya <zach.montoya@datadoghq.com>
What Does This Do
Maps the stable OpenTelemetry
deployment.environment.nameresource attribute to the Datadog environment while retainingdeployment.environmentas a legacy fallback. When both attributes are present, the stable name takes precedence.Motivation
OpenTelemetry deprecated
deployment.environmentin favor ofdeployment.environment.name. Applications using the current semantic convention were not assigned the expected Datadog environment.Additional Notes
Validated with focused configuration tests and Spotless checks.
Contributor Checklist