Create profiler snapshot and JFR CLI temp files under configured tempdir by anandreshmi46 · Pull Request #12484 · DataDog/dd-trace-java

anandreshmi46 · 2026-09-14T12:27:23Z

What Does This Do

Routes profiler snapshot files and the jfr-cli helper's scratch file through TempLocationManager-backed locations instead of the JVM default temp directory:

DatadogProfilerRecording.snapshot() now creates its file via DatadogProfiler.newSnapshotFile(), which reuses the profiler's existing recordingsPath (the same directory already used for regular recordings).
JfrCliHelper.invokeOn() now creates its scratch recording file under a jfr-cli subdirectory obtained from TempLocationManager.getInstance().getTempDir(...), instead of File.createTempFile(...)

Motivation

Snapshot files and the jfr-cli helper's scratch file were created via Files.createTempFile()/File.createTempFile() with no directory argument, which falls back to the JVM default java.io.tmpdir (/tmp). On hardened K8s pods with a read-only root filesystem and only a custom tempdir mounted (dd.profiling.tempdir / FlightRecorderOptions repository), this throws:

FileSystemException: Read-only file system

Both now go through TempLocationManager-backed locations: snapshots reuse DatadogProfiler's recordingsPath (same dir as regular recordings), and the jfr-cli helper gets its own subdirectory under the managed temp dir.

Fixes SCP-1361

Additional Notes

Added a regression assertion in DatadogProfilerRecordingTest#testSnapshot verifying the snapshot file's parent directory matches the main recording file's parent (i.e. it no longer lands in the JVM default temp dir).
./gradlew :dd-java-agent:agent-profiling:profiling-ddprof:test :dd-java-agent:agent-profiling:profiling-uploader:test passes.
spotlessApply, /techdebt, and /perf-review all came back clean — no further changes needed.

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any other useful labels
Avoid using close, fix, or any linking keywords when referencing an issue
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, migration, or deletion
Update public documentation with any new configuration flags or behaviors
Once approved, use merge queue to merge the PR

Jira ticket: SCP-1361

Snapshot files and the jfr-cli helper's scratch file were created via Files.createTempFile()/File.createTempFile() with no directory argument, which falls back to the JVM default java.io.tmpdir (/tmp). On hardened K8s pods with a read-only root filesystem and only a custom tempdir mounted (dd.profiling.tempdir / FlightRecorderOptions repository), this throws FileSystemException: Read-only file system. Both now go through TempLocationManager-backed locations: snapshots reuse DatadogProfiler's recordingsPath (same dir as regular recordings), and the jfr-cli helper gets its own subdirectory under the managed temp dir. Fixes SCP-1361. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

chatgpt-codex-connector · 2026-09-14T12:27:35Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-14T12:30:26.567117Z	`74a8927`	PR opened
🔒 Security Review	✅ Completed 2026-09-14T12:31:15.816559Z	`74a8927`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

dd-octo-sts · 2026-09-14T12:27:38Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

datadog-prod-us1-5

More details

Both temporary-file paths now use managed profiling directories. Cleanup still removes the JFR CLI scratch file, and the static review found no concrete failure.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Datadog Autotest · Commit 74a8927 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest}

dd-octo-sts · 2026-09-14T12:48:15Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	14.86 s	14.71 s	[+0.1%; +1.9%] (maybe worse)
startup:insecure-bank:tracing:Agent	13.70 s	13.60 s	[-0.2%; +1.7%] (no difference)
startup:petclinic:appsec:Agent	17.02 s	16.58 s	[-1.8%; +7.1%] (no difference)
startup:petclinic:iast:Agent	16.99 s	17.04 s	[-1.2%; +0.6%] (no difference)
startup:petclinic:profiling:Agent	16.70 s	16.91 s	[-2.2%; -0.3%] (maybe better)
startup:petclinic:sca:Agent	16.89 s	16.75 s	[-0.2%; +1.8%] (no difference)
startup:petclinic:tracing:Agent	16.17 s	16.04 s	[-0.0%; +1.6%] (no difference)

Commit: 7b2587f3 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

jbachorik

LGTM! Thanks for fixing this!

dd-octo-sts · 2026-09-14T16:00:55Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-09-14T16:00:58Z

View all feedbacks in Devflow UI.

2026-09-14 16:00:58 UTC ℹ️ Start processing command /merge

2026-09-14 16:01:03 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-09-14 16:58:17 UTC ℹ️ MergeQueue: This merge request was merged

anandreshmi46 requested a review from a team as a code owner September 14, 2026 12:27

dd-octo-sts Bot added the tag: ai generated Largely based on code generated by an AI or LLM label Sep 14, 2026

datadog-prod-us1-5 Bot reviewed Sep 14, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

anandreshmi46 added type: bug fix Bug fix comp: profiling Profiling labels Sep 14, 2026

anandreshmi46 requested review from jard-io and jbachorik and removed request for jard-io September 14, 2026 12:34

Merge branch 'master' into reshmi/scp-1361-snapshot-tempdir

7b2587f

jbachorik approved these changes Sep 14, 2026

View reviewed changes

anandreshmi46 added this pull request to the merge queue Sep 14, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 14, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit bd66fb5 into master Sep 14, 2026
603 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the reshmi/scp-1361-snapshot-tempdir branch September 14, 2026 16:58

github-actions Bot added this to the 1.67.0 milestone Sep 14, 2026

Navigation Menu

Repository navigation

Create profiler snapshot and JFR CLI temp files under configured tempdir - #12484

Create profiler snapshot and JFR CLI temp files under configured tempdir#12484
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
reshmi/scp-1361-snapshot-tempdir

anandreshmi46 commented Sep 14, 2026 •

edited by atlassian Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented Sep 14, 2026 •

edited

Loading

Uh oh!

dd-octo-sts Bot commented Sep 14, 2026

Uh oh!

datadog-prod-us1-5 Bot left a comment

Uh oh!

This comment has been minimized.

dd-octo-sts Bot commented Sep 14, 2026 •

edited

Loading

Uh oh!

jbachorik left a comment

Uh oh!

dd-octo-sts Bot commented Sep 14, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

anandreshmi46 commented Sep 14, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

chatgpt-codex-connector Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

dd-octo-sts Bot commented Sep 14, 2026

Uh oh!

datadog-prod-us1-5 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

dd-octo-sts Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

jbachorik left a comment

Choose a reason for hiding this comment

Uh oh!

dd-octo-sts Bot commented Sep 14, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

anandreshmi46 commented Sep 14, 2026 •

edited by atlassian Bot

Loading

chatgpt-codex-connector Bot commented Sep 14, 2026 •

edited

Loading

dd-octo-sts Bot commented Sep 14, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Sep 14, 2026 •

edited

Loading