Skip to content

Carry the agent manifest inside metadata so it reaches the backend - #12512

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits into
masterfrom
nicole.cybul/fix-java-agent-manifest-field
Sep 18, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits into
masterfrom
nicole.cybul/fix-java-agent-manifest-field

Conversation

@ncybul

@ncybul ncybul commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

annotateAgentManifest() (shipped in v1.66.0) wrote the manifest to meta.agent_manifest, but the backend reads it from meta.metadata._dd.agent_manifest, so Java manifests never showed up in agent tracking.

The manifest now goes into the existing metadata span tag under the reserved _dd namespace, so it serializes to the right place. Since it is no longer a span tag of its own, LLMObsSpanMapper loses its dedicated branch and wire key.

The public API is unchanged — no caller changes needed.

Manual Testing

Verified that agent manifest annotation gets stored on the span correctly (trace)
Screenshot 2026-09-16 at 12 42 44 PM

Contributor Checklist

  • Format code with ./gradlew spotlessApply
  • :dd-trace-core:test and :dd-java-agent:agent-llmobs:test pass locally
  • Existing manifest tests updated to the new location

Claude session: 1d00ff6a-4bf0-49b6-94c5-3464fb28b08f
Resume: claude --resume 1d00ff6a-4bf0-49b6-94c5-3464fb28b08f

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@ncybul ncybul added type: bug fix Bug fix comp: mlobs ML Observability (LLMObs) tag: ai generated Largely based on code generated by an AI or LLM labels Sep 15, 2026
@datadog-prod-us1-6

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.07 s 14.01 s [-0.4%; +1.3%] (no difference)
startup:insecure-bank:tracing:Agent 12.97 s 13.09 s [-1.7%; -0.2%] (maybe better)
startup:petclinic:appsec:Agent 17.01 s 16.85 s [+0.1%; +1.8%] (maybe worse)
startup:petclinic:iast:Agent 16.90 s 17.00 s [-1.5%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 16.62 s 16.94 s [-3.1%; -0.7%] (maybe better)
startup:petclinic:sca:Agent 16.86 s 16.24 s [-0.5%; +8.1%] (no difference)
startup:petclinic:tracing:Agent 16.01 s 16.06 s [-1.4%; +0.8%] (no difference)

Commit: a0f917b0 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@ncybul ncybul changed the title Serialize the agent manifest to meta.metadata._dd.agent_manifest Carry the agent manifest inside metadata so it reaches the backend Sep 16, 2026
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@ncybul
ncybul marked this pull request as ready for review September 16, 2026 16:43
@ncybul
ncybul requested a review from a team as a code owner September 16, 2026 16:43

@datadog-prod-us1-6 datadog-prod-us1-6 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The mapper keeps the agent manifest at meta.metadata._dd.agent_manifest. The updated tests cover storage and serialization at this path.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit ac4e69a · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac4e69a175

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@yahya-mouman

Copy link
Copy Markdown
Contributor

Is it possible to read it from both spots in the backend to not lose on data coming from this update ?

@ncybul

ncybul commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

Is it possible to read it from both spots in the backend to not lose on data coming from this update ?

@yahya-mouman I would probably suggest against that just because we don't want to add more tech debt to our backend for an update that we have yet to document. It's probably better to patch 1.66 release line instead.

@ncybul

ncybul commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-18 13:38:10 UTC ℹ️ Start processing command /merge


2026-09-18 13:38:21 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-09-18 14:57:23 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-18 16:02:07 UTC ℹ️ MergeQueue: This merge request was merged

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@ncybul

ncybul commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-18 14:10:29 UTC ℹ️ Start processing command /merge


2026-09-18 14:10:32 UTC ❌ MergeQueue

PR already in the queue with status waiting

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 1b33258 into master Sep 18, 2026
604 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the nicole.cybul/fix-java-agent-manifest-field branch September 18, 2026 16:02
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: mlobs ML Observability (LLMObs) tag: ai generated Largely based on code generated by an AI or LLM type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants