Repository navigation
Avoid duplicate context capture in OpenSearch executors - #12521
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The matcher exclusion keeps context capture in the delegated ThreadPoolExecutor call. It removes only the unused capture from the OpenSearch wrapper.
🤖 Datadog Autotest · Commit 2897ae2 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
🎯 Code Coverage (details) 🔗 Commit SHA: 2897ae2 | Docs | View more details | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
dougqh
left a comment
There was a problem hiding this comment.
Looks good to me
I think it would be good to fill in the Motivation section of the PR template
|
/merge |
|
View all feedbacks in Devflow UI.
It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.
The expected merge time in
|
f33b263
into
master
What Does This Do
Avoids capturing context twice when
OpenSearchThreadPoolExecutor.execute()wraps a runnable before delegating toThreadPoolExecutor.execute().The first capture belongs to the original runnable. OpenSearch then replaces that runnable with its own wrapper, so the first continuation can never run or be cancelled. The delegated superclass call performs the
context capture that belongs to the runnable actually submitted to the executor.
flowchart LR A[Original task] --> B[OpenSearch execute] B -. removed capture .-> C[Abandoned continuation] B --> D[OpenSearch wraps task] D --> E[ThreadPoolExecutor execute] E --> F[Capture context] F --> G[Run wrapped task] G --> H[Release continuation]Motivation
Elasticsearch already has the same matcher exception for its equivalent executor. This change extends it to OpenSearch and removes the test's
useStrictTraceWrites()override.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]