Fix LinkageError for CodeOrigin by jpbempel · Pull Request #12545 · DataDog/dd-trace-java

jpbempel · 2026-09-17T12:26:16Z

What Does This Do

Avoid trying to transform classes already loading. SymDB transformer and DebuggerTransformer should skip packages from the debugger itself Prevent duplicated class definiton

Motivation

Additional Notes

relates to #10803

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any other useful labels
Avoid using close, fix, or any linking keywords when referencing an issue
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, migration, or deletion
Update public documentation with any new configuration flags or behaviors
Once approved, use merge queue to merge the PR

Jira ticket: DEBUG-6214

dd-octo-sts · 2026-09-17T12:26:28Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

datadog-datadog-us1-prod

More details

The shared package filter blocks debugger classes in both transformers. The unused imports are a format issue, not a run-time defect.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Datadog Autotest · Commit fa41c42 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest}

pr-commenter · 2026-09-17T12:45:06Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1790184730	1790185046
end_time	2026-09-23T17:33:37	2026-09-23T17:38:52
git_branch	master	jpbempel/fix-code-origin-linkageError
git_commit_sha	`afd9b0c`	`400c5a2`
start_time	2026-09-23T17:32:11	2026-09-23T17:37:27

See matching parameters

	Baseline	Candidate
ci_job_id	2073308882	2073308882
ci_pipeline_id	139572336	139572336
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1790183946	1790183946

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics.

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-27.303µs; +11.546µs] or [-8.682%; +3.672%]	unstable [-41.219µs; +22.495µs] or [-11.906%; +6.498%]	unstable [-51.955µs; +30.783µs] or [-14.422%; +8.545%]	unstable [+37.909µs; +259.989µs] or [+3.552%; +24.361%]	same
scenario:basic	same	same	same	unstable [+27.462µs; +309.479µs] or [+2.577%; +29.041%]	same
scenario:loop	unsure [-12.174µs; -2.338µs] or [-0.162%; -0.031%]	same	same	same	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (346.191 µs) : 312, 381
.   : milestone, 346,
basic (315.171 µs) : 308, 322
.   : milestone, 315,
loop (7.562 ms) : 7557, 7568
.   : milestone, 7562,
section candidate
noprobe (336.829 µs) : 311, 362
.   : milestone, 337,
basic (313.855 µs) : 308, 320
.   : milestone, 314,
loop (7.561 ms) : 7548, 7575
.   : milestone, 7561,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	346.191 µs [311.698 µs, 380.685 µs]
basic	315.171 µs [307.971 µs, 322.371 µs]
loop	7.562 ms [7.557 ms, 7.568 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	336.829 µs [311.456 µs, 362.203 µs]
basic	313.855 µs [308.1 µs, 319.611 µs]
loop	7.561 ms [7.548 ms, 7.575 ms]

dd-octo-sts · 2026-09-17T12:49:43Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	14.82 s	14.67 s	[+0.3%; +1.9%] (maybe worse)
startup:insecure-bank:tracing:Agent	13.59 s	13.77 s	[-2.3%; -0.4%] (maybe better)
startup:petclinic:appsec:Agent	17.07 s	16.90 s	[+0.1%; +1.9%] (maybe worse)
startup:petclinic:iast:Agent	16.93 s	17.05 s	[-1.5%; +0.0%] (no difference)
startup:petclinic:profiling:Agent	16.86 s	16.29 s	[-1.1%; +8.1%] (no difference)
startup:petclinic:sca:Agent	16.98 s	16.81 s	[-0.1%; +2.1%] (no difference)
startup:petclinic:tracing:Agent	15.97 s	16.17 s	[-2.2%; -0.3%] (maybe better)

Commit: 400c5a2c · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

dd-octo-sts · 2026-09-18T14:41:57Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-09-18T14:42:00Z

View all feedbacks in Devflow UI.

2026-09-18 14:42:00 UTC ℹ️ Start processing command /merge

2026-09-18 14:42:05 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-09-18 15:03:09 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for b56bd05:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

jpbempel · 2026-09-21T07:23:26Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-09-21T07:23:30Z

View all feedbacks in Devflow UI.

2026-09-21 07:23:30 UTC ℹ️ Start processing command /merge

2026-09-21 07:23:35 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-09-21 07:40:21 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 09c024b:

debugger-benchmarks

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

jpbempel · 2026-09-21T08:48:52Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-09-21T08:48:56Z

View all feedbacks in Devflow UI.

2026-09-21 08:48:56 UTC ℹ️ Start processing command /merge

2026-09-21 08:49:02 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-09-21 09:04:10 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 07ed514:

exploration-tests-line-jackson-databind

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

Avoid trying to transform classes already loading. SymDB transformer and DebuggerTransformer should skip packages from the debugger itself Prevent duplicated class definiton

jpbempel · 2026-09-23T07:48:40Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-09-23T07:48:45Z

View all feedbacks in Devflow UI.

2026-09-23 07:48:45 UTC ℹ️ Start processing command /merge

2026-09-23 07:48:50 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-09-23 08:01:38 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for b66558e:

exploration-tests-method-jackson-databind

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

jpbempel · 2026-09-23T08:12:57Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-09-23T08:13:02Z

View all feedbacks in Devflow UI.

2026-09-23 08:13:02 UTC ℹ️ Start processing command /merge

2026-09-23 08:13:06 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-09-23 08:27:00 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 8bc28aa:

exploration-tests-method-jackson-databind

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

use mvn command instead of maven wrapper

datadog-datadog-us1-prod

The new shared filter loads after transformer registration. This load can re-enter the symbol transformer and reproduce the duplicate-definition LinkageError during normal SymDB startup.

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 636c206 · @DataDog review to ask questions}

make sure DebuggerInternalClass is loaded before executing into a Transformer

jpbempel requested a review from a team as a code owner September 17, 2026 12:26

jpbempel requested review from evanchooly and removed request for a team September 17, 2026 12:26

jpbempel added comp: debugger Dynamic Instrumentation type: bug fix Bug fix labels Sep 17, 2026

datadog-datadog-us1-prod Bot reviewed Sep 17, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

evanchooly approved these changes Sep 18, 2026

View reviewed changes

jpbempel added this pull request to the merge queue Sep 18, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 18, 2026

jpbempel added 2 commits September 23, 2026 08:56

Fix LinkageError for CodeOrigin

1e3a9fb

Avoid trying to transform classes already loading. SymDB transformer and DebuggerTransformer should skip packages from the debugger itself Prevent duplicated class definiton

spotless

6b20e4e

jpbempel force-pushed the jpbempel/fix-code-origin-linkageError branch from d3aa838 to 6b20e4e Compare September 23, 2026 06:56

fix jackson databind exploration test

636c206

use mvn command instead of maven wrapper

jpbempel requested review from a team as code owners September 23, 2026 12:02

jpbempel removed the request for review from a team September 23, 2026 12:02

jpbempel requested review from erikayasuda and sarahchen6 and removed request for a team September 23, 2026 12:02

datadog-datadog-us1-prod Bot reviewed Sep 23, 2026

View reviewed changes

Comment thread ...nt/agent-debugger/src/main/java/com/datadog/debugger/symbol/SymbolExtractionTransformer.java

sarahchen6 approved these changes Sep 23, 2026

View reviewed changes

jpbempel added 2 commits September 23, 2026 17:18

fix DebuggerInternalClass loading

9ef9451

make sure DebuggerInternalClass is loaded before executing into a Transformer

fix mvn

400c5a2

gh-worker-dd-mergequeue-cf854d Bot merged commit 19d19cf into master Sep 23, 2026
613 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the jpbempel/fix-code-origin-linkageError branch September 23, 2026 20:54

github-actions Bot added this to the 1.67.0 milestone Sep 23, 2026

Conversation

jpbempel commented Sep 17, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

dd-octo-sts Bot commented Sep 17, 2026

Uh oh!

datadog-datadog-us1-prod Bot left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

pr-commenter Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Debugger benchmarks

Parameters

Summary

Uh oh!

dd-octo-sts Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

dd-octo-sts Bot commented Sep 18, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

Uh oh!

jpbempel commented Sep 21, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

jpbempel commented Sep 21, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

jpbempel commented Sep 23, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

jpbempel commented Sep 23, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

datadog-datadog-us1-prod Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jpbempel commented Sep 17, 2026 •

edited by atlassian Bot

Loading

pr-commenter Bot commented Sep 17, 2026 •

edited

Loading

dd-octo-sts Bot commented Sep 17, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Sep 18, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Sep 21, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Sep 21, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Sep 23, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Sep 23, 2026 •

edited

Loading