Repository navigation
Fix application service names beneath inferred proxy spans - #12553
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c93f17f93e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
More details
The inferred-proxy check keeps the application service name on child spans. The standard root-span behavior stays unchanged.
🤖 Datadog Autotest · Commit c93f17f · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Fix application descendant spans incorrectly using the gateway service name when both
DD_TRACE_INFERRED_PROXY_SERVICES_ENABLEDandDD_TRACE_REMOVE_INTEGRATION_SERVICE_NAMES_ENABLEDareenabled.
For example, with application service
checkoutand inferred gateway servicegateway.example.com:gateway.example.com.checkout.gateway.example.com.checkout, including its service-name source.When the local root is an inferred proxy, skip the root-service override and preserve the service name
and source already resolved for the child span.
Motivation
An inferred proxy identifies an upstream gateway. Its service name should not replace the application
service on downstream application spans when integration service names are removed.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]