Repository navigation
Reduce SQS propagation attribute formatting overhead - #12562
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
Direct string construction keeps the prior serialized attribute text in both SQS injectors. The specialist reports no actionable regression.
🤖 Datadog Autotest · Commit e5dfa13 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for 3b9cb08: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Replace
String.format()in both AWS SDK v1 and v2 SQS message-attribute injectors with direct string construction. When appending headers, useStringBuilder.append(existing, start, end)to avoid the intermediate substring. Output remains unchanged.Standalone JMH results:
Benchmark: JMH 1.37, Temurin 17.0.18, Apple M4 Max, Java 8-compatible bytecode, one thread, three forks, three 1-second warmups and five 1-second measurements per fork,
-prof gc, 512 MiB heap. Errors are 99.9% confidence half-widths.The benchmark compared the exact before/after string-building expressions using 256 varying propagation values. The append case started with two existing headers. Results were returned to JMH, and output equivalence was checked before measurement. Benchmark sources are not included in this PR.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]