Skip to content

Add Spark physical plan only to completed spans - #12645

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
adrien.boitreaud/spark-heartbeat-tag-denylist
Sep 29, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
adrien.boitreaud/spark-heartbeat-tag-denylist

Conversation

@aboitreaud

Copy link
Copy Markdown
Contributor

What Does This Do

We send heartbeat spans every 2mins for accurate step and duration tracking. Physical plan is the largest span attr by far. We don't need to send it on running spans.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@aboitreaud
aboitreaud requested review from a team as code owners September 25, 2026 14:53
@aboitreaud
aboitreaud requested review from vandonr and removed request for a team September 25, 2026 14:53
@dd-octo-sts

dd-octo-sts Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@aboitreaud aboitreaud added inst: apache spark Apache Spark instrumentation type: feature Enhancements and improvements labels Sep 25, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f778ae462c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@datadog-prod-us1-3 datadog-prod-us1-3 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The retained SQL start event supplies the physical plan immediately before span completion, keeping it off running-span heartbeats without losing it from completed spans.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit f778ae4 · @DataDog review to ask questions

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 68.82% (+9.73%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6c12269 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.98 s 14.04 s [-1.2%; +0.4%] (no difference)
startup:insecure-bank:tracing:Agent 13.01 s 13.03 s [-0.9%; +0.6%] (no difference)
startup:petclinic:appsec:Agent 17.01 s 16.82 s [+0.2%; +2.1%] (maybe worse)
startup:petclinic:iast:Agent 16.97 s 17.07 s [-1.5%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 16.56 s 16.80 s [-2.3%; -0.5%] (maybe better)
startup:petclinic:sca:Agent 16.97 s 16.98 s [-1.1%; +0.9%] (no difference)
startup:petclinic:tracing:Agent 16.25 s 16.21 s [-0.8%; +1.3%] (no difference)

Commit: 6c12269a · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@aboitreaud
aboitreaud added this pull request to the merge queue Sep 28, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-28 17:19:39 UTC ℹ️ Start processing command /merge


2026-09-28 17:19:43 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-28 17:59:31 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 1bdb7e5:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 28, 2026
@aboitreaud
aboitreaud added this pull request to the merge queue Sep 29, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-29 02:37:38 UTC ℹ️ Start processing command /merge


2026-09-29 02:37:43 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-29 03:46:39 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 29, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 01aada5 into master Sep 29, 2026
606 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the adrien.boitreaud/spark-heartbeat-tag-denylist branch September 29, 2026 03:46
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 29, 2026
@ValentinZakharov ValentinZakharov changed the title Only add Spark physical plan to completed spans Add Spark physical plan only to completed spans Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: apache spark Apache Spark instrumentation type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants