Skip to content

Prevent Vert.x 4 session reaper from retaining request contexts - #12667

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits into
masterfrom
fix/vertx4-session-reaper-context
Sep 28, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits into
masterfrom
fix/vertx4-session-reaper-context

Conversation

@bric3

@bric3 bric3 commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Stops Vert.x 4's local session store from capturing a request context when it initializes or rearms maintenance timers. Shares the guard with Vert.x 5, removing its duplicate instrumentation. Adds latest-dependency regression tests for both timer paths.

Motivation

The latest-dependency Vert.x 4 worker tests timed out waiting for traces. The continuation timeline shows the session reaper rearming a Netty timer every second under the request context.

Additional Notes

The rearm regression test failed on master and passed with this change. The guard matches Vert.x 4 and 5. Vert.x 3 has the same session-store class and timer methods, so the existing Vert.x 4 Muzzle reference excludes it. The agent JAR size budget is unchanged.

Contributor Checklist

@bric3 bric3 added tag: ai generated Largely based on code generated by an AI or LLM inst: vertx Eclipse Vert.x instrumentation type: bug labels Sep 28, 2026 — with ChatGPT Codex Connector
@bric3

bric3 commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T15:16:03.757373Z 0d90db2 Draft marked ready
🔒 Security Review ✅ Completed 2026-09-28T15:15:38.590003Z 0d90db2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 68.82% (+9.73%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: cc4edf2 | Docs | Give us feedback!

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: a1a51aa70e

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: a1a51aa70e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dd-octo-sts

dd-octo-sts Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.02 s 14.03 s [-1.0%; +0.9%] (no difference)
startup:insecure-bank:tracing:Agent 12.97 s 13.01 s [-1.1%; +0.4%] (no difference)
startup:petclinic:appsec:Agent 17.01 s 16.92 s [-0.2%; +1.3%] (no difference)
startup:petclinic:iast:Agent 16.45 s 17.00 s [-7.4%; +1.0%] (no difference)
startup:petclinic:profiling:Agent 16.83 s 16.91 s [-2.0%; +0.9%] (no difference)
startup:petclinic:sca:Agent 16.97 s 16.17 s [+0.7%; +9.2%] (maybe worse)
startup:petclinic:tracing:Agent 16.11 s 16.17 s [-1.4%; +0.7%] (no difference)

Commit: cc4edf2c · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3
bric3 requested a review from amarziali September 28, 2026 15:12
@bric3
bric3 marked this pull request as ready for review September 28, 2026 15:12
@bric3
bric3 requested review from a team as code owners September 28, 2026 15:12
@bric3
bric3 requested review from vandonr and removed request for a team September 28, 2026 15:12

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The Vert.x 4 advice suppresses propagation around both session-maintenance timer paths, restores the prior state afterward, and its Muzzle guard excludes Vert.x 5.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 0d90db2 · @DataDog review to ask questions

@bric3

bric3 commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-28 16:06:32 UTC ℹ️ Start processing command /merge


2026-09-28 16:06:39 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-09-28 16:33:12 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-28 17:46:29 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit b20c1e3 into master Sep 28, 2026
608 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the fix/vertx4-session-reaper-context branch September 28, 2026 17:46
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: vertx Eclipse Vert.x instrumentation tag: ai generated Largely based on code generated by an AI or LLM type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants