Repository navigation
Prevent Vert.x 4 session reaper from retaining request contexts - #12667
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits into
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
|
/merge |
|
View all feedbacks in Devflow UI.
It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.
The expected merge time in
|
What Does This Do
Stops Vert.x 4's local session store from capturing a request context when it initializes or rearms maintenance timers. Shares the guard with Vert.x 5, removing its duplicate instrumentation. Adds latest-dependency regression tests for both timer paths.
Motivation
The latest-dependency Vert.x 4 worker tests timed out waiting for traces. The continuation timeline shows the session reaper rearming a Netty timer every second under the request context.
Additional Notes
The rearm regression test failed on master and passed with this change. The guard matches Vert.x 4 and 5. Vert.x 3 has the same session-store class and timer methods, so the existing Vert.x 4 Muzzle reference excludes it. The agent JAR size budget is unchanged.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue