Repository navigation
Conversation
DEBUG-3797 was fixed in dd-trace-java v1.60.0 (DataDog/dd-trace-java#10529, rate limit on span decoration probe errors). Replace the unconditional bug decorator with a manifest entry restricted to versions < 1.60.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 01033df | Docs | View more details | Give us feedback! |
Java's per-probe error sampler (AdaptiveSampler, 1/s) starts with a budget of 17 samples, so up to ~16 error snapshots are emitted in the first second. Raise the buffer to 20 for Java only; other languages keep the +5 buffer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sending 150 separate requests lowered the agent sampling rate for the weblog, dropping traces of the following span decoration tests. Use a span decoration line probe in the /debugger/budgets loop body and a single /debugger/budgets/150 request instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01033df704
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # Allow a buffer for timing imprecision. | ||
| max_expected = int(self.total_request_time) + 5 | ||
| # Java's adaptive sampler starts with a budget of 17, allowing an initial burst on top of the 1/s rate. | ||
| buffer = 20 if context.library == "java" else 5 |
There was a problem hiding this comment.
When this shared test is enabled for another tracer, this branch silently changes its assertion tolerance based on the runtime library. The repository's .cursor/rules/pr-review.mdc guideline explicitly prohibits runtime library branching in test logic and requires separate test methods selected through manifests; move the Java adaptive-sampler allowance into a Java-activated test rather than retaining context.library here.
AGENTS.md reference: AGENTS.md:L34-L36
Useful? React with 👍 / 👎.
| tests/debugger/test_debugger_probe_budgets.py::Test_Debugger_Probe_Budgets::test_span_probe_expression_budgets: bug (DEBUG-3797) | ||
| tests/debugger/test_debugger_probe_budgets.py::Test_Debugger_Probe_Budgets::test_span_probe_expression_budgets: | ||
| - declaration: bug (DEBUG-3797) | ||
| component_version: <1.60.0 |
There was a problem hiding this comment.
Quote '<1.60.0' here. The manifest syntax rule in .cursor/rules/pr-review.mdc requires values containing < to be quoted, so the newly added declaration does not conform to the repository's required YAML form and validation expectations.
AGENTS.md reference: AGENTS.md:L17-L24
Useful? React with 👍 / 👎.
Motivation
DEBUG-3797 was fixed in dd-trace-java v1.60.0 by DataDog/dd-trace-java#10529 (rate limit on span decoration probe errors).
Changes
@bugdecorator onTest_Debugger_Probe_Budgets::test_span_probe_expression_budgets.bug (DEBUG-3797)manifest entry inmanifests/java.ymltocomponent_version: <1.60.0.Workflow
system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.system-tests-core(slack)🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
🤖 Generated with Claude Code