Activity

1. alexeygrigorev

   added

   enhancementNew or improved functionalityNew or improved functionality

   needs groomingRaw intake that needs PM groomingRaw intake that needs PM grooming

   frontendFrontend UIFrontend UI

   P1ImportantImportant

   designDesign and UXDesign and UX

   and removed

   needs groomingRaw intake that needs PM groomingRaw intake that needs PM grooming

   on Jul 2, 2026
2. alexeygrigorev commented on Jul 2, 2026

   

   alexeygrigorev

   on Jul 2, 2026

   MemberAuthor

   More actions

   Software Engineer handoff — READY FOR TEST

   Reworked the dashboard Daily Queue so each row shows status + exactly one primary next-action button, removing the embedded completion editor and raw required-link/file inputs from the row (proof editing now routes to the task/workflow-detail surface).

   Approach

   • renderDashboardTaskTable: dropped the Required Proof column and the inline completion-proof / skip-closure / required-link / required-file editors. Each row now renders a single renderDashboardNextAction button.
   • Next-action mapping (new helpers renderDashboardNextAction, dashboardMissingProofActionLabel, dashboardTaskDeepLink):
     • waiting -> Follow up (scrolls to the existing full-width follow-up controls row, which is retained unchanged).
     • missing proof -> Add link / Add file / Add evidence (anchor deep-linking to the bundle workflow when the task has a bundle, else the task detail; completion stays blocked there).
     • ready, no missing proof -> Complete (completes in place; the status checkbox is also retained).
     • Open workflow fallback / done.
   • Intake follow-up rows keep their Open intake action.
   • Removed the now-dead dashboard event bindings (required-link/bundle-link save, file upload, save-completion-proof); added data-complete-task and data-dashboard-follow-up handlers. The workflow-detail (buildTaskRow) and task-list surfaces are unchanged and still host the editors.
   • CSS: #dashboard-tasks grid reduced 7->6 columns with a wider Next Action track; added .task-next-action button styling (nowrap, no truncation).

   Changed files

   • backend/src/public/app.js
   • backend/src/pages/index.html
   • backend/e2e/home-dashboard.spec.js (updated the 5 dashboard proof-editor specs to the new route-to-detail interaction, added a Complete-button spec, updated the layout spec to assert no embedded editors + no next-action truncation; removed the now-obsolete inline-save helpers)

   Tests (from backend/)

   • npm run typecheck — exit 0.
   • npm test — 1109 passed / 0 failed (160 suites).
   • npx playwright test home-dashboard follow-up-actions — 39 passed / 0 failed (home-dashboard 38 + follow-up-actions 1).

   Port guard applied: verified ports 3000/3001 free before each dev/Playwright run; waited ~30s for the shared 3001 e2e server to free up (the #104 worktree was using it) before the screenshot run.

   Screenshots (.tmp/screenshots/ux-audit/)

   • issue-103-daily-queue-1280.png — populated queue at 1280px: one button per row (Follow up / Add link / Add evidence / Complete), no inline editor, no URL inputs, no mid-word truncation; the waiting row keeps its full-width follow-up controls.
   • issue-103-daily-queue-390.png — mobile cards each show a single Next Action button; layout stacks cleanly, no truncation/overflow.

   Acceptance criteria

   • One primary next-action button per row, no inline completion editor / URL / file inputs — verified (screenshots + expectSingleQueueNextAction asserts 0 inline editors).
   • Button reflects state (Complete / Add link / Add evidence / Follow up / Open workflow) — verified per-state in specs + screenshot.
   • Ready task completes from the dashboard row — new Complete button spec + retained checkbox.
   • Missing-proof routes to detail, no inline editing, completion stays blocked — specs assert navigate href + editor available in detail + disabled checkbox.
   • No mid-word truncation at 1280px — 1280px screenshot + layout spec scrollWidth <= clientWidth check on .task-next-action.
   • Waiting/follow-up rows still expose follow-up actions; follow-up-actions.spec.js passes.
   • Intake follow-up rows keep "Open intake" — code path unchanged; exercised by existing intake specs.

   Notes

   • Ad-hoc (bundle-less) file-proof tasks: the task-list detail surface has no file uploader (only bundle detail / the removed dashboard editor did), so the file-proof spec uses a bundle-backed task that deep-links into the bundle workflow where the uploader lives. This keeps within the issue's "routing change only" scope; a task-list file uploader would be a separate enhancement.
   • No commit/push per process — awaiting Tester + PM acceptance.
3. alexeygrigorev commented on Jul 2, 2026

   

   alexeygrigorev

   on Jul 2, 2026

   MemberAuthor

   More actions

   Tester verdict — TEST PASS

   Verified the uncommitted implementation in the main checkout (backend/src/public/app.js, backend/src/pages/index.html, backend/e2e/home-dashboard.spec.js). All commands run from backend/.

   Commands & results

   Check	Command	Result
   Typecheck	npm run typecheck	exit 0
   Unit	npm test	1109 pass / 0 fail (160 suites), exit 0
   E2E queue+follow-up	npx playwright test home-dashboard follow-up-actions	39 passed / 0 failed, exit 0
   E2E detail surface	npx playwright test bundle-detail	16 passed / 0 failed (incl. missing-proof completion at :753), exit 0

   No reruns needed; zero flakes observed. Port guard applied: confirmed 3000/3001 == 000 before each Playwright run; used PORT=3020 for manual screenshots (Playwright server fixed at 3001).

   Screenshots (read at full resolution)

   • .tmp/screenshots/issue-103-daily-queue-1280.png — populated queue (Newsletter template workflow + ad-hoc waiting/ready/missing-proof tasks). Each row shows exactly one Next Action button; no inline completion note, "What changed" input, "Close as" dropdown, "Save evidence" button, or raw URL/file inputs.
   • Full-res crops (crop-nextaction-top/mid, crop-bottom, crop-atrisk) confirm every label renders complete: Follow up / Add link / Add file / Add evidence / Complete (green) — no mid-word truncation (the original "What chang"/"Choose rea" bug is gone).
   • .tmp/screenshots/issue-103-daily-queue-390.png — mobile cards each show a single Next Action button; waiting card keeps the full-width follow-up controls (Response received / Follow-up sent / Resolve done); no overflow/truncation.

   Acceptance criteria

   1. One next-action button per row, no inline editor/URL/file inputs — PASS (screenshots + expectSingleQueueNextAction asserts 0 of each editor selector).
   2. Button reflects state (Complete / Add link / Add evidence / Follow up / Open workflow) — PASS (per-state specs + screenshots).
   3. Ready task completes in place from the dashboard row — PASS (Dashboard ready task completes in place via the Complete button :967; checkbox retained).
   4. Missing-proof routes to detail; no inline editing; completion stays blocked — PASS (comment/external-status/file/required-link specs assert deep-link href + editor visible only in detail + disabled checkbox; bundle-detail :753 confirms detail-surface completion after proof).
   5. No mid-word truncation at 1280px — PASS (full-res crops + layout spec scrollWidth <= clientWidth+1 on .task-next-action).
   6. Waiting/follow-up rows still expose follow-up actions — PASS (follow-up-actions.spec.js in the 39; Follow up button scrolls to retained full-width controls, visible in both screenshots).
   7. Intake follow-up rows keep "Open intake" — PASS (code path unchanged; existing intake specs cover it).

   No scope drift: presentation/routing change only; no API/gating changes. The previously-flaky dashboard-evidence specs are now deterministic route-to-detail assertions.

   Verdict: TEST PASS.
4. alexeygrigorev commented on Jul 2, 2026

   

   alexeygrigorev

   on Jul 2, 2026

   MemberAuthor

   More actions

   PM acceptance — ACCEPTED

   Reviewed the uncommitted implementation in the main checkout (backend/src/public/app.js, backend/src/pages/index.html, backend/e2e/home-dashboard.spec.js) against the groomed AC and JTBD 1 / Dashboard-screen spec in docs/operations-manager-platform-jtbd.md. Read the Tester's screenshots at full resolution.

   Operator-perspective verdict

   Each Daily Queue row now surfaces the correct single next-required-click for its state, and it is clearly better than the old embedded editor.

   • One button per row, no embedded editor — verified in the 1280px screenshot and crops: rows show exactly one action (Follow up / Add link / Add file / Add evidence / Complete). No completion note, "What changed" input, "Close as" dropdown, "Save evidence" button, or raw URL/file inputs render inline. The old mid-word truncation ("What chang", "Choose rea", "Status from") is gone; every label renders in full at 1280px, and the layout spec enforces scrollWidth <= clientWidth+1 on .task-next-action.
   • State-correct next action — renderDashboardNextAction: waiting -> Follow up, missing proof -> Add link/file/evidence (or Open workflow), ready -> Complete, done -> Open workflow. Confirmed per-state in specs and the screenshot.
   • Ready completes in place — Complete button (data-complete-task) plus the retained status checkbox; new Complete spec passes.
   • Missing-proof routes coherently, completion stays blocked — the next action is a deep-link (#/bundles?...taskId= when the task has a bundle, else #/tasks?...taskId=), and it is not a dead-end: buildTaskRow on the detail surface renders the required-link input, the file uploader, and the completion-proof/skip-closure controls, and the dashboard checkbox is disabled with the missing-proof reason shown inline. bundle-detail.spec.js:753 confirms detail-surface completion after proof.
   • Follow-up + intake preserved — waiting rows keep the full-width follow-up controls (Response received / Follow-up sent / Resolve done); the "Follow up" button scrolls to and focuses them. Intake rows keep "Open intake". No mobile overflow/truncation at 390px.

   Scope / evidence

   • Presentation + routing change only; no task/bundle API, DynamoDB, or proof-gating changes. No drift from the groomed issue.
   • The one documented edge case (a bundle-less ad-hoc file-proof task whose requirement comes from a proof.type==='file' object rather than the requiresFile flag would land on a task-detail without an uploader) is narrow, is explicitly out-of-scope per this issue ("a task-list file uploader would be a separate enhancement"), and the common requiresFile ad-hoc case still gets an uploader in task detail. Not a blocker; fine as a separate follow-up if it ever surfaces in practice.
   • Tester ran the full workflow with screenshots: typecheck exit 0, unit 1109/1109, e2e home-dashboard+follow-up 39/39 and bundle-detail 16/16, no flakes.

   All acceptance criteria met. Cleared to commit with Closes #103.
5. alexeygrigorev

   closed this as completedin 3e6c2dcon Jul 2, 2026
6. alexeygrigorev

   added a commit that references this issue on Aug 14, 2026

   Surface a single next-action button per dashboard queue row (Closes #103

   ...

   This issue will close once commit 796695d is merged into the 'main' branch.

   796695d