Make assistant output review safe and lifecycle-complete

Status: blocked for coordinated release — final Tester PASS and PM ACCEPTED; exact commit 8839fcfb39a3553a673d395a7b3746e2c92218cd is clean on issue-158-stage-c-r1, held off main and unpushed; no shipped/deployed claim
Tags: bug, portal, assistant, frontend, backend, testing, data, design, P0
Related: historical frontend-convergence parent #148 is closed; #155, #156, and #157 are shipped
Depends on: #217 preview/deployment/post-deployment identity gate for coordinated publication; prior implementation dependencies are satisfied
Blocks: None
Next owner: Orchestrator after #217 release/identity PASS, for safe local integration and normal push; then On-Call
Resume condition: #217 completes its HUMAN preview, ordinary main/OIDC deployment, terminal On-Call result, and HUMAN identity verification; then resume coordinated publication without carrying the rejected old #146 candidate.

Product outcome

Make assistant-job review explicit, concurrent-safe, authenticated, and private. The canonical frontend/ flow creates and edits a persisted draft, exposes only actions valid for authoritative state, mediates every assistant-output access through a same-origin artifact-ID route, and recovers honestly from conflicts and failures.

Assistant jobs remain core internal capabilities, not plugins or model tools. Nothing in this issue publishes, sends, commits, dispatches, deploys, invokes an external provider write, or creates infrastructure.

The canonical work vocabulary is Template → Card → Task. Do not add workflow/bundle aliases, legacy fields, dual-read behavior, or defaulting for old rows.

Current defects confirmed in source

Creating in the canonical UI immediately submits; Retry immediately submits again instead of leaving a visible retrying state.
Assistant-job and artifact updates are unconditional. Job mutation, immutable event, artifact review, and Task/Card reference updates can partially succeed or race.
AssistantJobRecord has no version; repository reads cast persisted values without validating the canonical shape.
Browser routes can trust client requestedBy, actorId, or x-user-id fallbacks.
Operator-facing routes expose runner-owned transition, event, and artifact-attachment actions.
Assistant detail and shared artifact paths disclose provider URIs in records or nested references; the current privacy helper strips only s3://.
Approval can copy a private provider URI into Task.link, Card.cardLinks, and Task/Card artifactRefs.
Assistant job and event scans are not paginated.
Prevent lost Task updates and history with optimistic concurrency #179 and Complete and archive cards automatically when all tasks are done #168 now define strict Task/Card version, history, transaction, lifecycle, conflict, and audit behavior. Make assistant output review safe and lifecycle-complete #158 must compose with those contracts rather than update Task and Card independently.

Canonical server contract

Persisted Assistant Job

Every persisted Assistant Job has an integer version >= 1. New creation writes version 1 with an absence condition. Every operator or runner mutation supplies an exact expected version, checks the exact allowed source state, increments version once, and writes one immutable lifecycle event in the same DynamoDB transaction.

There is no versionless compatibility. Reads and lists reject missing, non-integer, or otherwise noncanonical rows with a sanitized data_contract_error; they never coerce or default them. Before production release, the operator performs the sanitized shape-only preflight in Stage C. If retained production rows are noncanonical, stop and separately groom disposable table/resource replacement. Do not add a migration, backfill, import, dual-read, or fallback.

A stale mutation returns JSON 409 version_conflict with a sanitized current-job summary. It performs no state change, attempt increment, artifact review, Task/Card update, or success event. Repository list/event reads paginate to completion without fixed result-count assumptions.

State and action table

Current state	Operator actions	Result
`draft`	Edit/Save, Submit, local/test Run dry, Cancel	Save remains `draft`; Submit becomes `queued`; Cancel becomes `canceled`.
`queued`	local/test Run dry, Cancel	A trusted runner may move to `running`; Cancel becomes `canceled`.
`running`	Cancel	Trusted runner owns `waiting_approval`, `succeeded`, or `failed`.
`waiting_approval`	Mediated access, Approve, Reject with reason, Cancel	Approve becomes `approved`; Reject becomes `rejected`; Cancel becomes `canceled`.
`failed` or `rejected`	Retry when attempts remain	Confirmed Retry becomes `retrying` and increments the attempt exactly once.
`retrying`	Submit retry, local/test Run dry, Cancel	Confirmed Submit retry becomes `queued`; it is a separate request.
`approved`	Read only	Trusted runner may complete `approved -> succeeded`.
`succeeded` or `canceled`	Read only	Terminal.

State validation is shared by repository/service and route callers. Ordinary browser actors cannot invoke generic transition, append-event, or attach-artifact actions. Delete those public operator endpoints rather than retain compatibility aliases; trusted runner and local dry-run code call package-internal transaction services with explicit actor provenance.

Artifact privacy and access

The full ArtifactRecord.storageUri remains server-private. Browser DTOs, nested Assistant Job refs/log refs, Task/Card artifact refs, events, errors, logs, DOM, history, and screenshots contain no stable URI, signed URI, credentials, token query, or provider object key. Public refs contain safe artifact ID metadata only.

One server-owned policy and serializer are used by Assistant detail, Artifacts list/detail, nested refs, and access actions. Defense-in-depth response privacy removes every storageUri key recursively, regardless of scheme.

The browser receives only same-origin artifact-ID actions such as /api/artifacts/<id>/access?action=open|preview|download plus safe capability metadata:

Provider	Required behavior
DataOps-owned `s3`	Reauthorize each action. Only already-configured DataOps buckets are eligible; no IAM/infra expansion. The server may respond with a short-lived redirect. Unsafe inline types are attachment-only.
`local-dev`	Deterministic local/test fixture only. Production fails closed. The URI is never rendered.
`github`, `google-drive`, `dropbox`, `external-url`	Revalidate HTTPS, provider/host consistency, and absence of credential/token query at access time. Descriptor shows only provider and safe destination hostname before a same-origin Open action redirects.
Unknown, missing, malformed, disallowed bucket/host/content	No fabricated link. Return a sanitized retryable JSON unavailable error.

New-tab access uses noopener. An attacker-controlled filename or content type cannot execute active content in the portal origin. Tests use synthetic resolvers and make no AWS or provider call.

Canonical Task/Card integration

Creating from Task/Card context validates that referenced entities exist and, when both IDs are present, that the Task belongs to the Card.

Assistant Job and approved Artifact references are additive ID metadata only. Approval must never copy a provider URI into Task.link, Card.cardLinks, ArtifactRef, or AssistantJobLogRef; a private artifact does not silently satisfy a URL-proof requirement.

Any approval that touches a Job, its Artifacts, a Task, or a Card is one bounded DynamoDB transaction with exact source-state/version conditions and one audit outcome. It preserves #179 Task history/version and #168 Card counters/lifecycle/audit/owner behavior. Build the transaction from strong current reads; if any condition changes, return 409 with no blind retry and no partial review. Reject an oversized review batch before writing, based on the actual DynamoDB transaction capacity rather than truncating output IDs.

Acceptance criteria

Implementation stages

Stage A1 — backend domain, persistence, privacy; eligible locally now

Own Assistant Job/Artifact types, repositories, domain transaction services, public DTO/access policy, and focused backend tests only.

Implement strict Job validation/versioning, conditional create/mutations, atomic events/reviews, pagination, URI-free public refs/DTOs, provider eligibility, and same-origin access decisions. Keep actor resolution an explicit service input so this stage does not invent another auth path.

Do not edit frontend, Playwright/browser inventory, deploy workflow, SAM/infra, import/export/restore, or #180-owned paths. After Assistant Engineer, Architect, Tester, and PM acceptance, make an explicit-path Refs #158 checkpoint commit and keep it on an isolated branch, off main and unpushed.

Stage A2 — authenticated routes and Task/Card composition

Depends on Tester/PM-accepted #164 Stage A. Reuse its single verified active-User/supported-role actor resolver; do not duplicate it.

Wire public operator actions and artifact access, remove generic public runner actions, deny spoofed actor sources, and compose approval with exact #179/#168 Task/Card conditions. Focused API request/permission/concurrency tests own the matrix; Playwright does not duplicate it.

Accept and checkpoint with Refs #158, still off main.

Stage B — canonical UI and independent browser behavior

Depends on Tester/PM-accepted #180 source. Rebase or reconstruct from its accepted UI/browser baseline before editing Assistant, shared Artifact, Task-evidence, focus/navigation, or browser paths.

Implement explicit draft Save, two-step Retry/Submit retry, confirmations, authoritative refresh, safe artifact actions, responsive states, and conflict/failure recovery. Preserve #180’s accepted focus, navigation, server-isolation, accessibility, and race fixes.

Use real local API behavior with synthetic DynamoDB fixtures. Do not use request interception, mocked entity payloads, fixed sleeps, browser-history arithmetic, exact incidental copy, serialized byte pins, or screenshot-only proof. Add behavior titles to the independent non-deploy-blocking browser workflow and preserve its failure artifact/report upload; the full browser suite must not become a deploy prerequisite.

After Designer, Tester, and PM acceptance, checkpoint with Refs #158, still off main.

Stage C — steady-state integration and release

No #158 commit may enter the reviewed #166 Phase D artifact or transitional rollout chain. Wait for repaired #166 A/B/C, #182’s final Cards preflight while writers are closed, reviewed D, canonical first-write evidence, and accepted cleanup restoring the ordinary push OIDC workflow.

Then reconstruct/rebase the accepted #158 stages onto clean steady-state main, run the sanitized read-only Assistant Job/Artifact shape preflight, and fully reverify. If the preflight finds noncanonical retained rows, stop for a separate disposable-resource replacement plan; do not migrate, backfill, restore, import, or add compatibility.

Only then receive final Tester PASS and PM ACCEPTED, commit with Closes #158, merge/push normally, and obtain source/deployed on-call evidence.

Behavior scenarios

Concurrent lifecycle winner

Given two authenticated clients loaded at one Job version
When they concurrently save, submit, retry, approve/reject, or cancel
Then exactly one transaction wins; the loser receives 409; Job, event, attempts, Artifact review, and Task/Card references show no partial or duplicate effect

Retry remains visible

Given a failed or rejected Job with attempts remaining
When confirmed Retry succeeds and Submit retry later fails by a deterministic server fault
Then authoritative state remains retrying, no queued success is claimed, and Submit retry remains available after refresh/reload

Mediated provider access

Given synthetic allowed and denied records for every provider class
When an active operator reads detail and activates offered actions
Then the central policy allows only the declared behavior, unsafe cases fail closed, and stored/signed URIs never appear in JSON, DOM, logs, errors, history, or screenshots

Identity boundary

Given active admin/operator, disabled/deleted/unsupported users, expired/absent sessions, and spoofed identity headers/body fields
When each reads or mutates a Job or accesses an Artifact
Then only verified active supported actors receive state-valid behavior; all others receive JSON 401/403 and no side effect

Task/Card approval composition

Given a canonical Job linked to a canonical Task/Card and a concurrent Task/Card version change
When approval is attempted
Then relation and versions are revalidated, conflict returns 409, and no Job, Artifact, Task, Card, or audit item partially changes; a later fresh approval records only safe IDs

Responsive recovery

Given draft, confirmation, waiting approval, retrying failure, unavailable artifact, and conflict fixtures
When used by keyboard and pointer at desktop and mobile viewports
Then state, context, safe actions, error recovery, return navigation, and focus remain reachable without clipping or horizontal overflow

Verification contract

Stage owners run only checks proportional to their paths. The final combined candidate requires backend tests, typecheck, build, behavior-based browser tests, affected-state accessibility, source/SAM frontend parity, and git diff --check; commands/counts/exit codes and sanitized evidence are recorded by Tester.

Do not run or add import, migration, export, restore, or production-data suites. Do not call AWS or external providers. Exact screenshot names may be chosen at Stage B grooming, but assertions must be based on behavior, semantics, focus, and safe content—not pixels, file bytes, incidental prose, fixed timing, or exact history counts.

Lifecycle gates

Out of scope

Reopening Converge DataOps onto one canonical frontend #148/Port assistant job lifecycle to the canonical frontend #152/Verify the canonical frontend through normal DataOps deployment #155/Complete canonical frontend deep-link and operator parity #156/Secure and structure runtime-template administration #157, restoring the retired SPA, another router/frontend, broad information-architecture redesign, or compatibility aliases.
New assistant engines, prompts, skills, plugin discovery, conversational/model mutation tools, or edits to source-system/private-knowledge repositories.
Publishing, messaging, document commits, workflow dispatch, scheduling, provider writes, real assistant execution, credentials, AWS calls, manual deploy, or IAM/infrastructure expansion.
Per-user artifact ACLs, new roles, upload/retention redesign, provider integrations, or active-content preview.
Any migration framework, compatibility read, defaulted version, data backfill, import/export/restore change or test, production data mutation, or destructive cleanup.
Raw/private operational knowledge, real people/contact data, private links, production identifiers, credentials-adjacent notes, or generated operational artifacts in this public repository.

PM GROOMED — dependency blocked

Rewrote #158 as a self-contained P0 bug spec after reviewing the process/PM contract, the full issue, #148/#152/#154/#155/#156/#157 sequencing, the accepted conversational-agent/plugin architecture, and the assistant/artifact/API/canonical-frontend code at exact current main 56a1e2abd3f803172ea78bc9cd511bacc3733c31.

The bounded product decisions are now explicit:

create persists a draft and never auto-submits;
draft edit and every lifecycle action are state-gated, confirmed, versioned, and conditionally written;
failed/rejected Retry and retrying Submit retry are two visible refresh-backed steps;
every success/failure/reload rehydrates authoritative job, artifact, and event state;
assistant-output access is provider-aware and same-origin/artifact-ID-mediated, with no stable/signed storageUri in browser-facing JSON, DOM, logs, errors, or evidence;
enabled operators/admins are allowed, while unauthenticated, disabled, expired, and spoofed identities are denied without mutation or disclosure;
real API/browser permission, provider, concurrency, partial-failure, reload, accessibility, and responsive scenarios plus exact screenshots are required;
assistant jobs remain core internal infrastructure, not conversational plugins/model tools, and approval cannot publish, send, dispatch, deploy, or perform an external provider write.

#157 is already shipped on main. #158 must not start while #156's accepted frontend work remains outside main because both own frontend/src/app.js, styles, and canonical Playwright coverage. Resume only after #156 completes Tester/PM/commit/merge-push/source-On-Call integration onto the main containing #157, then create a fresh #158 worktree from that clean converged main. #158 also blocks final #155 deployed acceptance and #148 closure.

Required specialist order is Assistant Engineer, Architect, and Designer on the frozen uncommitted candidate, followed by Tester and PM. needs grooming was removed; the existing appropriate bug/portal/assistant/frontend/backend/testing/data/design/P0 labels were retained. No repository source, assistant execution, external message, deploy, workflow dispatch, or AWS action was performed.

Next owner: Software Engineer after the #156 integration resume condition is recorded.

PM lifecycle/dependency reconciliation complete.

Decision: #158 remains blocked as a whole, but backend Stage A1 is implementation-ready locally now.

Read-only findings:

The old Complete canonical frontend deep-link and operator parity #156 dependency and the claims that Make assistant output review safe and lifecycle-complete #158 blocks Verify the canonical frontend through normal DataOps deployment #155/Converge DataOps onto one canonical frontend #148 were stale. Converge DataOps onto one canonical frontend #148, Verify the canonical frontend through normal DataOps deployment #155, Complete canonical frontend deep-link and operator parity #156, and Secure and structure runtime-template administration #157 are closed and integrated.
Accepted Prevent lost Task updates and history with optimistic concurrency #179 02ee455efad09865ecdbd578e940c59e0bf7dc36 and Complete and archive cards automatically when all tasks are done #168 41dca9e3748fe627c195f48a7f97ae203b343f60 are local ancestors and now define the strict Task/Card version, history, transaction, lifecycle, conflict, and audit inputs.
Current Assistant Job writes are unconditional and unversioned; lifecycle events, Artifact review, and Task/Card mirroring are separate writes. Races can duplicate or partially apply effects.
Current route identity can fall back to browser requestedBy, actorId, or x-user-id; generic runner transition/event/artifact actions are operator-facing.
Current Assistant/Artifact serialization and Task/Card mirroring expose non-S3 provider URIs, and approval can copy private storage into Task.link and Card.cardLinks.
The existing UI auto-submits Create and Retry, contradicting the required visible draft and retrying -> Submit retry lifecycle.
Show signed-in identity and authorized teammates’ Task/Card work #164 now owns the shared verified interactive actor resolver, so Make assistant output review safe and lifecycle-complete #158 route authorization must consume that accepted resolver rather than implement a second identity policy.
Restore behavior-based browser coverage and fix canonical UI accessibility races #180 owns active shared UI focus/navigation/browser-race work, so Make assistant output review safe and lifecycle-complete #158 frontend/browser paths must start from its accepted source.
No Replace the transitional Tasks table with the final cardId schema #166 production phase has run. Make assistant output review safe and lifecycle-complete #158 must not enter or alter the reviewed transitional/Phase D artifact.

The issue now has four explicit stages:

Stage A1, eligible now: strict Assistant Job schema/versioning, atomic lifecycle/event/review services, pagination, URI-free browser DTOs/refs, and central provider/access policy with focused backend tests. Isolated worktree; no frontend/browser/deploy/SAM/import/export/restore paths; accepted Refs #158 commit held off main.
Stage A2: after Show signed-in identity and authorized teammates’ Task/Card work #164 Stage A acceptance, wire the shared active-User resolver, remove ordinary access to runner-owned actions, and compose approvals atomically with canonical Task/Card conditions.
Stage B: after Restore behavior-based browser coverage and fix canonical UI accessibility races #180 acceptance, implement the explicit UI lifecycle and behavior-based independent browser coverage while preserving its non-deploy-blocking workflow and artifact upload.
Stage C: only after Replace the transitional Tasks table with the final cardId schema #166/Gate canonical Card lifecycle on the empty production Cards table #182 completes cutover/evidence/cleanup, reconstruct on steady-state main, perform a sanitized read-only shape preflight, fully verify, merge, push, and obtain on-call evidence.

The previous “versionless rows read as version 1” rule is removed. Missing/invalid versions fail closed. If retained production data is noncanonical, release stops for a separately reviewed disposable-resource replacement; no migration, backfill, import, restore, dual-read, or compatibility path is allowed.

No repository file, test, AWS/provider resource, credential, production data, import/export/restore path, deployment, commit, or push was touched during this reconciliation.

ARCHITECTURE REVIEW — #158 Stage A1

Verdict: FAIL for candidate fingerprint dc65cf81eb223f08683609f532c56ba21afc1e3e1291880083112dc70bbb2fd5.

The reviewed tree contained six modified backend files and three untracked Assistant/Artifact/transaction support files. It is not implementation-ready.

Blocking findings:

Assistant Job creation violates its own canonical contract. createAssistantJob forbids caller-supplied version but never assigns version: 1 before validation, so every creation throws AssistantJobDataContractError. Focused result: Assistant Jobs 0 passed / 6 failed.
The seam does not compile coherently. Backend typecheck produced roughly 60 errors across Assistant Jobs, Artifacts, Email Documents, and Intake. Examples include stale publicArtifact calls after route migration, obsolete storage URI artifact references, old update signatures, and deleted Task/Card mirror helpers. Missing compile success means core contracts were not implemented atomically.
Lifecycle, event, review, and mirror writes remain non-atomic. Additional write helpers exist, but domain services do not compose Job + event + Artifact review + downstream proof under one conditional transaction. Approval/retry flows can partially apply.
Canonical version/state/action semantics are incomplete. Retry can increment attempt data at the route while permitting unrelated repository patches; events are not constrained consistently by valid source state/action transitions.
Pagination and URI-free browser DTO/ref behavior are not fully implemented across the seams.
Central provider/access policy and privacy controls remain incomplete; private provider/storage details can leak through refs, mirrors, or serialized artifacts.
Focused Artifact results are 1 passed / 5 failed, and the candidate adds no adequate tests for canonical rows, optimistic conflicts, atomic rollback, pagination, privacy, retry semantics, or review transactions.

Stage boundaries remain unchanged: this failure concerns Stage A1 only. Shared actor authorization remains #164/Stage A2, shared UI remains #180/Stage B, production phase/cutover remains Stage C. A replacement must start cleanly from current accepted main, preserve the strict no-migration/no-dual-read/no-compatibility-shim rules, and deliver focused backend coverage with typecheck/tests/build all passing before Tester review.

SOFTWARE ENGINEER — #158 Stage A1 candidate (repair from clean baseline)

Stage A1 only, in the isolated worktree dataops-issue-158-repair on branch issue-158-stage-a1-repair (base 5099b59). Nothing is committed, merged, pushed, or deployed; no AWS/provider call, no source-repo edit, no infrastructure/SAM/deploy/import/export/restore/migration change.

What changed and why

Canonical Assistant Job persistence — backend/src/db/assistantJobs.ts (rewritten)

AssistantJobRecord.version is now part of the type; creation assigns version: 1 itself and rejects any caller-supplied version or non-draft creation status, so the previous "creation always throws" defect cannot recur.
parseAssistantJob validates every read against the canonical shape (id, integer version >= 1, known status, ref arrays, boolean approvalRequired, integer attempt fields, timestamps) and throws a sanitized AssistantJobDataContractError (code: 'data_contract_error'). Nothing is coerced, defaulted, dual-read, or migrated.
createAssistantJob writes the job and its immutable created event in one transaction under attribute_not_exists(PK).
mutateAssistantJob is the only mutation path: strong read, exact expectedVersion check, one version increment, one immutable event, plus optional conditional artifact writes — all in one TransactWriteCommand. updateAssistantJob/appendAssistantJobEvent (unconditional, event-detached writes) are deleted, not aliased.
Conflicts are typed: AssistantJobVersionConflictError (carries the authoritative current job), AssistantJobReviewConflictError (names the stale artifacts), AssistantJobReviewBatchTooLargeError (rejects a batch before writing, at the real 100-item DynamoDB transaction capacity, without truncating output IDs).
Local/test transaction emulation mirrors the accepted taskCardLifecycle pattern (pre-checked conditions, serialized, snapshot rollback on failure). Deployed code always sends the single atomic command.
listAssistantJobs and listAssistantJobEvents follow LastEvaluatedKey to completion; listArtifacts does too (backend/src/db/artifacts.ts, which also gains getArtifactConsistent for review guards).

Domain lifecycle service — backend/src/assistant/jobLifecycle.ts (new)

One table of actions encodes the issue's state/action contract: save-draft, submit, submit-retry, retry, approve, reject, cancel (operator) and start, request-approval, complete, fail, attach-artifact, append-log (runner).
assertAssistantJobAction/assistantJobActionsFor are the shared gate used by service and route callers. Retry increments the attempt exactly once and stops at maxAttempts; Submit retry is a separate action that spends no attempt. complete from running is refused while approval is required.
Approve/Reject read each output artifact strongly and carry its review decision inside the job transaction, guarded by the exact updatedAt the caller read.
Actor resolution stays an explicit service input ({ kind: 'operator' | 'runner', actorId? }); the service reads no header, session, or body. Route authorization remains Stage A2.

Central artifact provider/access policy — backend/src/artifacts/accessPolicy.ts (new)

One server-owned serializer (publicArtifact, publicArtifactRef) and one decision function (resolveArtifactAccess) used by Assistant detail, Artifacts list/detail, nested refs and the existing private-download route.
Browser DTOs drop storageUri entirely and expose provider, safe destination hostname, and a same-origin access capability (/api/artifacts/<id>/access + allowed actions).
Provider rules: DataOps-owned s3 is limited to already-configured buckets/prefixes/data classes and reauthorized per action with a 300s injected signer; local-dev is a deterministic fixture that fails closed in production and never renders a URI; github/google-drive/dropbox/external-url revalidate HTTPS, provider/host consistency and credential-free query at access time; unknown/malformed/disallowed cases return sanitized, retryable unavailability. Unsafe inline content types and hostile filenames are attachment-only and sanitized.
The signer is injected, so tests make no AWS or provider call.

Privacy — backend/src/responsePrivacy.ts, refs and mirrors

sanitizeInternalStorage now removes every storageUri key recursively regardless of scheme (defense in depth behind URI-free builders).
ArtifactRef and AssistantJobLogRef no longer carry storageUri; runner log refs containing one are rejected with 400.
Approval mirrors safe IDs only: the Task.link / Card.cardLinks auto-population from a private artifact URI is deleted. A private artifact no longer silently satisfies a URL-proof requirement.
backend/src/routes/intake.ts: assistant input refs no longer copy file/artifact storage URIs, registered artifact refs are sanitized to safe fields, and intake job creation now goes draft-v1 → explicit conditional submit.
backend/src/routes/emailDocuments.ts uses the shared publicArtifactRef.

Routes kept compiling coherently (no new auth) — backend/src/routes/assistantJobs.ts rewritten onto the services: every mutation requires expectedVersion and the exact source state, 409 version_conflict returns a sanitized current-job summary, submit-retry exists as its own action, run-dry chains package-internal service calls with explicit runner provenance, and detail advertises operator actions only. Removing the public runner endpoints and wiring the verified actor resolver remain Stage A2.

Changed files

Modified: backend/src/types.ts, backend/src/responsePrivacy.ts, backend/src/db/assistantJobs.ts, backend/src/db/artifacts.ts, backend/src/routes/assistantJobs.ts, backend/src/routes/artifacts.ts, backend/src/routes/intake.ts, backend/src/routes/emailDocuments.ts, backend/tests/api-assistant-jobs.test.ts, backend/tests/api-artifacts.test.ts, backend/tests/api-podcast-slice.test.ts, backend/tests/export-portable.test.ts
New: backend/src/assistant/jobLifecycle.ts, backend/src/artifacts/accessPolicy.ts, backend/tests/assistant-job-repository.test.ts, backend/tests/assistant-job-lifecycle.test.ts, backend/tests/artifact-access-policy.test.ts
Diff: 12 modified files (+1380 / −741) plus 5 new files (1538 lines).

Commands, exit codes, counts

Command	Exit	Result
focused: `node --import tsx --test --test-force-exit tests/api-assistant-jobs.test.ts tests/assistant-job-repository.test.ts tests/assistant-job-lifecycle.test.ts tests/artifact-access-policy.test.ts tests/api-artifacts.test.ts tests/api-podcast-slice.test.ts tests/api-intake.test.ts tests/api-email-documents.test.ts tests/mailing-exports.test.ts tests/export-portable.test.ts` (npm-test env)	0	81 tests / 12 suites, 81 pass, 0 fail
`npm --prefix backend test`	0	1008 tests / 160 suites, 1007 pass, 0 fail, 1 skipped (pre-existing), 42.3s
`npm --prefix backend run typecheck`	0	src + tests + scripts projects clean
`npm --prefix backend run build`	0	tsc, runtime-boundary verify, frontend artifact copy/verify all pass
`git diff --check`	0	no whitespace errors

New focused coverage: 9 repository tests (canonical v1 creation, caller-version/non-draft/duplicate refusal, five noncanonical row shapes rejected on read and list, single version increment + single event, stale-version no-op, review-guard conflict, injected-failure rollback leaving job/event/artifact untouched, oversized batch rejected before writing, multi-page scans for jobs/events/artifacts), 7 lifecycle tests (exact state/action table per actor, operator↔runner action isolation, approval-required completion refusal, retry attempt semantics and limit, approval + reviews + event as one transaction with replay refused, concurrent rejection single winner, draft-only editing), 8 policy tests (per-action s3 reauthorization, unsafe-inline/hostile-filename attachment-only, disallowed bucket/prefix/data class, malformed URI, local-dev fail-closed vs local fixture, external provider scheme/host/credential revalidation, URI-free DTOs/refs, recursive storageUri removal), plus 10 rewritten API tests including a concurrency race with a single winner.

Security and concurrency notes

Exactly one winner per mutation: the loser gets 409 version_conflict and produces no state change, attempt increment, artifact review, event, or Task/Card effect (asserted at both API and service level).
Every job mutation, its immutable event, and any artifact review commit as one transaction; the emulated local path is pre-checked and snapshot-rolled-back, and the rollback is asserted.
No provider URI appears in browser-facing JSON at any depth: URI-free builders plus a recursive sanitizer, asserted on detail, review, dry-run, mirrored Task/Card refs, and intake inputs.
Provider access fails closed for unknown/malformed/disallowed bucket/host/content, and preview of active content types is downgraded to attachment. All tests use synthetic resolvers; no AWS or provider request is made.
Approval cannot fabricate URL proof: a completed Task with a required link now needs a human-supplied link (encoded in the podcast slice test).
No table creation, no infrastructure, no secret, no production identifier; local-dev artifacts are fixtures only.

Remaining stage boundaries (unchanged)

Stage A2: reuse Show signed-in identity and authorized teammates’ Task/Card work #164's verified active-User/supported-role resolver, delete the public runner transition/append-event/attach-artifact endpoints, wire /api/artifacts/<id>/access, and compose approval with exact Prevent lost Task updates and history with optimistic concurrency #179/Complete and archive cards automatically when all tasks are done #168 Task/Card conditions. This candidate deliberately leaves header-derived actor input and the existing /api/artifacts/<id>/download JSON contract (used by accepted email-document and mailing-export flows) untouched.
Stage B: canonical UI (explicit Save, two-step Retry/Submit retry, confirmations, authoritative refresh, safe artifact actions) on Restore behavior-based browser coverage and fix canonical UI accessibility races #180's accepted baseline. Frontend and Playwright inventory were not edited here, so browser flows still call the pre-Stage-B shapes; that is expected until Stage B.
Stage C: steady-state reconstruction, sanitized read-only shape preflight, full reverification, and only then Closes #158.
Artifact rows still have no version column; conditional artifact writes are guarded by the exact updatedAt image the caller read. Real TransactWriteItems behavior against DynamoDB Local (docker) is not covered by a .ddb.ts suite for assistant jobs; the local suite uses the same emulator seam the accepted Task/Card work uses. Flag if Tester wants a docker suite added in A2.

Notes: backend/node_modules was installed in this fresh worktree to run the checks; .tmp-issue-158.json at the repo root is pre-existing untracked scratch from an earlier session and was left alone. Scratch runner lives in .tmp/run-backend-tests.sh.

Next owner: Assistant Engineer and Architect review of the Stage A1 candidate, then Tester and PM.

TESTER — PASS (bounded Stage B Artifact/task-proof increment)

Independent result is PASS for this increment only: Artifact index safe access, Task/Card proof rendering, assistant-owned review routing, revisioned unbound approval, search privacy projection, and retained browser assertions.

Worktree: /home/alexey/git/dataops-issue-158-stage-b-r1
Branch: issue-158-stage-b-r1
HEAD: 528a0b608aa57034be6b95d80705d11d4b287cee
Tracked diff SHA-256: a3278abc8089daed8fe3e4a26589dfd7b3b2449facadc681376c46b7a4ec90d8
Candidate content SHA-256: a3278abc8089daed8fe3e4a26589dfd7b3b2449facadc681376c46b7a4ec90d8
Status-path manifest SHA-256: 3b2419f14fb395a23c4ee1b3c73b5d215e80422c6cec53dedc0d7c05753ebdf8
Status paths: backend/e2e/canonical-capability-behavior.spec.js; frontend/src/styles.css; frontend/src/surfaces/knowledge/search.js; frontend/src/surfaces/operations/artifacts.js; frontend/src/surfaces/work-detail/task-evidence.js; frontend/test/operations-surface.test.mjs; frontend/test/work-detail-surface.test.mjs
Fingerprints were identical on consecutive post-run checks. main remained at ab0d805.

Evidence, all exit 0:

node --test frontend/test/operations-surface.test.mjs frontend/test/work-detail-surface.test.mjs frontend/test/frontend-architecture.test.mjs: 41/41 passed, 4 suites.
npm run test:frontend:unit: 215/215 passed, 22 suites.
npm run test:frontend:coverage: 215/215 passed; 73.57% statements, 68.34% branches, 71.69% functions.
npm run typecheck:backend.
npm run build:backend: runtime boundary verified, 68 frontend assets copied, dependency inventory 0.
npm run test:backend: 1,091 tests / 165 suites; 1,090 passed, 0 failed, 1 skipped.
CI= DATAOPS_E2E_SERVER_PORT=3511 npx playwright test e2e/issue-158-stage-b-assistant-review.spec.js --retries=0 --reporter=line: 2/2 passed.
CI= DATAOPS_E2E_SERVER_PORT=3512 npx playwright test e2e/canonical-capability-behavior.spec.js --grep assistants and artifacts provide|Tasks and Workflows persist --retries=0 --reporter=line: 2/2 passed.
Syntax checks for the changed JS/E2E files: pass; git diff --check: pass.
Frontend and built-frontend privacy scan found no storageUri, storage_uri, or local-dev://. The only remaining scoped storageUri text is in two direct synthetic API setup payloads in retained E2E; page/UI code does not read, render, or derive links from it.

Contract evidence: unavailable artifacts render no links; offered links are same-origin artifact-ID access routes with noopener; Task/Card proof has no Register UI; assistant-owned artifacts expose Open assistant review and no generic Approve; unbound approval sends expectedRevision; search uses safe metadata only.

Tester made no repository changes, commit, merge, push, or provider/AWS call. This PASS does not cover the already accepted assistant-review checkpoint beyond its retained regression, Stage C, final #158 acceptance, or integration/release gates. PM acceptance is still required.

DESIGNER — CHANGES REQUESTED (Stage B Artifact/Task/Card proof slice)

The safe-access and responsive composition are otherwise sound, but one mobile usability change is required before design sign-off:

At 390×844, the new mediated Artifact links and the Open assistant review action measure 32px high in the live browser. The design-system mobile baseline is at least 44px for interactive targets. Increase the new access/review controls to the mobile target size while preserving their wrapping.

Verified positives:

Artifact index, Task panel, and Card panel render safe provider/type/hostname/size metadata only; no provider URI appears.
Access actions are same-origin artifact-ID routes with target="_blank" and rel="noopener".
Unavailable access is rendered as a role="status" state with no fabricated link.
Assistant-bound output shows Open assistant review, routes to the canonical assistant detail, and does not expose a generic Approve action.
Native keyboard focus remains reachable; no horizontal overflow was observed.
Axe scans found 0 serious/critical violations in each reviewed surface.

Evidence (synthetic local API fixtures only):

Desktop/mobile Artifact index: .tmp/screenshots/issue-158/stage-b/artifacts-index-{desktop-1440x900,mobile-390x844}.png
Desktop/mobile Task panel: .tmp/screenshots/issue-158/stage-b/task-panel-{desktop-1440x900,mobile-390x844}.png
Desktop/mobile Card panel artifact proof: .tmp/screenshots/issue-158/stage-b/card-panel-{desktop,mobile}-artifact-evidence-*.png
DATAOPS_E2E_SERVER_PORT=37158 npx playwright test e2e/canonical-capability-behavior.spec.js --grep "assistants and artifacts provide" --retries=0: 1/1 passed
DATAOPS_E2E_SERVER_PORT=37159 npx playwright test e2e/canonical-capability-behavior.spec.js --grep "Tasks and Workflows persist" --retries=0: 1/1 passed
Inline Playwright probe against real scripts/test-server.ts on port 37160: all six viewport/surface checks reported no overflow and 0 serious/critical Axe findings; assistant-review route was verified.

Scope is limited to this uncommitted Stage B Artifact index and Task/Card proof increment. No repository files were edited, committed, merged, pushed, or connected to real providers; Stage C and the earlier assistant-review checkpoint are outside this verdict.

DESIGNER — PASS (Stage B Artifact/Task/Card proof follow-up)

Rechecked the exact uncommitted CSS-only follow-up in frontend/src/styles.css.

Mediated Artifact access links and Task/Card Open assistant review buttons now use min-height: 44px, resolving the only prior design finding.
Prior synthetic desktop/mobile evidence remains clean for hierarchy, safe metadata, same-origin noopener actions, unavailable-state semantics, assistant-review routing, approval-state presentation, focus behavior, overflow, and serious/critical Axe findings.
Focused UI/architecture tests: 41/41 passed.
Backend build/runtime-boundary/frontend-artifact verification: passed.
Real local API Playwright journeys: Artifact 1/1 passed; isolated Task/Card 1/1 passed with retries disabled.

No remaining design issue for this increment.

Scope is limited to the CSS follow-up for the uncommitted Stage B Artifact index and Task/Card proof candidate in /home/alexey/git/dataops-issue-158-stage-b-r1. No repository files were edited, committed, merged, pushed, or connected to real providers.

TESTER — PASS (fresh bounded Stage B Artifact/task-proof recheck)

Fresh independent PASS for the exact current candidate, limited to the CSS-only 44px touch-target delta in the new Artifact access and Task/Card review controls. Designer recheck is noted; no source or history changes were made.

Worktree: /home/alexey/git/dataops-issue-158-stage-b-r1
Branch: issue-158-stage-b-r1
HEAD: 528a0b608aa57034be6b95d80705d11d4b287cee
Tracked diff SHA-256: 62bc782761ba6f26d29ae0606fd3d0b2916f1debb9d065458460a8b91fdd9218
Candidate content SHA-256: 62bc782761ba6f26d29ae0606fd3d0b2916f1debb9d065458460a8b91fdd9218
Status-path manifest SHA-256: 3b2419f14fb395a23c4ee1b3c73b5d215e80422c6cec53dedc0d7c05753ebdf8
Status paths remain exactly: backend/e2e/canonical-capability-behavior.spec.js; frontend/src/styles.css; frontend/src/surfaces/knowledge/search.js; frontend/src/surfaces/operations/artifacts.js; frontend/src/surfaces/work-detail/task-evidence.js; frontend/test/operations-surface.test.mjs; frontend/test/work-detail-surface.test.mjs
HEAD and status-path manifest are unchanged from the prior PASS; only the tracked/content fingerprint moved for the 32px to 44px CSS adjustment.

Targeted checks, all exit 0:

node --test frontend/test/operations-surface.test.mjs frontend/test/work-detail-surface.test.mjs frontend/test/frontend-architecture.test.mjs: 41/41 passed, 4 suites.
node --check on the three changed frontend JS files and retained E2E spec: all passed.
npm run build:backend: runtime boundary verified, 68 frontend assets copied, dependency inventory 0.
git diff --check: clean.
Frontend and built-frontend privacy scan for storageUri, storage_uri, and local-dev://: clean.

The prior no-retry affected browser evidence remains applicable because this recheck changes only CSS: Stage B assistant-review 2/2 and retained assistant/artifact plus Task/Card proof 2/2. The 44px controls are covered by the focused DOM/render tests and Designer responsive/touch recheck.

This PASS is only for this CSS-adjusted Artifact/task-proof increment. It does not extend the accepted assistant-review checkpoint, Stage C, final #158 acceptance, or integration/release gates. No commit, merge, push, AWS call, or provider call was made.

PM ACCEPTED — bounded Stage B Artifact/task-proof increment

I accept this increment only in /home/alexey/git/dataops-issue-158-stage-b-r1 on branch issue-158-stage-b-r1, against accepted checkpoint 528a0b608aa57034be6b95d80705d11d4b287cee.

Current candidate fingerprints:

Tracked diff/content SHA-256: 62bc782761ba6f26d29ae0606fd3d0b2916f1debb9d065458460a8b91fdd9218
Status-path manifest SHA-256: 3b2419f14fb395a23c4ee1b3c73b5d215e80422c6cec53dedc0d7c05753ebdf8
Exactly seven intended modified paths; git diff --check is clean.

The product contract is met for this slice: Artifact index and Task/Card proof expose safe metadata plus same-origin artifact-ID access actions only; no browser-facing storageUri or provider URI is read or rendered; unavailable artifacts have no fabricated links; assistant-owned artifacts route to assistant review and do not expose generic approval; unbound approval sends expectedRevision; and the obsolete canonical relation-registration UI is removed. The focused 41/41 UI/architecture tests, build/privacy checks, real synthetic no-retry browser journeys, responsive/mobile 44px touch-target review, and a11y/overflow evidence are green. See Tester PASS, fresh current-tree Tester recheck, and Designer PASS.

This acceptance covers this bounded Artifact/task-proof increment only. Stage C, final combined acceptance, commit/integration, release, and push remain pending.

SOFTWARE ENGINEER — Stage B Artifact/task-proof checkpoint committed

The Tester and Designer gates passed, and PM accepted the exact post-fix candidate.

Worktree/branch: /home/alexey/git/dataops-issue-158-stage-b-r1 / issue-158-stage-b-r1
Commit: 0f06b02b50cc46925d2443f1f2a1252f335e2a54 (Implement safe artifact proof access UI, Refs #158)
Scope: Artifact index and Task/Card proof use safe title/type/provider/hostname/file metadata and policy-declared same-origin artifact-ID actions; unavailable artifacts have no fabricated links; assistant-owned artifacts route to assistant review; unbound approval sends expectedRevision; generic relation registration UI is removed; unified search no longer falls back to provider URIs; retained browser assertions cover local fixture Download and Card-panel mediated access.
Fresh Tester PASS: 41/41 focused tests, build, syntax, privacy, and diff checks; prior full gates remain green (frontend 215/215, backend 1,090 passed / 1 skipped, typecheck, build, affected Playwright 4/4 with retries 0).
Designer PASS after the 44px mobile touch-target correction; PM ACCEPTED the exact current tree.

This checkpoint remains off main and unpushed. #158 stays open for Stage C steady-state integration/release, final combined Tester/PM gates, and the required cutover evidence.

Software Engineer — READY FOR TEST (Stage C steady-state candidate)

The complete #158 Stage C candidate is ready for independent Tester verification.

Candidate identity

Worktree: /home/alexey/git/dataops/.tmp/worktrees/issue-158-stage-c-r1
Branch: issue-158-stage-c-r1
Base/HEAD: 85357906d8a1561baa0b870bc8e42810aa4128f0
Tracked diff SHA-256: 5ead2a822d9f757f4538bc2c8e87da4a0a7f1734636f973d6bc6853b90a23f12
Candidate-content SHA-256: 8a8eb587d0d66dc5aacca663ac3b5a0c81819af7ee0d2ce13db698dd6ba8d960
Status-manifest SHA-256: dfef022c12a2c1771190d5053f7289973082ad6b30080aa71f9d78d95af84e6f
Unmerged paths: 0

The preserved staged/unstaged reconstruction remains intentionally uncommitted. No worktree was created or moved; no other worktree was touched.

Delivered behavior

Canonical assistant lifecycle, optimistic concurrency/versioning, and public-response sanitization are enforced across assistant and intake flows.
Artifact access policy and URL safety prevent storage-location leakage while preserving authorized retrieval behavior.
Canonical task/card relationship behavior and evidence rendering are aligned across API and UI.
Assistant review UI supports creation, review, rejection feedback, draft-save recovery, stale/conflict recovery, and artifact navigation.
Rejection feedback is retained as the next prompt's initial value.
A successful create followed by a queue-refresh failure retains the created job and cannot issue a duplicate create POST; recovery navigates to the existing draft.
Current main's newer feedback/recovery behavior is preserved.
The existing portable-export representation was kept schema-consistent with the accepted assistant version and draft-saved lifecycle event. No import/export/restore operation was executed and no new import/export workflow was added.

Changed files (46)

backend/e2e/canonical-capability-behavior.spec.js
backend/e2e/canonical-frontend.spec.js
backend/e2e/canonical-task-workflow-behavior.spec.js
backend/e2e/global-setup.js
backend/e2e/issue-158-stage-b-assistant-review.spec.js
backend/src/artifacts/accessPolicy.ts
backend/src/artifacts/urlSafety.ts
backend/src/assistant/jobLifecycle.ts
backend/src/assistant/publicJob.ts
backend/src/assistant/safety.ts
backend/src/contracts/canonicalValues.ts
backend/src/db/artifacts.ts
backend/src/db/assistantJobs.ts
backend/src/export/portable.ts
backend/src/responsePrivacy.ts
backend/src/routes/artifacts.ts
backend/src/routes/assistantJobs.ts
backend/src/routes/emailDocuments.ts
backend/src/routes/intake.ts
backend/src/taskCardRelationships.ts
backend/src/types.ts
backend/tests/api-artifacts.test.ts
backend/tests/api-assistant-jobs.test.ts
backend/tests/api-email-documents.test.ts
backend/tests/api-intake.test.ts
backend/tests/api-podcast-slice.test.ts
backend/tests/api-tasks.test.ts
backend/tests/api-work-authenticated.test.ts
backend/tests/artifact-access-policy.test.ts
backend/tests/artifact-url-safety.test.ts
backend/tests/assistant-job-lifecycle.test.ts
backend/tests/assistant-job-repository.test.ts
backend/tests/assistant-public-job.test.ts
backend/tests/e2e-global-setup.test.ts
backend/tests/export-portable.test.ts
backend/tests/helpers/publicBoundary.ts
backend/tests/mailing-exports.test.ts
frontend/src/runtime/application.js
frontend/src/styles.css
frontend/src/surfaces/knowledge/search.js
frontend/src/surfaces/operations/artifacts.js
frontend/src/surfaces/operations/assistants-create.js
frontend/src/surfaces/operations/assistants.js
frontend/src/surfaces/work-detail/task-evidence.js
frontend/test/operations-surface.test.mjs
frontend/test/work-detail-surface.test.mjs

Verification

All checks completed successfully in the candidate worktree:

Focused backend Node test run over 15 affected files: 217 passed, 0 failed (34 suites).
node --test frontend/test/operations-surface.test.mjs frontend/test/work-detail-surface.test.mjs frontend/test/frontend-architecture.test.mjs: 68 passed, 0 failed (4 suites).
node --check for frontend/src/runtime/application.js, assistants-create.js, and assistants.js: passed.
npm run test:backend: 1154 passed, 0 failed, 5 skipped (1159 tests, 172 suites).
npm run test:frontend:unit: 293 passed, 0 failed (25 suites).
npm run test:frontend:coverage: 293 passed, 0 failed; statements 76.37%, branches 72.09%, functions 74.17%.
npm run typecheck:backend: passed (all three TypeScript checks).
npm run build:backend: passed; runtime-boundary check passed, 74 canonical frontend assets, dependency inventory zero.
Affected Playwright command:
CI= DATAOPS_E2E_SERVER_PORT=37158 npx playwright test e2e/issue-158-stage-b-assistant-review.spec.js e2e/canonical-capability-behavior.spec.js e2e/canonical-task-workflow-behavior.spec.js --grep 'issue 158 Stage B assistant review|assistants and artifacts provide|Workflows resolve blocked relationships' --retries=0 --reporter=line
Result: 4 passed, 0 failed; includes the Stage B accessibility and screenshot assertions.
make sam-validate sam-build verify-sam-frontend verify-sam-runtime-boundary test-sam-frontend-isolation: passed; SAM build fingerprint 294bc8a4e3cf..., 74 assets at exact parity, packaged frontend isolation 13/13 passed.
Sanitized local storage-shape preflight:
node --import tsx .tmp/issue-158/assistant-storage-shape-preflight.ts
Result: {"status":"canonical","assistantJobRows":1,"artifactRows":1,"readCommands":["ScanCommand","ScanCommand"],"identifiers":"redacted","storageLocations":"not_emitted"}.
Privacy scan:
rg -n 'storageUri|storage_uri|local-dev://' frontend/src backend/dist/frontend .aws-sam/build/BackendFunction/dist/frontend
Result: no matches.
git diff --check and git diff --cached --check: passed.

The preflight used only synthetic local Dynalite rows and read-only application repository calls. No AWS/provider access, production identifiers, provider content, deploy, push, merge, commit, or HUMAN gate was performed.

READY FOR TEST

CHANGES REQUESTED — independent final combined verification of issue #158

Candidate verified against the latest READY FOR TEST handoff: #158 (comment)

Candidate identity and integrity

Worktree: /home/alexey/git/dataops/.tmp/worktrees/issue-158-stage-c-r1 (used in place; no worktree was created or moved)
Branch: issue-158-stage-c-r1
HEAD: 85357906d8a1561baa0b870bc8e42810aa4128f0
Tracked diff fingerprint: 5ead2a822d9f757f4538bc2c8e87da4a0a7f1734636f973d6bc6853b90a23f12 — exact match
Changed-file content fingerprint: 8a8eb587d0d66dc5aacca663ac3b5a0c81819af7ee0d2ce13db698dd6ba8d960 — exact match
Status fingerprint: dfef022c12a2c1771190d5053f7289973082ad6b30080aa71f9d78d95af84e6f — exact match
Changed paths: 46; unmerged paths: 0
git diff --check: pass
git diff --cached --check: pass

Fingerprint commands:

git diff --no-ext-diff --binary HEAD | sha256sum
git diff --name-only -z HEAD | sort -z | xargs -0 sha256sum | sha256sum
git status --porcelain=v1 -z | sha256sum
git diff --name-only HEAD | wc -l
git diff --name-only --diff-filter=U | wc -l
git diff --check
git diff --cached --check
git status --short

I inspected every changed path and every zero-context hunk using:

for f in $(git diff --name-only HEAD); do git diff --numstat HEAD -- "$f"; git diff --unified=0 HEAD -- "$f" | rg '^@@'; done

Independent verification results

Backend:

npm run test:backend

PASS: 1,159 tests in 172 suites; 1,154 passed, 5 skipped, 0 failed.

npm run typecheck:backend
npm run build:backend

PASS: all three TypeScript projects typechecked; build passed. Runtime-boundary verification passed, 74 canonical frontend assets were copied with parity hashes, and the runtime dependency inventory reported zero forbidden entries.

Focused changed backend contract:

NODE_ENV=test FRONTEND_ROOT=../frontend SKIP_AUTH=true CONVERSATIONAL_TELEGRAM_INGRESS_ENABLED=false CONVERSATIONAL_EXECUTION_ENABLED=false CONVERSATIONAL_ENABLED_PLUGINS=none CONVERSATIONAL_TYPEFULLY_EXTERNAL_EXECUTION_ENABLED=false CONVERSATIONAL_TELEGRAM_VOICE_ENABLED=false CONVERSATIONAL_TELEGRAM_PHOTO_ENABLED=false node --import tsx --test --test-force-exit tests/api-artifacts.test.ts tests/api-assistant-jobs.test.ts tests/api-email-documents.test.ts tests/api-intake.test.ts tests/api-podcast-slice.test.ts tests/api-tasks.test.ts tests/api-work-authenticated.test.ts tests/artifact-access-policy.test.ts tests/artifact-url-safety.test.ts tests/assistant-job-lifecycle.test.ts tests/assistant-job-repository.test.ts tests/assistant-public-job.test.ts tests/e2e-global-setup.test.ts tests/export-portable.test.ts tests/mailing-exports.test.ts

PASS: 217 tests in 34 suites; 217 passed, 0 failed, 0 skipped.

Frontend:

npm run test:frontend:unit
npm run test:frontend:coverage

PASS: 293 tests in 25 suites in each run. Coverage: 76.37% statements, 72.09% branches, 74.17% functions.

All changed frontend and E2E JavaScript files also passed node --check.

Behavior-based browser verification, using the real local test server and retries fixed at zero:

CI= DATAOPS_E2E_SERVER_PORT=37158 npx playwright test e2e/issue-158-stage-b-assistant-review.spec.js e2e/canonical-capability-behavior.spec.js e2e/canonical-task-workflow-behavior.spec.js --grep 'issue 158 Stage B assistant review|assistants and artifacts provide|Workflows resolve blocked relationships' --retries=0 --reporter=line

PASS: 4/4 journeys, 0 retries. The journeys exercised draft creation/detail opening, lifecycle mutations, retry and submit-retry persistence/history, artifact access, blocked relationships, authoritative refetch behavior, keyboard flows, overflow checks, and axe serious/critical checks.

Screenshots were inspected at original/native resolution:

.tmp/screenshots/issue-158/stage-b/assistant-approved-desktop-1440x900.png: 1440×900, no error page, clipping, overlap, or horizontal overflow observed.
.tmp/screenshots/issue-158/stage-b/assistant-approved-mobile-390x844.png: 390×844 viewport; 390×2300 full-page PNG, no error page, clipping, overlap, or horizontal overflow observed. This capture also exposes the touch-target failure described below.

Source/SAM parity and isolation:

make sam-validate sam-build verify-sam-frontend verify-sam-runtime-boundary test-sam-frontend-isolation

PASS: template validation/build passed; 74 frontend assets were byte-identical; runtime boundary passed; SAM frontend isolation passed 13/13 tests in 2 suites. No AWS/provider access was performed.

Sanitized local storage-shape preflight:

node --import tsx .tmp/issue-158/assistant-storage-shape-preflight.ts

PASS:

{"status":"canonical","assistantJobRows":1,"artifactRows":1,"readCommands":["ScanCommand","ScanCommand"],"identifiers":"redacted","storageLocations":"not_emitted"}

This used synthetic local Dynalite data and read-only scans.

Privacy scan:

rg -n 'storageUri|storage_uri|local-dev://' frontend/src backend/dist/frontend .aws-sam/build/BackendFunction/dist/frontend

PASS: no matches in source, built frontend, or SAM-built frontend.

Acceptance criteria, in issue order

PASS — one canonical draft v1 is created and its detail opens with recoverable context; create does not submit or run.
PASS — draft-only edits and lifecycle actions enforce expected version and exact source state.
PASS — mutation/event atomicity, one-winner concurrency, sanitized 409 handling, and no partial write are covered and passing.
PASS — retry and submit-retry remain distinct confirmed transitions across reload/history.
PASS — browser actions refetch authoritative Job, Artifact, and event state after success/failure; draft and rejection text recover.
PASS — active operator/admin success and missing/expired/disabled/unsupported/spoofed denial paths are covered without disclosure/write.
PASS — rendered artifact metadata is public-safe and actions use same-origin ID routes.
PASS — provider URI/signed URL fields are excluded recursively; safe ID mirror behavior is covered; privacy scans are clean.
PASS — invalid provider, disallowed transition, unsafe location, not found, denied access, and provider/server failure produce distinct sanitized retryable errors.
PASS — operator UI cannot invoke runner routes; no conversational/model lifecycle or artifact-access capability was introduced.
FAIL — accessibility scans, keyboard journeys, focus behavior, headings, live status, and overflow checks pass, but the changed assistant artifact Download action is explicitly min-height: 32px at frontend/src/styles.css:8682-8690. The mobile 44px override at frontend/src/styles.css:9500-9510 includes assistant buttons but omits .assistant-artifact-actions a. The native mobile screenshot shows this undersized action. This conflicts with the 44×44 mobile target baseline already established during this issue's Designer lifecycle review.
FAIL — the candidate changes backend/src/export/portable.ts and backend/tests/export-portable.test.ts to alter portable-export representation/validation. AC 12 explicitly prohibits implementation changes to import/export/restore code, and the groomed out-of-scope section separately prohibits any import/export/restore change or test. Passing tests do not make this in-scope.
PASS — test data/screenshots are synthetic and public-safe; no provider or production identifiers were observed.

Required fixes

Add the assistant-detail artifact action link to the mobile 44×44 minimum-target rule (and add a focused regression assertion if appropriate), then rerun the zero-retry mobile journey, axe/overflow checks, and inspect the regenerated native mobile screenshot.
Remove the issue-158 changes from backend/src/export/portable.ts and backend/tests/export-portable.test.ts. If portable-export schema work is genuinely required, groom and sequence it as a separate issue/dependency rather than expanding Make assistant output review safe and lifecycle-complete #158 beyond its explicit boundary.
Hand off a new immutable candidate with updated tracked/content/status fingerprints and rerun the final combined contract.

No files were edited, no commit/push/deploy was made, no worktree was created or moved, no AWS/provider was accessed, and no HUMAN gate was performed.

Software Engineer — READY FOR TEST (Stage C repaired candidate)

Repaired only the two findings from the independent Tester CHANGES REQUESTED comment: #158 (comment)

Candidate identity

Worktree: /home/alexey/git/dataops/.tmp/worktrees/issue-158-stage-c-r1
Branch: issue-158-stage-c-r1
Base/HEAD: 85357906d8a1561baa0b870bc8e42810aa4128f0
Tracked diff SHA-256: d7c7d3ca7372a6ec46cce17e909fcc28b997b3b39cba9790fd0a0b84f77b3adb
Candidate-content SHA-256: 3130736eb0c562c06f95a491352ef70f0c74a53e79e3780966d233c56ebeda58
Status-manifest SHA-256: 93e237804742c579bf95129f0e3bb530efb32672c123b4ddebb585c98a12b777
Changed paths: 44
Unmerged paths: 0

The candidate remains intentionally uncommitted. No worktree was created, moved, or touched outside the assigned project-local worktree.

Required repairs

Mobile artifact action target
- Added body[data-workspace-view="tasks"] .assistant-artifact-actions a to the existing 768px mobile 44×44 minimum-target rule in frontend/src/styles.css.
- Added real-browser regression assertions for computed min-width: 44px and min-height: 44px at the 390×844 viewport in backend/e2e/issue-158-stage-b-assistant-review.spec.js.
- The assertion runs before the existing horizontal-overflow and serious/critical axe checks.
Portable export boundary
- Restored backend/src/export/portable.ts and backend/tests/export-portable.test.ts byte-for-byte to this worktree HEAD.
- Both paths are absent from git diff HEAD; the repaired candidate makes no import/export/restore code or test change.
- No import, export, restore, migration, or production-data suite/operation was run.

All other candidate work was preserved.

Verification

node --check backend/e2e/issue-158-stage-b-assistant-review.spec.js: PASS.
Focused frontend contract (operations-surface, work-detail-surface, frontend-architecture, surface-feedback): 78 passed, 0 failed.
npm run typecheck:backend: PASS across source, tests, and scripts.
Complete permitted backend contract (all normal backend tests and retained script tests, excluding only the three explicitly forbidden portable/export suites): PASS, exit 0. This was repeated successfully; no forbidden suite ran.
npm run test:frontend:unit: PASS, 293 tests.
npm run test:frontend:coverage: PASS, 293 tests; statements 76.37%, branches 72.09%, functions 74.17%, lines 76.37%.
npm run build:backend: PASS; runtime boundary passed, 74 canonical frontend assets copied, dependency inventory zero.
Focused repaired mobile Playwright journey with --retries=0: 1/1 passed. Computed 44×44 target, zero horizontal overflow, and zero critical/serious axe violations all passed.
Final combined affected Playwright run with --retries=0: 4/4 passed, 0 retries.
Regenerated native screenshot: .tmp/screenshots/issue-158/stage-b/assistant-approved-mobile-390x844.png, 390×2311, SHA-256 4044e0c3adda438cf88ee03beaa908f1f6d3af1d7ee65963caae4ee89f9463e3. Inspected at original resolution: enlarged Download action is visible; no error page, clipping, overlap, or horizontal overflow observed.
make sam-validate sam-build verify-sam-frontend verify-sam-runtime-boundary test-sam-frontend-isolation: PASS; fingerprint 8d722cd86678..., 74 byte-identical assets, runtime boundary passed, isolation 13/13.
Sanitized local shape preflight: PASS with status=canonical, one synthetic Assistant Job row, one synthetic Artifact row, read-only scans, identifiers redacted, storage locations not emitted.
Privacy scan over source, built frontend, and SAM frontend: no storageUri, storage_uri, or local-dev:// matches.
git diff --check, git diff --cached --check, portable-path equality check, and unmerged-path check: PASS.

No commit, merge, push, deploy, provider/AWS access, production data, or HUMAN gate was performed.

READY FOR TEST

TEST PASS — independent re-test of repaired issue #158 candidate

Repaired handoff: #158 (comment)
Prior CHANGES REQUESTED: #158 (comment)

Candidate identity and repair integrity

Existing worktree used in place: /home/alexey/git/dataops/.tmp/worktrees/issue-158-stage-c-r1
Branch: issue-158-stage-c-r1
HEAD: 85357906d8a1561baa0b870bc8e42810aa4128f0
Tracked diff: d7c7d3ca7372a6ec46cce17e909fcc28b997b3b39cba9790fd0a0b84f77b3adb — exact match
Candidate content: 3130736eb0c562c06f95a491352ef70f0c74a53e79e3780966d233c56ebeda58 — exact match
Status manifest: 93e237804742c579bf95129f0e3bb530efb32672c123b4ddebb585c98a12b777 — exact match
Changed paths: 44; unmerged paths: 0
git diff --check and git diff --cached --check: pass

Exact identity commands:

git rev-parse HEAD
git branch --show-current
git diff --no-ext-diff --binary HEAD | sha256sum
git diff --name-only -z HEAD | sort -z | xargs -0 sha256sum | sha256sum
git status --porcelain=v1 -z | sha256sum
git diff --name-only HEAD | wc -l
git diff --name-only --diff-filter=U | wc -l
git diff --check
git diff --cached --check

The two prohibited portable-export paths are absent from the candidate diff and byte-identical to HEAD:

git diff HEAD -- backend/src/export/portable.ts backend/tests/export-portable.test.ts
cmp -s backend/src/export/portable.ts <(git show HEAD:backend/src/export/portable.ts)
cmp -s backend/tests/export-portable.test.ts <(git show HEAD:backend/tests/export-portable.test.ts)

Results:

Diff lines: 0
backend/src/export/portable.ts: working and HEAD SHA-256 both 5e2c60676ab3be356e4e285dc14089b5dd134f8b88268a8f52855bdd2aa9e96b
backend/tests/export-portable.test.ts: working and HEAD SHA-256 both 221e6bb0662aa7ac7f6fbe8abb2ffc0c0fe96442ccbe9c083dabd09f00b2c303
No import/export/restore/migration/production path is present in the 44-path candidate diff.

Repaired mobile journey

The repair adds .assistant-artifact-actions a to the mobile min-width: 44px; min-height: 44px rule and adds computed-style assertions before the existing overflow and axe assertions.

CI= DATAOPS_E2E_SERVER_PORT=37159 npx playwright test e2e/issue-158-stage-b-assistant-review.spec.js --grep 'saves drafts, separates submit and dry-run, mediates output access, and confirms approval' --retries=0 --reporter=line

PASS: 1/1, zero retries, real owned local test server. At the 390×844 viewport the Download action computed to 44×44; horizontal overflow was zero; axe found zero serious/critical violations.

The journey regenerated .tmp/screenshots/issue-158/stage-b/assistant-approved-mobile-390x844.png. The final combined run regenerated it once more with fresh synthetic IDs/timestamps; I inspected that latest image at original resolution:

PNG: 390×2311 from the 390×844 viewport
SHA-256: a7622596cba86d3df539be949859431d9cd8799f7ef9e0a67bb0cef5f4e792aa
The enlarged Download action is clearly visible; no error page, clipping, overlap, or horizontal overflow is present.

Regression contract

Affected backend contract, explicitly excluding all portable/export suites:

NODE_ENV=test FRONTEND_ROOT=../frontend SKIP_AUTH=true CONVERSATIONAL_TELEGRAM_INGRESS_ENABLED=false CONVERSATIONAL_EXECUTION_ENABLED=false CONVERSATIONAL_ENABLED_PLUGINS=none CONVERSATIONAL_TYPEFULLY_EXTERNAL_EXECUTION_ENABLED=false CONVERSATIONAL_TELEGRAM_VOICE_ENABLED=false CONVERSATIONAL_TELEGRAM_PHOTO_ENABLED=false node --import tsx --test --test-force-exit tests/api-artifacts.test.ts tests/api-assistant-jobs.test.ts tests/api-email-documents.test.ts tests/api-intake.test.ts tests/api-podcast-slice.test.ts tests/api-tasks.test.ts tests/api-work-authenticated.test.ts tests/artifact-access-policy.test.ts tests/artifact-url-safety.test.ts tests/assistant-job-lifecycle.test.ts tests/assistant-job-repository.test.ts tests/assistant-public-job.test.ts tests/e2e-global-setup.test.ts

PASS: 189 tests, 29 suites, 189 passed, 0 failed/skipped.

npm run typecheck:backend
npm run test:frontend:unit
npm run build:backend

PASS:

Backend source, tests, and scripts typecheck.
Frontend unit: 293 tests, 25 suites, 293 passed, 0 failed.
Backend build/runtime boundary passed; 74 canonical frontend assets copied with parity hashes; dependency inventory was zero.

Final combined real-browser contract:

CI= DATAOPS_E2E_SERVER_PORT=37160 npx playwright test e2e/issue-158-stage-b-assistant-review.spec.js e2e/canonical-capability-behavior.spec.js e2e/canonical-task-workflow-behavior.spec.js --grep 'issue 158 Stage B assistant review|assistants and artifacts provide|Workflows resolve blocked relationships' --retries=0 --reporter=line

PASS: 4/4 journeys, zero retries. This reconfirmed creation/detail, lifecycle/version transitions, retry versus submit-retry, authoritative refresh/history, artifact mediation, relationship behavior, keyboard behavior, 44×44 mobile target, overflow, and serious/critical axe checks.

Source/SAM parity and isolation:

make sam-validate sam-build verify-sam-frontend verify-sam-runtime-boundary test-sam-frontend-isolation

PASS: basic SAM validation/build, shared fingerprint 8d722cd86678..., 74 byte-identical frontend assets, runtime boundary, and 13/13 isolation tests in 2 suites. Empty local AWS config/credentials files prevented provider access; no deploy was performed.

Sanitized synthetic storage-shape preflight:

node --import tsx .tmp/issue-158/assistant-storage-shape-preflight.ts

PASS:

{"status":"canonical","assistantJobRows":1,"artifactRows":1,"readCommands":["ScanCommand","ScanCommand"],"identifiers":"redacted","storageLocations":"not_emitted"}

Privacy and syntax:

node --check backend/e2e/issue-158-stage-b-assistant-review.spec.js
rg -n 'storageUri|storage_uri|local-dev://' frontend/src backend/dist/frontend .aws-sam/build/BackendFunction/dist/frontend

PASS: syntax clean; privacy scan produced no matches.

Acceptance criteria in issue order

PASS — exactly one canonical draft v1 is created and opened without submit/run.
PASS — draft edits and all operator lifecycle actions enforce expected version and exact source state.
PASS — job/event/artifact/task/card writes are atomic; stale/concurrent attempts produce one winner and sanitized 409 with no partial write.
PASS — Retry and Submit retry remain distinct confirmed transitions across reload and history.
PASS — success and failure paths refetch authoritative Job, Artifact, and events; draft/rejection text remains recoverable.
PASS — valid operator/admin access and all missing, expired, disabled, unsupported, and spoofed denial cases remain covered without disclosure/write.
PASS — artifact metadata is public-safe and browser actions use same-origin ID routes.
PASS — provider URI/signed URL fields are excluded recursively; safe-ID mirror behavior and no-private-URL proof remain green.
PASS — invalid provider, disallowed transition, unsafe location, not found, denied access, and provider/server failures remain distinct, sanitized, and retryable.
PASS — operator surfaces cannot invoke runner routes; no conversational/model lifecycle or access capability is introduced.
PASS — keyboard/focus/live-region/headings checks pass; axe has zero serious/critical findings; mobile Download now computes to 44×44; native screenshot and overflow inspection pass.
PASS — no deploy workflow, SAM/IAM/CloudFormation/table/provider/import/export/restore implementation change exists. The two previously offending portable-export paths are byte-identical to HEAD and absent from the diff.
PASS — tests and screenshots use synthetic public-safe data; no provider or production identifiers were observed.

All 13 acceptance criteria pass. No source file was edited, no commit/push/deploy was made, no provider/AWS was accessed, no worktree was created or moved, and no HUMAN gate was performed.

ACCEPTED — final Stage C user/operator acceptance for issue #158

I accept the repaired steady-state candidate after reviewing the full issue lifecycle, the prior CHANGES REQUESTED verdict, the repaired READY FOR TEST handoff, and the final independent TEST PASS.

Candidate identity

Worktree: /home/alexey/git/dataops/.tmp/worktrees/issue-158-stage-c-r1 (used in place)
Branch: issue-158-stage-c-r1
HEAD: 85357906d8a1561baa0b870bc8e42810aa4128f0
Tracked diff: d7c7d3ca7372a6ec46cce17e909fcc28b997b3b39cba9790fd0a0b84f77b3adb — exact repaired handoff/Test PASS match
Candidate content: 3130736eb0c562c06f95a491352ef70f0c74a53e79e3780966d233c56ebeda58 — exact match
Status manifest: 93e237804742c579bf95129f0e3bb530efb32672c123b4ddebb585c98a12b777 — exact match
Changed paths: 44; unmerged paths: 0; staged and unstaged diff checks pass

Product acceptance

All 13 acceptance criteria are satisfied from the operator perspective:

Creation persists one canonical version-1 draft, opens its canonical detail route, retains Task/Card context, and does not submit or run. The post-create refresh failure path retains the created ID and cannot issue a duplicate create.
Draft editing and every lifecycle action use the authoritative expected version and exact source state; controls disappear or disable when invalid.
Job/event/Artifact/Task/Card writes are conditionally atomic. Concurrent/stale callers have one winner; sanitized conflicts preserve authoritative state and produce no duplicate or partial effect.
Retry and Submit retry are separate, confirmed steps and remain distinct across refreshed state/history.
Success and failure paths refetch authoritative queue, detail, Artifact, and event state. Draft fields and rejection text remain recoverable, with explicit reload/review/discard routes after failures.
Active operator/admin paths work; missing, bogus, expired, disabled, deleted, unsupported, header-spoofed, and body-spoofed identities fail with 401/403 and no disclosure/write.
Assistant, Artifact, Task, and Card surfaces expose safe metadata and only policy-declared same-origin artifact-ID actions; assistant-owned proof routes back to canonical assistant review.
Public serializers, response defense, DOM/privacy scans, and safe-ID projection evidence exclude provider/storage/signed URIs at every nesting depth and never fabricate Task/Card URL proof.
Invalid provider/location/content, not-found, denial, conflict, and server/provider failures remain distinct, sanitized, honest, and retryable without false success.
Generic runner transition/event/attachment routes are absent from operator surfaces, and no conversational/model lifecycle or artifact-access capability was introduced.
Consequential actions are confirmed; keyboard/focus restoration, headings, live feedback, stale-route protection, and overflow evidence pass. The repaired mobile Download action computes to 44×44. I inspected the current native 390×2311 screenshot (a7622596cba86d3df539be949859431d9cd8799f7ef9e0a67bb0cef5f4e792aa): the control is visibly enlarged and there is no error page, clipping, overlap, or horizontal overflow. Axe reported zero serious/critical findings.
The candidate changes no deployment workflow, SAM/IAM/CloudFormation/table/provider configuration, assistant engine/prompt/tool, or portable import/export/restore implementation/test. backend/src/export/portable.ts and backend/tests/export-portable.test.ts are absent from the diff and byte-identical to HEAD.
Test data and screenshots are synthetic and public-safe; the shape preflight is local/read-only with identifiers redacted and storage locations omitted. No production/provider identifier or execution is present.

Independent final evidence is complete and proportional: 189 focused backend tests passed; backend typecheck/build/runtime boundary passed; 293 frontend unit tests passed; affected real-browser journeys passed 4/4 with retries disabled; SAM/frontend parity and isolation passed with 74 byte-identical assets and 13/13 isolation tests; the sanitized shape preflight and privacy scan passed.

No file was edited during this acceptance review. No commit, merge, push, deployment, provider/AWS access, issue close, or HUMAN gate was performed.

Next gate

Software Engineer: create the explicit-path commit from this exact accepted candidate with Closes #158. Then the orchestrator may merge locally to clean main, push normally, and hand off to On-Call for source/deployed CI/CD evidence.

Software Engineer — accepted candidate committed

Committed the exact final TEST PASS / PM ACCEPTED #158 candidate in the existing project-local worktree.

Accepted identity proved before staging

Branch: issue-158-stage-c-r1
Accepted base/HEAD before commit: 85357906d8a1561baa0b870bc8e42810aa4128f0
Tracked diff SHA-256: d7c7d3ca7372a6ec46cce17e909fcc28b997b3b39cba9790fd0a0b84f77b3adb
Candidate-content SHA-256: 3130736eb0c562c06f95a491352ef70f0c74a53e79e3780966d233c56ebeda58
Status-manifest SHA-256: 93e237804742c579bf95129f0e3bb530efb32672c123b4ddebb585c98a12b777
Changed paths: 44; unmerged paths: 0

These exactly matched the final TEST PASS and PM ACCEPTED identities.

backend/src/export/portable.ts and backend/tests/export-portable.test.ts were confirmed unchanged from the accepted base and absent from both the candidate and staged diffs.

Explicit staging and commit

Staged only the 44 accepted paths by explicit pathname; git add -A was not used.
Staged tracked diff/content fingerprints remained exactly d7c7d3... / 313073....
No generated or ignored artifact was staged.
Commit: 8839fcfb39a3553a673d395a7b3746e2c92218cd
Subject: Complete safe assistant output review lifecycle
Body: Closes #158
Git tree: 22d3e156fd4333f292431b2b2e3813b8a61da1f5
Recursive tree-list SHA-256: ba34ccd37e65da22da53cd8a68914e14919fae75bf2e9b86e1d2f1f45f7a2543
Final tracked worktree/index status: clean

No merge, push, deployment, provider/AWS access, manual issue close, or HUMAN gate was performed.

Next owner: orchestrator for clean local merge to main, normal push, then On-Call CI/CD verification.

PM TRACKER RECONCILIATION — final Tester/PM acceptance and exact commit 8839fcfb39a3553a673d395a7b3746e2c92218cd are now reflected. The commit remains off main and unpushed; merge, push, deployment, and On-Call remain pending behind the coordinated #217 release/identity gate. No shipped or HUMAN-completion claim is made.

Closing during the Oct-5 branch cleanup: the Aug-30 implementation (commit SHAs recorded earlier in this thread) was discarded rather than merged — it predates the Oct-3 frontend redesign and no longer applies. Re-groom a fresh issue if this work is still wanted on the current frontend.

Make assistant output review safe and lifecycle-complete #158

Description

Make assistant output review safe and lifecycle-complete

Product outcome

Current defects confirmed in source

Canonical server contract

Persisted Assistant Job

State and action table

Artifact privacy and access

Canonical Task/Card integration

Acceptance criteria

Implementation stages

Stage A1 — backend domain, persistence, privacy; eligible locally now

Stage A2 — authenticated routes and Task/Card composition

Stage B — canonical UI and independent browser behavior

Stage C — steady-state integration and release

Behavior scenarios

Concurrent lifecycle winner

Retry remains visible

Mediated provider access

Identity boundary

Task/Card approval composition

Responsive recovery

Verification contract

Lifecycle gates

Out of scope

Activity

alexeygrigorev commented on Aug 11, 2026

PM GROOMED — dependency blocked

alexeygrigorev commented on Aug 13, 2026

alexeygrigorev commented on Aug 25, 2026

alexeygrigorev commented on Aug 25, 2026

SOFTWARE ENGINEER — #158 Stage A1 candidate (repair from clean baseline)

What changed and why

Changed files

Commands, exit codes, counts

Security and concurrency notes

Remaining stage boundaries (unchanged)

24 remaining items

alexeygrigorev commented on Aug 27, 2026

TESTER — PASS (bounded Stage B Artifact/task-proof increment)

alexeygrigorev commented on Aug 27, 2026

DESIGNER — CHANGES REQUESTED (Stage B Artifact/Task/Card proof slice)

alexeygrigorev commented on Aug 27, 2026

DESIGNER — PASS (Stage B Artifact/Task/Card proof follow-up)

alexeygrigorev commented on Aug 27, 2026

TESTER — PASS (fresh bounded Stage B Artifact/task-proof recheck)

alexeygrigorev commented on Aug 27, 2026

PM ACCEPTED — bounded Stage B Artifact/task-proof increment

alexeygrigorev commented on Aug 27, 2026

SOFTWARE ENGINEER — Stage B Artifact/task-proof checkpoint committed

alexeygrigorev commented on Aug 29, 2026

Software Engineer — READY FOR TEST (Stage C steady-state candidate)

Candidate identity

Delivered behavior

Changed files (46)

Verification

alexeygrigorev commented on Aug 29, 2026

Candidate identity and integrity

Independent verification results

Acceptance criteria, in issue order

Required fixes

alexeygrigorev commented on Aug 29, 2026

Software Engineer — READY FOR TEST (Stage C repaired candidate)

Candidate identity

Required repairs

Verification

alexeygrigorev commented on Aug 29, 2026

Candidate identity and repair integrity

Repaired mobile journey

Regression contract

Acceptance criteria in issue order

alexeygrigorev commented on Aug 29, 2026

Candidate identity

Product acceptance

Next gate

alexeygrigorev commented on Aug 29, 2026

Software Engineer — accepted candidate committed

Accepted identity proved before staging

Explicit staging and commit