Repository navigation
Ask for confirmation before ignoring the updates of several packages - #5556
Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit intoOct 22, 2026
Merged
Conversation
Every row of the Updates page is checked when it opens, so one click on Ignore selected packages ignored every update, for all versions, and the page then showed its empty state. When more than one package is checked, the button now lists them and asks for confirmation first, with the same dialog as the uninstall confirmation. Ignoring a single package is unchanged. The Installed page shares the same button and the same check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Maxime Landry (mlandry-devolutions)
requested review from
Gabriel Dufresne (GabrielDuf)
and
a balanced review from Copilot
October 21, 2026 15:46
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused confirmation changes preserve existing behavior, and no blocking issues were identified.
No open issues 🎉
What changed in this PR
Adds confirmation before ignoring updates for multiple packages, preventing accidental bulk changes while preserving single-package behavior.
Changes:
- Gates bulk ignore actions on the Updates and Installed pages.
- Reuses the uninstall confirmation layout without changing uninstall behavior.
- Adds the English confirmation string.
| File | Description |
|---|---|
| src/UniGetUI.Avalonia/Views/SoftwarePages/SoftwareUpdatesPage.cs | Confirms before ignoring selected updates. |
| src/UniGetUI.Avalonia/Views/SoftwarePages/InstalledPackagesPage.cs | Adds the same bulk-ignore confirmation. |
| src/UniGetUI.Avalonia/Infrastructure/UninstallConfirmationDialog.cs | Shares dialog layout and adds ignore-confirmation logic. |
| src/Languages/lang_en.json | Adds the bulk-ignore confirmation text. |
Review effort: Balanced
Gabriel Dufresne (GabrielDuf)
approved these changes
Oct 22, 2026
Gabriel Dufresne (GabrielDuf)
deleted the
fix/ignore-selected-confirmation
branch
October 22, 2026 12:19
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Software Updates page opens with every row checked, so one click on Ignore selected packages ignores the updates of every package, for all versions, with no confirmation. The page then shows its empty state. Undoing it means removing the packages one by one in Manage ignored updates, or resetting the whole list. Uninstalling several packages already asks for confirmation (#5533).
PackageListConfirmationDialog; the uninstall confirmation itself is unchanged.One new string, added to
lang_en.jsononly, for the community to translate as usual. Build,dotnet format whitespaceandstyle, and the translation validation scripts pass. Rendered headless on macOS, light and dark, on the Software Updates page with 40 checked updates: the before/after captures are attached to the Jira ticket.Relates to UNI-40
🤖 Generated with Claude Code