Skip to content

Ask for confirmation before ignoring the updates of several packages - #5556

Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit into
mainfrom
fix/ignore-selected-confirmation
Oct 22, 2026
Merged

Gabriel Dufresne (GabrielDuf) merged 1 commit into
mainfrom
fix/ignore-selected-confirmation

Conversation

@mlandry-devolutions

@mlandry-devolutions Maxime Landry (mlandry-devolutions) commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor
  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • Have you confirmed that this issue is caused by UniGetUI itself, and not by the package manager or the package involved?

The Software Updates page opens with every row checked, so one click on Ignore selected packages ignores the updates of every package, for all versions, with no confirmation. The page then shows its empty state. Undoing it means removing the packages one by one in Manage ignored updates, or resetting the whole list. Uninstalling several packages already asks for confirmation (#5533).

  • Confirmation: when more than one package is checked, the button opens the same dialog as the uninstall confirmation: "Are you sure?", "Do you really want to ignore updates for the following {0} packages?", the list of packages, Yes / No. Nothing is ignored until Yes is clicked.
  • With a single package checked, the behaviour is unchanged.
  • The Installed Packages page has the same button and gets the same check.
  • The body of the uninstall dialog becomes a shared PackageListConfirmationDialog; the uninstall confirmation itself is unchanged.

One new string, added to lang_en.json only, for the community to translate as usual. Build, dotnet format whitespace and style, and the translation validation scripts pass. Rendered headless on macOS, light and dark, on the Software Updates page with 40 checked updates: the before/after captures are attached to the Jira ticket.


Relates to UNI-40

🤖 Generated with Claude Code

Every row of the Updates page is checked when it opens, so one click on
Ignore selected packages ignored every update, for all versions, and the
page then showed its empty state. When more than one package is checked,
the button now lists them and asks for confirmation first, with the same
dialog as the uninstall confirmation. Ignoring a single package is
unchanged. The Installed page shares the same button and the same check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused confirmation changes preserve existing behavior, and no blocking issues were identified.

No open issues 🎉

What changed in this PR

Adds confirmation before ignoring updates for multiple packages, preventing accidental bulk changes while preserving single-package behavior.

Changes:

  • Gates bulk ignore actions on the Updates and Installed pages.
  • Reuses the uninstall confirmation layout without changing uninstall behavior.
  • Adds the English confirmation string.
File Description
src/​UniGetUI.Avalonia/​Views/​SoftwarePages/​SoftwareUpdatesPage.cs Confirms before ignoring selected updates.
src/​UniGetUI.Avalonia/​Views/​SoftwarePages/​InstalledPackagesPage.cs Adds the same bulk-ignore confirmation.
src/​UniGetUI.Avalonia/​Infrastructure/​UninstallConfirmationDialog.cs Shares dialog layout and adds ignore-confirmation logic.
src/​Languages/​lang_en.json Adds the bulk-ignore confirmation text.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants