Skip to content

Count failed operations in the operations panel header - #5567

Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit into
mainfrom
fix/operations-header-failures
Oct 22, 2026
Merged

Gabriel Dufresne (GabrielDuf) merged 1 commit into
mainfrom
fix/operations-header-failures

Conversation

@mlandry-devolutions

@mlandry-devolutions Maxime Landry (mlandry-devolutions) commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor
  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • Have you confirmed that this issue is caused by UniGetUI itself, and not by the package manager or the package involved?

The header of the operations panel counts a failed operation among the completed ones: with one operation running, one failed and one succeeded, it reads "2 of 3 operations completed". When the panel is collapsed, this line is the only text left, next to a small red dot.

  • Failures named: when the batch contains at least one failed operation, the header reads "{0} of {1} succeeded, {2} failed" ("1 of 3 succeeded, 1 failed"), with the panel open or collapsed.
  • Without a failure, the header is unchanged. Canceled operations are not named: without a failure they count as completed, as before; with a failure they are in neither number, as in the summary toast.

MainWindowViewModel.cs only. No new string: "{0} of {1} succeeded, {2} failed" already exists and is translated, since the summary toast uses it. Build and dotnet format whitespace and style pass. Rendered headless on macOS, light and dark, with three seeded operations, panel open and collapsed: the before/after captures are attached to the Jira ticket.


Relates to UNI-42

🤖 Generated with Claude Code

The header said "3 of 3 operations completed" when some of them failed.
With the panel collapsed it is the only text left, next to a small red dot.
When the batch has failures, the header now uses the existing
"{0} of {1} succeeded, {2} failed" string, already used by the summary toast.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused change matches the requested counting behavior, with no blocking issues identified.

No open issues 🎉

What changed in this PR

Updates the operations panel header to explicitly report failures, including when the panel is collapsed.

Changes:

  • Shows succeeded and failed counts when any operation fails.
  • Preserves existing completion text when there are no failures.
  • Reuses an existing translated string.
File Description
src/​UniGetUI.Avalonia/​ViewModels/​MainWindowViewModel.cs Adds failure-aware operation counts to the panel header.

Review effort: Balanced

@GabrielDuf
Gabriel Dufresne (GabrielDuf) merged commit 5a07293 into main Oct 22, 2026
6 checks passed
@GabrielDuf
Gabriel Dufresne (GabrielDuf) deleted the fix/operations-header-failures branch October 22, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants