Repository navigation
Count failed operations in the operations panel header - #5567
Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit intoOct 22, 2026
Merged
Conversation
The header said "3 of 3 operations completed" when some of them failed.
With the panel collapsed it is the only text left, next to a small red dot.
When the batch has failures, the header now uses the existing
"{0} of {1} succeeded, {2} failed" string, already used by the summary toast.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change matches the requested counting behavior, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Updates the operations panel header to explicitly report failures, including when the panel is collapsed.
Changes:
- Shows succeeded and failed counts when any operation fails.
- Preserves existing completion text when there are no failures.
- Reuses an existing translated string.
| File | Description |
|---|---|
| src/UniGetUI.Avalonia/ViewModels/MainWindowViewModel.cs | Adds failure-aware operation counts to the panel header. |
Review effort: Balanced
Maxime Landry (mlandry-devolutions)
requested a review
from Gabriel Dufresne (GabrielDuf)
October 21, 2026 18:36
Gabriel Dufresne (GabrielDuf)
approved these changes
Oct 22, 2026
Gabriel Dufresne (GabrielDuf)
deleted the
fix/operations-header-failures
branch
October 22, 2026 12:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header of the operations panel counts a failed operation among the completed ones: with one operation running, one failed and one succeeded, it reads "2 of 3 operations completed". When the panel is collapsed, this line is the only text left, next to a small red dot.
MainWindowViewModel.csonly. No new string: "{0} of {1} succeeded, {2} failed" already exists and is translated, since the summary toast uses it. Build anddotnet format whitespaceandstylepass. Rendered headless on macOS, light and dark, with three seeded operations, panel open and collapsed: the before/after captures are attached to the Jira ticket.Relates to UNI-42
🤖 Generated with Claude Code