[Allan Zhang (allan2)]

No description provided.

[Allan Zhang (allan2)]

Ready for review. This PR fixes easy and non-ambiguous lints.

Remaining unfixed lints include:

• unused_crate_dependencies
• unreachable_pub - most warnings are in Agent; I assume more modules will be exported in the future
• unused_qualifications - I did not replace std::mem::size_of/mem::size_of with size_of
• clippy::as_underscore

More PRs to follow for the remaining ones.

[Benoît Cortier (CBenoit)]

Thank you!

* unused_crate_dependencies

If you want to address this one, let me know beforehand so we can discuss on how it should be approached.

* unreachable_pub - most warnings are in Agent; I assume more modules will be exported in the future

Actually, it’s probably a sign that the pub keyword should be removed, or pub(crate) should be used.
In some cases such a sealed traits, we actually want to silent this warning though.

* unused_qualifications - I did not replace `std::mem::size_of`/`mem::size_of` with `size_of`

For that one, in order of preference, I recommend: mem::size_of > std::mem::size_of > size_of

• mem::size_of is the best readability and clarity overall
• std::mem::size_of when the function is used only once
• size_of when it is used a lot for doing arithmetic, I would then recommend a local import at the function level where it is used abundantly

That being said, those are just guidelines, and anything is acceptable :)

[Benoît Cortier (CBenoit)]

I removed the duplicated commits from master:

Maybe something wrong happened when you tried to rebase on top of master or merge master into your branch?

Otherwise, everything is looking good to me!

[Benoît Cortier (CBenoit)]

I reworded a bit your individual commits so we can merge rebase them without squashing everything. It mostly comes down to the fact that changing code without modifying the semantic is a "refactor", changes to doc only (including comments) should be "docs" and I added the scope when it made sense. It’s mostly relevant for features and bug fixes that are actually perceived by the end user as we have scripts looking for these commits when generating the changelog to avoid forgetting important changes. This is based on the conventional commit specification. All that said, I should document the details and how we are using it in the repository directly :)