Repository navigation
Conversation
OctoBot requires Python 3.13, so the private-thread clear branch never ran. Websocket close now always waits for the pool, and the helper test no longer sleeps forever. Co-authored-by: herklos.dev <herklos.dev@protonmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for sending your pull request.
But first, have you included unit tests, and is your code PEP8 conformant? More details
Summary
Always wait for thread pool shutdown now that Python 3.13 is required.
Changelog
stop_thread_pool_executor_non_gracefully.shutdown(wait=True)only.What's new?
stop_thread_pool_executor_non_gracefullystill had a branch that cleared privateThreadPoolExecutorthread tables. That branch ran only before Python 3.9. On 3.13 it never ran: both the helper and websocketclose_socketsalready calledshutdown(wait=True).The helper keeps its name. The docstring now says it waits. Websocket close no longer checks
sys.version_info.packages/commons/tests/thread_util.pywas not collected by pytest. It submitted workers that sleep forever and then called the helper, which would hang on 3.13. It is nowtests/test_thread_util.pyand checks that a short task finishes and a later submit raisesRuntimeError.packages/commonspytest:tests/test_thread_util.pypassed (1 test). Extended linter againstorigin/dev: 0 violations.