Skip to content

Clean up for release - #2376

Merged
galabovaa merged 6 commits into
latestfrom
warning-and-iterations
Jun 2, 2025
Merged

galabovaa merged 6 commits into
latestfrom
warning-and-iterations

Conversation

@galabovaa

Copy link
Copy Markdown
Contributor

GPU objective values recently changed due to tolerances update

  • Cleaned up in CMake so ctest passes with GPU ON

Build directory for Windows MSVC now Release/bin replacing bin/Release

  • fixes new bug I got with TARGET_FILE in CMake
  • consistent with OR-Tools, a patch there should not be required any more

Clean up of HConfig.h and addition to HCheckConfig.h

  • one less patch in vcpkg
  • HCheckConfig.h should be added to Catch2 test files when files are being read from the check/

Fixes a warning by adding default: to a switch

@galabovaa
galabovaa requested a review from jajhall May 29, 2025 14:48
@codecov

codecov Bot commented May 29, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.11%. Comparing base (654b38e) to head (aa1923b).
Report is 15 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2376      +/-   ##
==========================================
+ Coverage   79.07%   79.11%   +0.03%     
==========================================
  Files         346      346              
  Lines       84912    84918       +6     
==========================================
+ Hits        67147    67182      +35     
+ Misses      17765    17736      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajhall jajhall left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. I must have been looking at @BenChampion 's PR when I said this was already in docs-tolerances

@galabovaa
galabovaa merged commit bc41ab5 into latest Jun 2, 2025
@galabovaa
galabovaa deleted the warning-and-iterations branch June 23, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants