Skip to content

Avoid conflict with amd and rcm api - #2832

Merged
jajhall merged 1 commit into
latestfrom
amd-names
Feb 9, 2026
Merged

jajhall merged 1 commit into
latestfrom
amd-names

Conversation

@filikat

@filikat filikat commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

Same as #2825, but for amd and rcm orderings.

@filikat
filikat requested a review from jajhall February 9, 2026 13:14
@codecov

codecov Bot commented Feb 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.25%. Comparing base (998b217) to head (06f31a5).
⚠️ Report is 9 commits behind head on latest.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #2832   +/-   ##
=======================================
  Coverage   80.24%   80.25%           
=======================================
  Files         348      348           
  Lines       86193    86193           
=======================================
+ Hits        69169    69171    +2     
+ Misses      17024    17022    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajhall jajhall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, although we're losing something by mapping SUITESPARSE_PRINTF to printf. We should have better control of our use of printf, so that we can be sure that it can be disabled by commenting our printf in a few methods that handle it. It's led to a couple of embarrassing (rare) instances of logging being performed when the HiGHS logging is silent.

I'll add a hPrint and hFprint methods to HighsIo.h, named so they doesn't include the text string printf, making it easy to search for omissions. Clearly you can't use this in amd, so you'll need your own local `hPrint

@filikat

filikat commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator Author

The functions that call printf within amd are actually not used, and I don't see them ever being useful for us. I will just remove them so we can get rid of all mentions of printf within amd.

@filikat

filikat commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator Author

Actually, metis and rcm also have many printf and they may be useful to report errors.
I will have to define a local print function to be used in the ordering heuristics.
I will do this as a separate pr though, and leave this to be only the name changes.

@jajhall

jajhall commented Feb 9, 2026

Copy link
Copy Markdown
Member

The functions that call printf within amd are actually not used, and I don't see them ever being useful for us. I will just remove them so we can get rid of all mentions of printf within amd.

Better still

@jajhall
jajhall merged commit a3a1f2f into latest Feb 9, 2026
393 checks passed
@jajhall
jajhall deleted the amd-names branch February 9, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants