Repository navigation
Presolve rules off - #3334
Presolve rules off#3334
Conversation
…, but kPresolveRuleFirstAllowOffGeneral is only needed for kPresolveRuleDominatedCol
…en not MIP and allow_rule_[kPresolveRuleSparsify] is false
…ve_ as flags to clarify HPresolve
|
I'm not sure if I'm reading this correctly. |
Well spotted! |
…n HPresolve cannot be definitive as both may be true. Rename requireBasicSolution accordingly
|
May have to perform either basis or primal-dual postsolve (according to whether crossover is run when |
Description
The mechanism for setting presolve rules off has been simplified and clarified, with flags
HPresolve::requires_basis_postsolve_andHPresolve::requires_primal_dual_postsolve_set internally, rather than the messy (user-settable!) optionlp_presolve_requires_basis_postsolvethat is now redundant (with its documentation line annotated as such.When a basis postsolve is required, the sparsify rule is switched off, and when a primal-dual postsolve is required, the weakly-dominated column rule is switched off.
Although
requires_primal_dual_postsolve_is currently not used, it's expected to be useful as revision of presolve in the context of primal-dual postsolve continues.The unnecessary
ENABLE_SPARSIFY_FOR_LPmacro has been removed, as it was only used temporarily when sparsify was being debuggedHPresolveInitialSweephas been cleaned up in the context of enabling each of the five rules that it uses to be switched off independently. This may be necessary for @filikat. The data membermodel_has been renamedlp_because (since presolve was written) theHighsModelclass has been introduced. So, although it means a lot of trivial code changes, it's clearer.Checklist
latestbranch