Repository navigation
Conversation
Opt-Mucca
left a comment
There was a problem hiding this comment.
Quick sanity check: This doesn't cause any down-stream problems if someone were to add columns or rows with duplicate names to a model after solving it?
I had good reason to assume that it would be OK, but I'll check |
It's OK, but I've found something that can be improved! |
… names[index] != name
|
Refactored the struct Hence |
…cate; removed reference to ".ems" in logging "Please specify filename in .mps|.lp|.ems format"!
|
Only failures in tests are unrelated to this PR |
Description
As exposed by #1819, retaining the name hashes generated when adding names using
addColName/addRowNamecan lead to serious performance regression, so they are now cleared before solving any modelChecklist
latestbranchRelated issue
Closes #1819 and #3316