Skip to content

Remove error messages define in highs_bindings to avoid ODR break for other sources using pybind - #3346

Merged
jajhall merged 1 commit into
latestfrom
issue-3144
Oct 3, 2026
Merged

jajhall merged 1 commit into
latestfrom
issue-3144

Conversation

@galabovaa

@galabovaa galabovaa commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

Trivial change, can enable again locally by un-commenting out

Checklist

  • I have read the contributing guidelines
  • This PR targets the latest branch
  • Tests are passing
  • Documentation was updated where relevant
  • This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

Related issue

Closes #3144

@galabovaa
galabovaa requested a review from jajhall October 2, 2026 13:03
@galabovaa

Copy link
Copy Markdown
Contributor Author

cc @mathgeekcoder

@codecov

codecov Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.18%. Comparing base (ace45ed) to head (fb20563).
⚠️ Report is 6 commits behind head on latest.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #3346   +/-   ##
=======================================
  Coverage   74.18%   74.18%           
=======================================
  Files         451      451           
  Lines      111112   111121    +9     
  Branches    17766    17770    +4     
=======================================
+ Hits        82433    82440    +7     
- Misses      28402    28404    +2     
  Partials      277      277           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@galabovaa galabovaa self-assigned this Oct 2, 2026

@jajhall jajhall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@jajhall
jajhall merged commit d547a3a into latest Oct 3, 2026
558 checks passed
@jajhall
jajhall deleted the issue-3144 branch October 3, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants