Skip to content

Generalised Highs::crossover - #3466

Merged
jajhall merged 11 commits into
latestfrom
fix-3459
Oct 26, 2026
Merged

jajhall merged 11 commits into
latestfrom
fix-3459

Conversation

@jajhall

@jajhall jajhall commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Description

This fixes the following three issues in Highs:crossover exposed by #3459 and the work of addressing it. These are now being handled correctly in callCrossover (highs/presolve/ICrashX).

  • Ranged constraints yield extra variables when an LP is converted for IPX crossover
  • Free rows are removed when an LP is converted for IPX crossover
  • Maximization problems were not being handled

The Python code in #3459 now runs successfully, and one instance was extracted from it (check/instances/3469.mps) as the basis of test case issue-3459. A small maximization problem with boxed variables and ranged constraints and optimal solution at a variety of nonbasic status was also added - initially for debugging, but also as code coverage for handling maximizations.

The AI-generated code in #3459 was studied. Interestingly, it includes over-complicated and opaque code that fails to exploit the properties of the RHS and columns in IPX associated with ranged rows.

Checklist

  • I have read the contributing guidelines
  • This PR targets the latest branch
  • Tests are passing
  • Documentation was updated where relevant
  • This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

Related issue

Closes #3459

@codecov

codecov Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.40994% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.19%. Comparing base (b3e7094) to head (4dedd8d).
⚠️ Report is 76 commits behind head on latest.

Files with missing lines Patch % Lines
highs/presolve/ICrashX.cpp 91.91% 8 Missing ⚠️
highs/pdlp/CupdlpWrapper.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3466      +/-   ##
==========================================
+ Coverage   75.14%   75.19%   +0.04%     
==========================================
  Files         460      460              
  Lines      112233   112377     +144     
  Branches    17792    17822      +30     
==========================================
+ Hits        84341    84504     +163     
+ Misses      27610    27591      -19     
  Partials      282      282              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread highs/presolve/ICrashX.cpp Resolved
Comment thread highs/presolve/ICrashX.cpp Resolved
Comment thread highs/presolve/ICrashX.cpp Resolved
Comment thread highs/pdlp/CupdlpWrapper.cpp Resolved
@jajhall
jajhall merged commit 1e76d93 into latest Oct 26, 2026
722 of 723 checks passed
@jajhall
jajhall deleted the fix-3459 branch October 26, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants