Skip to content

Fix 3512 - #3513

Merged
jajhall merged 4 commits into
latestfrom
fix-3512
Nov 2, 2026
Merged

jajhall merged 4 commits into
latestfrom
fix-3512

Conversation

@jajhall

@jajhall jajhall commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Description

Implements the fixes in #3512. Two questions in my mind

  • Is the modification of the infeasibility/unboundedness test OK (in general)?
  • Is the switch to extended precision solves OK

I note that for two of the three test problems a commercial solver fails.

Although the test problems are terribly badly scaled, #3512 seems well thought through.

Checklist

  • I have read the contributing guidelines
  • This PR targets the latest branch
  • Tests are passing
  • Documentation was updated where relevant
  • This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

Related issue

Closes #3512

@codecov

codecov Bot commented Oct 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.41%. Comparing base (30de06d) to head (8925113).
⚠️ Report is 18 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3513      +/-   ##
==========================================
+ Coverage   75.34%   75.41%   +0.06%     
==========================================
  Files         460      461       +1     
  Lines      112876   112959      +83     
  Branches    17856    17875      +19     
==========================================
+ Hits        85047    85187     +140     
+ Misses      27541    27484      -57     
  Partials      288      288              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@filikat filikat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feasibility test looks fine, it's just checking that a problem is not already feasible before declaring it infeasible.
The switch to extended precision looks fine too, it's just more concise that what Lukas wrote. The switch only happens when an error occurs, in which case IPX would terminate otherwise.

@jajhall
jajhall merged commit da86748 into latest Nov 2, 2026
547 checks passed
@jajhall
jajhall deleted the fix-3512 branch November 2, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants