Skip to content

Improve overlap checks in enumeration presolve - #3529

Merged
jajhall merged 2 commits into
ERGO-Code:latestfrom
fwesselm:fix-3494
Nov 3, 2026
Merged

jajhall merged 2 commits into
ERGO-Code:latestfrom
fwesselm:fix-3494

Conversation

@fwesselm

@fwesselm fwesselm commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Fix #3494:

  • Reduce amount of row comparisons in HPresolve::enumerateSolutions; the new code needs 30 to 70 times fewer explicit comparisons on the models I tested.
  • Behavior is not affected.

Checklist

  • I have read the contributing guidelines
  • This PR targets the latest branch
  • Tests are passing
  • Documentation was updated where relevant
  • This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.46%. Comparing base (404e2bf) to head (78d8f09).
⚠️ Report is 25 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3529      +/-   ##
==========================================
- Coverage   75.49%   75.46%   -0.03%     
==========================================
  Files         461      461              
  Lines      113201   113232      +31     
  Branches    17880    17881       +1     
==========================================
- Hits        85462    85456       -6     
- Misses      27451    27488      +37     
  Partials      288      288              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Opt-Mucca Opt-Mucca left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change!

@jajhall
jajhall merged commit f66b7a5 into ERGO-Code:latest Nov 3, 2026
398 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants