Repository navigation
fix(cinbase): stop the 倉頡 siblings offering 㤘 under 手 codes (#390) - #1023
Merged
Merged
Conversation
) The 酷倉 sweep of ticket 08 found the same zidian-inherited `qnsm 㤘` line shipping in the tables of the same 第五代倉頡 lineage. 㤘 (U+3918) sits under Unihan radical 61 (心, +5 strokes) and the CNS official 倉頡 table (cnscj.cin) codes it 心弓尸一 only, so the character does not belong under the 手 root key in any table: - cin/cj5.cin: move the character from `qnsm` (its only code there) to `pnsm`, the CNS code 心弓尸一. - cin/thcj.cin, cin/newcj3.cin: drop the `qnsm` copy; both tables already carry 㤘 correctly at `pnsm`. - cin/simplex5.cin: move `qm` to `pm` — the two-key scheme files a character by its full code's first and last key, and the full code `pnsm` derives to `pm`, where its 忄 siblings (怛, 恒, 性…) sit. - json/{cj5,thcj,newcj3,simplex5}.json: regenerated with python/cinbase/tools/cintojson.py (unsorted path, so candidate order stays file order). thcj and newcj3 lose the `qnsm` key (cjkExtA 7451→7450 / 4523→4522, totalchardefs 85865→85864 / 140615→140614); cj5 and simplex5 only relocate the character between buckets, counters unchanged. Sweep of each table for the 忄/扌/月 confusable family (first key p/q/b checked against the character's Unihan kRSUnicode radical): every flag but 㤘 is a 心/手-at-the-bottom decomposition whose first key legitimately comes from the top component, corroborated by gcin cj5.cin and/or cnscj.cin — 愛 `bbpe`, 慧 `qjsmp`, 惷 `qap`…. The one flag neither reference covers, thcj's 𪬇 `qjph` (U+2AB07), is composed ⿱⿰丰丰必 per the dictionary, and 丰 opens with its 五代 code 手十 — the q first key is legitimate too. Architecture and design by asdf80730. Implementation generated with AI assistance from omp (tensorfold/Qwen3.8-Flash-Next).
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #390 and #1020: the 酷倉 sweep found the same inherited
qnsm 㤘line still shipping in the tables of the same 第五代倉頡lineage — 倉五, 泰瑞倉頡 and 亂倉打鳥. 㤘 (U+3918) sits under Unihan
radical 61 (心, +5 strokes) and the CNS official 倉頡 table
(
cin/cnscj.cin) codes it 心弓尸一 (pnsm) only, so the 忄-radicalcharacter does not belong under the 手 root key in any table.
cin/cj5.cin: move 㤘 fromqnsm(its only code there) topnsm,the CNS code 心弓尸一.
cin/thcj.cin,cin/newcj3.cin: drop theqnsmcopy; both tablesalready carry 㤘 correctly at
pnsm.cin/simplex5.cin(簡五): moveqmtopm— the two-key schemefiles a character by its full code's first and last key, and 㤘's
full code 心弓尸一 derives to
pm, where its 忄 siblings(怛, 恒, 性…) sit.
json/{cj5,thcj,newcj3,simplex5}.json: regenerated withpython/cinbase/tools/cintojson.py(unsorted path, so candidateorder stays file order). cj5, thcj and newcj3 lose the
qnsmkey(their qnsm bucket held only 㤘); thcj and newcj3 counters drop by
one (cjkExtA 7451→7450 / 4523→4522, totalchardefs 85865→85864 /
140615→140614), while cj5's and simplex5's stay unchanged because
the character keeps its one entry.
Sweep for other 忄/扌/月 confusables, per table: every single-glyph
chardef line whose code starts with p/q/b was checked against the
character's Unihan kRSUnicode radical (cj5 3123 of 32696 lines, thcj
8669 of 85864, newcj3 6981 of 140655, simplex5 3123 of 32696). 17 /
59 / 23 / 17 pairs flagged. Every flag but 㤘 is a 心/手-at-the-bottom
decomposition whose first key legitimately comes from the top
component — 愛
bbpe, 慧qjsmp, 惷qap… — each matching the codesthat gcin
cj5.cinand/orcnscj.cinassign. The one flag neitherreference covers, thcj's 𪬇
qjph(U+2AB07), is composed ⿱⿰丰丰必:丰 opens 手十 and 必 is 心竹, so
qjphspells its own components andthe q first key is legitimate. 㤘 was the only genuine left-radical
mismapping; gcin's 第五代
cj5.cincarriesqnsmonly for it — the字典 "Cangjie QNSM" special case cited on #390, contradicted by CNS
official codes and Unihan.
Validation:
tests/verify_windows.shon the integration tree carrying theseexact table files: 25 passed, 0 failed — including the
committed-pair regeneration test (each committed
json/*.jsonreproduces converter output byte-for-byte) on the shipped
python/python3/python.exe.㤘, the 忄 code still does) failed 6 ways on the unfixed tree and
pass with these files.
Architecture and design by asdf80730. Implementation generated with AI assistance from omp (tensorfold/Qwen3.8-Flash-Next).