Skip to content

fix(rime): auto-deploy dictionaries when compiled .bin files are missing - #1051

Merged
PCMan merged 1 commit into
masterfrom
fix/rime-auto-deploy
Nov 21, 2026
Merged

PCMan merged 1 commit into
masterfrom
fix/rime-auto-deploy

Conversation

@PCMan

@PCMan PCMan commented Nov 21, 2026

Copy link
Copy Markdown
Member

Check whether any compiled .bin files exist in the Rime user directory (%APPDATA%\PIME\Rime) instead of only checking whether the directory itself exists, and pass fullcheck=True to rimeInit() when none are found.

  • Extract needs_rime_deploy(user_dir) in python/input_methods/rime/rime_ime.py.
  • Add unit tests in tests/test_rime_deploy.py covering missing directory, directory without compiled .bin files, and directory with compiled .bin files.

Previously, rime_ime.py only triggered fullcheck=True when user_dir did not exist. If %APPDATA%\PIME\Rime already existed without compiled .bin files in its root (for example after downgrading from a newer librime that moved .bin files into trash/ and build/, or after manual cleanup), librime 1.2.9 skipped dictionary compilation on startup and produced no candidates until the user manually ran Deploy.

Architecture and design by Hong Jen Yee (PCMan). Implementation generated with AI assistance from Google Antigravity (Gemini 4 Neon).

Check whether any compiled .bin files exist in the Rime user directory instead of only checking if the directory itself exists.

If the user directory already exists without compiled .bin files (for example after downgrading from a newer librime that moved .bin files into trash/ and build/, or after manual cleanup), librime 1.2.9 skips compilation on startup and produces no candidates until the user manually triggers Deploy.

Fully generated by Google Antigravity (Gemini 4 Neon) without human intervention.
@PCMan
PCMan merged commit 258271b into master Nov 21, 2026
5 of 7 checks passed
@PCMan
PCMan deleted the fix/rime-auto-deploy branch November 21, 2026 09:47
asdf80730 added a commit to asdf80730/PIME that referenced this pull request Nov 22, 2026
Upstream cut v2.0.0-beta6 at 1911328 on 2026-11-21: EasyIME#1043 config-tool token
check, EasyIME#1049 the cinbase Shift key-up path (EasyIME#1044), EasyIME#1009 and EasyIME#1050 the Go
backend imports and optional build, EasyIME#1051 the Rime auto-deploy, EasyIME#1052 the
SignPath wait, and the version.txt bump. No feat(...) landed, so the 2026-11-13
"v2.0 first" adjudication still holds.

Conflict resolutions:

- go-backend/server.go keeps the local side, which is a superset: the guids
  loop and the "rime", "rime-cn" case (ADR 0004) over upstream's single guid.
- go-backend/server_integration_test.go takes upstream's close-notification test.
- python/cinbase/__init__.py takes upstream's lastKeyEvent key-up path, with the
  local shiftTapCount loop kept so N taps still toggle N times; the local
  shiftTapMatches now passes cbTS to isPressed for its per-side check.
- python/input_methods/rime/rime_ime.py stays the thin wrapper; upstream's
  needs_rime_deploy and fullcheck land in python/rimebase/rime_service.py and
  are re-exported by both profile wrappers, and tests/test_rime_deploy.py is
  re-pointed at that module pair.

docs/tour/index.html and the maintainer-plan record now read against 1911328.

Fully generated by omp (Qwen3.8-Flash-Next) without human intervention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant