Repository navigation
fix(rime): auto-deploy dictionaries when compiled .bin files are missing - #1051
Merged
Merged
Conversation
Check whether any compiled .bin files exist in the Rime user directory instead of only checking if the directory itself exists. If the user directory already exists without compiled .bin files (for example after downgrading from a newer librime that moved .bin files into trash/ and build/, or after manual cleanup), librime 1.2.9 skips compilation on startup and produces no candidates until the user manually triggers Deploy. Fully generated by Google Antigravity (Gemini 4 Neon) without human intervention.
asdf80730
added a commit
to asdf80730/PIME
that referenced
this pull request
Nov 22, 2026
Upstream cut v2.0.0-beta6 at 1911328 on 2026-11-21: EasyIME#1043 config-tool token check, EasyIME#1049 the cinbase Shift key-up path (EasyIME#1044), EasyIME#1009 and EasyIME#1050 the Go backend imports and optional build, EasyIME#1051 the Rime auto-deploy, EasyIME#1052 the SignPath wait, and the version.txt bump. No feat(...) landed, so the 2026-11-13 "v2.0 first" adjudication still holds. Conflict resolutions: - go-backend/server.go keeps the local side, which is a superset: the guids loop and the "rime", "rime-cn" case (ADR 0004) over upstream's single guid. - go-backend/server_integration_test.go takes upstream's close-notification test. - python/cinbase/__init__.py takes upstream's lastKeyEvent key-up path, with the local shiftTapCount loop kept so N taps still toggle N times; the local shiftTapMatches now passes cbTS to isPressed for its per-side check. - python/input_methods/rime/rime_ime.py stays the thin wrapper; upstream's needs_rime_deploy and fullcheck land in python/rimebase/rime_service.py and are re-exported by both profile wrappers, and tests/test_rime_deploy.py is re-pointed at that module pair. docs/tour/index.html and the maintainer-plan record now read against 1911328. Fully generated by omp (Qwen3.8-Flash-Next) without human intervention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check whether any compiled
.binfiles exist in the Rime user directory (%APPDATA%\PIME\Rime) instead of only checking whether the directory itself exists, and passfullcheck=TruetorimeInit()when none are found.needs_rime_deploy(user_dir)inpython/input_methods/rime/rime_ime.py.tests/test_rime_deploy.pycovering missing directory, directory without compiled.binfiles, and directory with compiled.binfiles.Previously,
rime_ime.pyonly triggeredfullcheck=Truewhenuser_dirdid not exist. If%APPDATA%\PIME\Rimealready existed without compiled.binfiles in its root (for example after downgrading from a newerlibrimethat moved.binfiles intotrash/andbuild/, or after manual cleanup),librime1.2.9 skipped dictionary compilation on startup and produced no candidates until the user manually ran Deploy.Architecture and design by Hong Jen Yee (PCMan). Implementation generated with AI assistance from Google Antigravity (Gemini 4 Neon).