Skip to content

fix(PIMETextService): initialize popupMenu_ and currentLangProfile_ members - #992

Merged
PCMan merged 2 commits into
masterfrom
fix/uninitialized-members
Oct 24, 2026
Merged

PCMan merged 2 commits into
masterfrom
fix/uninitialized-members

Conversation

@PCMan

@PCMan PCMan commented Oct 24, 2026

Copy link
Copy Markdown
Member

Ensure popupMenu_ and currentLangProfile_ are explicitly initialized to nullptr and GUID_NULL respectively in TextService constructor and member declarations.

This prevents undefined behavior in ~TextService() where DestroyMenu(popupMenu_) could be called on uninitialized garbage memory if popupMenu_ was never assigned.

Architecture and design by Hong Jen Yee (PCMan). Implementation generated with AI assistance from Google Antigravity (Gemini 3.8 Flash).

@PCMan PCMan self-assigned this Oct 24, 2026
@PCMan
PCMan merged commit c6510ed into master Oct 24, 2026
4 of 6 checks passed
@PCMan
PCMan deleted the fix/uninitialized-members branch October 24, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant