Skip to content

docs: emphasize focused, small PRs solving one problem at a time in AGENTS.md - #996

Merged
PCMan merged 2 commits into
masterfrom
docs/agents-rules-focused-prs
Oct 24, 2026
Merged

PCMan merged 2 commits into
masterfrom
docs/agents-rules-focused-prs

Conversation

@PCMan

@PCMan PCMan commented Oct 24, 2026

Copy link
Copy Markdown
Member

Rephrases Rule 2 in AGENTS.md to emphasize single-topic, focused, and small Pull Requests solving exactly one problem at a time.

Key points emphasized:

  • Single Topic per PR: Strictly avoid bundling multiple unrelated bug fixes, features, or architectural adjustments into a single PR. If a task touches multiple areas, split them into independent, modular PRs.
  • Granular, Incremental Commits: Keep changes strictly scoped. Break down larger work into logical, incremental commits where each commit handles an independent step.
  • Benefits: Ensures fast code review, straightforward rollbacks, and clear CI failure isolation.
  • Rejection: Monolithic, kitchen-sink PRs will be strictly rejected during review.

Architecture and design by Hong Jen Yee (PCMan). Implementation generated with AI assistance from Google Antigravity (Gemini 3.8 Flash).

…GENTS.md

Rephrase Rule 2 to emphasize single-topic, modular PRs solving one problem at a time. Explain rationale including fast reviews, easy rollback, and clear CI failure isolation, while explicitly forbidding bundling multiple unrelated fixes or features into a single PR.

Architecture and design by Hong Jen Yee (PCMan). Implementation generated with AI assistance from Google Antigravity (Gemini 3.8 Flash).
@PCMan PCMan self-assigned this Oct 24, 2026
… code

The human-architected vs fully autonomous distinction applies specifically to code changes (commits and PRs), whereas PR review comments, discussions, and issue reports simply use a concise footer declaration.

Architecture and design by Hong Jen Yee (PCMan). Implementation generated with AI assistance from Google Antigravity (Gemini 3.8 Flash).
@PCMan
PCMan merged commit 6e0aa9c into master Oct 24, 2026
4 of 6 checks passed
@PCMan
PCMan deleted the docs/agents-rules-focused-prs branch October 24, 2026 23:18
asdf80730 added a commit to asdf80730/PIME that referenced this pull request Oct 25, 2026
Upstream landed EasyIME#997/EasyIME#998 (launcher close forwarding and client-ID
validation), EasyIME#988 (Python user-dir ACL fallback), EasyIME#971/EasyIME#951/EasyIME#937/EasyIME#936
(node guards and tests), EasyIME#996 (AGENTS.md AI declaration and header
rules), and dropped the vendored inetc plugin in EasyIME#966.

Conflict resolutions:
- node/server.js: take upstream, which supersedes our EasyIME#937 implementation
  with an uncaughtException handler and the same fallback service.
- node/loadServices.js: keep upstream's guards and re-thread the fork's
  `baseDir` parameter so test/loadServices.test.js still drives a fixture.
- node/package.json: run upstream's nimeServer suite plus the two local
  suites, matching the CI steps.
- PIMELauncher/src/protocol.rs: keep upstream's parse_backend_input and
  the rustfmt layout from local master.

Generated with assistance from omp (DeepSeek V4.1 Flash).
asdf80730 added a commit to asdf80730/PIME that referenced this pull request Oct 25, 2026
Upstream AGENTS.md now asks code commits and PRs to separate human
architecture from fully autonomous output, and to ask the user when the
brief cannot tell them apart. Record that in the upstream PR checklist,
let the body check accept either form (plus the pre-EasyIME#996 one-liner on
already-posted bodies), and note that `gh pr ready` is 403 like the other
write calls.

Also run upstream's nimeServer suite in the no-npm fallback, and ignore
the `%APPDATA%` and `node_modules` trees the local runs leave behind.

Fully generated by omp (DeepSeek V4.1 Flash) without human intervention.
asdf80730 added a commit to asdf80730/PIME that referenced this pull request Oct 30, 2026
The rime runtime tests sat cached-green in verify_windows.sh while a fresh
run failed them: the bundled x64 rime.dll cannot load into an arm64
process, and the upstream test only skips when APPDATA is absent. Pin the
Go step to -count=1 with APPDATA cleared so the skip and the non-skipped
set are both deterministic; the real rime pass is the GOARCH=amd64 brise
run at PR-delivery time, per SHA.

Add tests/check_pr_commit_declarations.sh with its self-test: PR EasyIME#1010
shipped two commits whose messages carry none of the EasyIME#996 declaration
forms and no gate was watching commit messages at all. Name the new gate
in upstream-pr.md beside its siblings, record the head-SHA re-run rule for
Validation lines in code-review.md, and pin the backtick citation shape
the body gate extracts.

Architecture and design by asdf80730. Implementation generated with AI
assistance from omp (tensorfold/Qwen3.8-Flash-Next).
asdf80730 added a commit to asdf80730/PIME that referenced this pull request Nov 8, 2026
…n gate

The upstream merge brought in python/cinbase/cintablebase.py and
tests/test_cintablebase.py, which open with the header the product uses
for its own files, "# API design and architecture by Hong Jen Yee
(PCMan)." — the same shape PIMETextService/AsyncConnector.* and
RpcPipe.* carry. The gate only knew the five EasyIME#996 forms, so both files
read as undeclared and the merge commit could not form.

Add the form to the accepted set and pin it in
tests/check_ai_declarations_test.sh with a file that carries nothing but
that header: dropping the alternative from the regex reddens the new
case (verified by mutation), so the acceptance is not an accident of the
sandbox.

Architecture and design by asdf80730. Implementation generated with AI
assistance from omp (tensorfold/Qwen3.8-Flash-Next).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant