You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It can be added to suggested tools. But I have a doubt about usefulness. phpqa analyzes code. If you run analysis twice, you'll get the same result. php-cs-fixer isn't like that. It can fix code in CI build, but changes aren't committed. Wouldn't be better to install phpqa and php-cs-fixer separately?
@zdenekdrahos You are right that changing code style errors in the ci build does not make any sense. However, if php-cs-fixer is run with junit as output (optionally in "dry-run" mode, to not change anything and produce the same results every time), it is a static analyser just like phpcs.
Activity
zdenekdrahos commentedon Apr 23, 2017
How would you like to use
php-cs-fixerin phpqa?It can be added to suggested tools. But I have a doubt about usefulness. phpqa analyzes code. If you run analysis twice, you'll get the same result.
php-cs-fixerisn't like that. It can fix code in CI build, but changes aren't committed. Wouldn't be better to install phpqa and php-cs-fixer separately?keradus commentedon Apr 23, 2017
in same way that
phpcpdorphpmdor anything that is currently supported.PHP CS Fixercould fix indeed, but it could also generate violations report.mastercoding commentedon Apr 23, 2017
@zdenekdrahos You are right that changing code style errors in the ci build does not make any sense. However, if php-cs-fixer is run with junit as output (optionally in "dry-run" mode, to not change anything and produce the same results every time), it is a static analyser just like phpcs.
zdenekdrahos commentedon Apr 24, 2017
Ok.
php-cs-fixergonna be in the next release.I'll ask you for your review in a PR.