Repository navigation
Conversation
3 of 12 tasks
Contributor
|
This PR is tracked in the #86 implementation checklist: #86 (comment) Two points from that plan affect this PR:
The #86 work branch also changes the Chat UI and its built files, so it will rebase on this PR after it merges and rebuild Chat once. |
Contributor
irzhywau
added this pull request to stack #124
September 29, 2026 18:39
irzhywau
marked this pull request as ready for review
September 30, 2026 13:12
irzhywau
force-pushed
the
fix/chat-invite-in-home-0.7.1-models
branch
from
September 30, 2026 14:32
d827e64 to
4ec8cdd
Compare
chat_control_policy showed the access toggle, Access panel with Create join link, join box and join requests only off Home (!shell_mode), while their handlers refuse outside Home ("conversation links must be opened from Home"). Before the direct and shared conversation UI they were Home-only. The policy is Home-only again, still hidden when collaboration is configured, and the join button is enabled whenever the join box shows.
Co-authored-by: Cursor <cursoragent@cursor.com>
irzhywau
force-pushed
the
fix/chat-invite-in-home-0.7.1-models
branch
from
September 30, 2026 15:48
4ec8cdd to
58c8425
Compare
irzhywau
marked this pull request as draft
September 30, 2026 16:32
7 of 12 tasks
irzhywau
removed this pull request from stack #124
September 30, 2026 16:54
Contributor
Author
|
Closing as agreed with Anders. Invite links and QR codes stay out of the first user release (0.8.0), and the server currently refuses room joins (409), so these controls would only lead to a refusal. Invites come back as stages 2 and 3 of #86 once there is a server join path. The branch |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat in Home shows the invite, join and access controls again. This is the "URI for connecting peer to peer" that went missing. Draft for review on
feat/0.7.1-models, independent of the phone PR.What was wrong
Since
bf7e14586(direct and shared conversation UI, Aug 10),chat_control_policyhas shown the access toggle, the Access panel with Create join link, the join box and pending join requests only when the room is not in Home (!shell_mode). Their handlers refuse everywhere except Home:create_conversation_join_invite: "conversation links are only available from Home"join_conversation_from_invite: "conversation links must be opened from Home"So in Home the controls were hidden, and anywhere else they were visible but refused. Before
bf7e14586these controls were Home-only (is_shell_mode()), so this looks like an inverted condition rather than a design decision.Join/leave lines are written per Runtime (
room_service.rs), so they only appear once two Homes share a room. Without the invite link there was no way to get there, which is why no join messages showed.Change
chat_control_policy: the access toggle, Access panel, join box and join requests show in Home again (room_mode_known && shell_mode && !configured). Send and attach are unchanged.chat_room_ui.js/chat_room_ui_bg.wasmwithscripts/build-chat-room-ui.sh, updated.chat_room_ui_source.sha256, and bumped the asset version tochat-room-ui-20260929a.shell_isolated,gateway_isolated,unconfigured_gateway,unconfigured_shell) andshell_isolated_unjoinedadded.Question for review
I kept
!configured: when collaboration is configured, these controls stay hidden in Home as they are today. If configured rooms should also offer the invite link, that's a one-term change.Gates
cargo testincapsules/chat-room-ui(30 pass) andcargo fmt --check.home-entropy-check, chat behaviour and layout smokes, source gate 14/14.Made with Cursor
Part of #86