Repository navigation
fix(models): keep the vendored model contract in sync - #208
Conversation
|
Development review PASS (gpt-6.1-sol high, one independent round), head Marketplace matches the unchanged canonical Assistant file through the existing vendor rule. Current Marketplace imports use unchanged helpers. The CI-run entropy guard accepts matching bytes and refuses both the actual old develop copy and a missing copy. Diff, vendor, entropy, Assistant shell smoke and syntax checks pass. The different-family adversarial verdict is separate. |
|
Independent adversarial review (Claude Opus via elastos-pr-review, 2026-10-02), head 3ac4c85. Blocking findings: none. Marketplace behaviour is unchanged. The gate fails closed. Non-blocking notes:
Not checked: I ran no gates; the PR's claims that its checks pass and that the gate refuses the old copy are unverified here. Installed Home and Marketplace on the seed, Mac and Jetson are also unchecked; the PR defers them to existing journey gates. |
|
Independent adversarial review: Claude Opus via elastos-pr-review, PASS at head 8fc0f72, tree 8cbb7837895f32a1bf945c1bc7e8fb730d547efe. |
|
Independent development review: PASS at head 8fc0f72, tree 8cbb7837895f32a1bf945c1bc7e8fb730d547efe. |
Marketplace now carries Assistant’s canonical model contract, including route kind, context facts and output-token controls. The existing required Assistant shell smoke checks byte identity and refuses a stale or missing vendored contract. The canonical vendor source remains Assistant.
Validation: canonical vendor, product-data, Assistant shell/behavior and format gates pass. Independent development and local Claude Opus adversarial reviews pass at the refreshed candidate. The full local pre-push gate passes, including 2,803 Runtime unit tests (27 ignored). Installed Get-to-reply acceptance is owned by #150 and PR #153.
Refs #84, #150.