Repository navigation
ci(gate): fewer full rebuilds: accept a clean, disjoint base; no full clean in a private build dir - #263
Merged
Conversation
…ild dirs in pre-push gate
Contributor
Author
|
Verdict record: candidate 3dd877c (head) = cf5d70ab + 9f6bb3c1, rebased with no change to the reviewed bytes. Review by GPT-6 Sol: MODIFY (drop the override; say CI proves the merge), fixed in 9f6bb3c1. ci-local-prepush-test: 62 OK. |
…ilds # Conflicts: # scripts/ci-local-prepush.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. The local pre-push gate forced a full rebuild far more often than needed:
ci-local-prepush.py:119). So every merge into develop sent every open branch through another 10–15 minute check.cargo clean -pfor all repository packages, because the worktrees share one build directory.Change.
target-build. Remote build boxes use this.Tests.
ci-local-prepush-test.py: 62 pass.Written by Claude Opus. Reviewed by GPT-6 Sol: MODIFY (no unchecked override; say CI proves the merge), done.