Repository navigation
Conversation
Review package extracted from preserved candidate b0fa431d. The original eighteen commits remain on fix/runtime-performance-080. Validation of this recomposed head is recorded separately from historical candidate evidence.
|
Independent review (Claude) of 557cdd3: PASS after fixes. Shutdown order is correct; removing the fail-fast break fails 2 tests. |
Co-authored-by: Codex
Co-authored-by: Codex
Co-authored-by: Codex
Use the installed System fixture for valid and invalid Home-link requests so the test exercises link authority on every host. Keep all assertions and production launch checks unchanged. Verified the exact Home-link test passes, reverting only the System token to Browser fails the intended 403-versus-200 assertion, and restoring the fixture passes again. Co-authored-by: Codex
|
Review at 619c096: PASS (A-). Reap, failure log, bridge CI job and fixture change proven. |
develop now carries its own fix for the #430 Home link test (bfefe92: the test uses Library, which every platform launches). This branch had ported #411's 619c096 for the same test (System instead of Browser), and the two edits conflicted in gateway_tests/home_system.rs. That port was this branch's only change to the file, so the file is taken from develop; 04b621d's change is superseded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
develop now carries its own fix for the #430 Home link test (bfefe92: the test uses Library, which every platform launches). This branch had ported #411's 619c096 for the same test (System instead of Browser), and the two edits conflicted in gateway_tests/home_system.rs. Every conflicting hunk was inside that one test, so each takes develop's side; the test is now identical to develop's and 89d62f9's change is superseded. This branch's own home_system.rs tests are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
Co-authored-by: Codex
|
Ready for Claude review at |
Preserve the reviewed behavior and integrate the verified base through the named parent. Co-authored-by: Codex
|
Updated head: |
The Browser guest bridge reclaims completed workers on new connections. Finite shutdown resolves accepted sessions and reports worker failures. Real-socket regressions and pinned bridge CI cover #318.
At prior head
3943730b, both required local gates passed, including 12 bridge tests. Fromelastos/tools/browser-vm-guest-control-bridge/:cargo test -p browser-vm-guest-control-bridge --bin browser-vm-guest-control-bridge -- --nocapture cargo clippy --all-targets -p browser-vm-guest-control-bridge -- -D warningsEarlier controls at
619c0961caught removal of worker reaping, failure logging and required bridge CI commands. Its Home-link tamper changed System to Browser: Linux returned 403; the macOS reviewer observed 200 naming Browser. Restoring System passed on Linux. These controls remain historical evidence.The base merge adopts develop's canonical Library Home-link fixture. #428 inherits this candidate at
898ef790.Candidate:
898ef790a17eda2b1afb40eba108254348dc0f84; mergeddevelop:3a043849e2c91af3fd338def86d1e3a76d74e701. Required local checks: manualjust ci-local-prepushand the actual unchanged push hook PASS, including all 12 bridge tests in each gate. Hosted CI: PASS, with all 18 jobs successful.Prior-head Claude review records PASS (A-) at
3943730b. Independent source-continuity review passed: all three owned paths match the prior reviewed head. The current-head Claude re-review records PASS at898ef790; the linked earlier verdict remains historical evidence. Installed VM transport acceptance remains pending.Review order: #420 → #421 → #424 → #416 → #411 → #412 → #428. #417 owns ZIP remediation. Draft; target
develop.