Skip to content

Minimum service factor is applied incorrectly #375

Closed

Description

@alexdewar

Currently, we seem to be multiplying utilisation factor by minimum service factor, which is not the correct calculation. (I guess this means that the minimum is treated as being a proportion of utilisation factor?)

See:

techs.fixed_outputs * techs.utilization_factor * techs.minimum_service_factor,

@dalonsoa I may have misremembered, but did you say that there were other places in the code where we're using this value incorrectly?

Activity

  1. moved this to 📋 Backlog in MUSEon Jun 26, 2024
  2. dalonsoa commented on Jun 27, 2024

    @dalonsoa
    Collaborator

    It is being implemented somewhere else in #368. But it is not clear if that PR is actually needed - based on the discussions taking place in #335 - and even if it is, I will obviously fix that PR directly.

  3. dalonsoa commented on Jun 27, 2024

    @dalonsoa
    Collaborator

    In summary, I think that's the only place where it is used the wrong way.

  4. moved this from 📋 Backlog to 🔖 Ready in MUSEon Jun 28, 2024
  5. tsmbland commented on Jul 1, 2024

    @tsmbland
    Collaborator

    See also #382

  6. self-assigned this
    on Jul 1, 2024
  7. moved this from 🔖 Ready to 🏗 In progress in MUSEon Jul 2, 2024
  8. moved this from 🏗 In progress to 👀 In review in MUSEon Jul 2, 2024
  9. tsmbland commented on Jul 2, 2024

    @tsmbland
    Collaborator

    Closed by #388

  10. moved this from 👀 In review to ✅ Done in MUSEon Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    ✅ Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions