Conversation
furtib
marked this pull request as draft
August 26, 2026 12:09
furtib
force-pushed
the
per-file-monolithic-parity
branch
3 times, most recently
from
August 27, 2026 08:33
d0ed96b to
62e14ca
Compare
furtib
force-pushed
the
per-file-monolithic-parity
branch
from
August 27, 2026 09:15
62e14ca to
e2ad1f5
Compare
furtib
marked this pull request as ready for review
September 7, 2026 06:51
Szelethus
reviewed
Sep 22, 2026
Szelethus
left a comment
Collaborator
There was a problem hiding this comment.
So, much of this PR is completely trivial refactoring. I'd prefer to have the NFC parts land separately, because it'd make the review easier. Of substance, the patch looks mostly right, and I agree with the overall direction of reusing more code. Speaking of that, I wish we could resurrect #141...
Szelethus
reviewed
Sep 22, 2026
Comment on lines
+36
to
+43
| expected_action_count = 2, | ||
| file_to_modify = "secondary.cc", | ||
| target_name = "per_file_caching", | ||
| ) | ||
|
|
||
| caching_test( | ||
| name = "caching_per_file_ctu_test", | ||
| expected_action_count = 2, | ||
| expected_action_count = 3, |
Collaborator
There was a problem hiding this comment.
What are we seeing here?
Contributor
Author
There was a problem hiding this comment.
The parse action is a separate action, thus, the action count is increased, as expected.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want complete feature parity between the monolithic and the per_file rule.
The per_file rule currently does not support the severities attribute.
The per_file rule should behave exactly the same during parsing, and when checking the severities, any difference between the two should be considered a bug, not a feature.
That's why, instead of rewriting the logic for parsing and checking severities, I have reused the well-tested monolithic implementation.
What:
Addresses:
Fixes: #309
Fixes: #279
Depends on: #311