Repository navigation
Bump minimatch to patched versions - #815
Merged
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
|
I have read the CLA Document and I hereby sign the CLA |
melvin-bot
Bot
requested review from
stitesExpensify
and removed request for
a team
October 26, 2026 19:01
blimpich
previously approved these changes
Oct 26, 2026
blimpich
left a comment
Contributor
There was a problem hiding this comment.
– written by Claude on Ben's behalf
stitesExpensify
previously approved these changes
Oct 27, 2026
|
RIP, conflicts |
# Conflicts: # package.json
blimpich
dismissed stale reviews from stitesExpensify and themself
via
October 27, 2026 16:18
ddae8ed
blimpich
approved these changes
Oct 27, 2026
stitesExpensify
approved these changes
Oct 27, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Bumps transitive
minimatchto patched versions, fixing open ReDoS Dependabot alerts (GHSA-7r86-cg39-jmmj, GHSA-23c5-xmqv-rm74, GHSA-3ppc-4f35-3m26):3.1.2→3.1.55.1.6→5.1.98.0.4→8.0.79.0.3→9.0.9:@typescript-eslint/typescript-estree@6.21.0(viaeslint-plugin-deprecation) pins9.0.3exactly, so a scopedoverridesentry (minimatch@9.0.3→^9.0.7) dedupes it to the existing root9.0.9.Usage: not imported by the library. Only dev/build tooling uses it for glob matching: ESLint and its plugins,
react-native-builder-bob(build),patch-package,nodemon, Jest coverage (test-exclude), andbabel-plugin-module-resolverinexample/.Change Log
*(ReDoS fix)**, big perf improvement (ReDoS fix)fastTestset as a property on the regex object; build with tshybrace-expansion@2Related Issues
$ https://github.com/Expensify/Expensify/issues/695658
Manual Tests
npm ci, thennpm ls minimatch --all: nominimatchbelow3.1.5,5.1.9,8.0.7, or9.0.9.npm run lint,npm run typecheck, andnpm testpass.npm run preparebuildslib/without errors.exampleapp on iOS and Android. Confirm Metro bundles and the markdown input renders and formats text.Steps 1–3 pass locally.
Linked PRs
None.