Repository navigation
Add npm min-release-age cooldown for supply chain protection - #847
Conversation
Only resolve package versions published at least 7 days ago. npm ci and lockfile-clean installs are unaffected. See Expensify/Expensify#636594
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ccbf62606
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@NicolasBonet Could you create a PR in E/App to bump Onyx to this new version? |
Details
min-release-age=7) so freshly published, possibly malicious package versions are not resolved;npm ciand lockfile-clean installs are unaffected.eslint-config-expensifyis excluded because we publish and consume it same-day.Design doc: https://expensify.enterprise.slack.com/docs/T03SC9DTT/F0BNG8W2FML
Related Issues
https://github.com/Expensify/Expensify/issues/636594
Linked E/App PR
Expensify/App#95897
Automated Tests
None added: npm enforces the cooldown at version-resolution time, and existing CI
npm cicovers the no-op case.Manual Tests
Tooling-only change, no library code affected. Existing CI
npm cicovers the no-op case.nvm useand confirmnpm --versionprints11.17.0.npm config get min-release-agefrom the repo root and confirm it prints7.npm ciand confirm it installs the lockfile contents without errors.npm install @types/node@latest --dry-runand confirm npm resolves a version published at least 7 days ago (currently22.20.1, not the fresh22.20.3).npm install @types/node@latest --dry-run --min-release-age=0and confirm npm resolves the fresh version, showing the bypass works.Author Checklist
### Related Issuessection above### Linked E/App PRsection above, and verified this change against it (E/App CI passed and manual testing completed)TestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A, no UI change.