Repository navigation
BUGFIX: rendering often fails while content publishes are happening - #71
Merged
Merged
Conversation
t-heuser
force-pushed
the
fix-iterations-error
branch
from
October 6, 2026 13:15
5546954 to
51cb2a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content releases often failed after their 10 iterations while editors were publishing. The orchestrator only added
rendered pages to the release after a whole rendering iteration had finished. Publishing clears the content cache of
the published node (and of nodes where it is used), so pages rendered earlier in the iteration were often gone again by
then and had to be rendered once more.
Now the render workers report every rendered page to the orchestrator (new Redis list
renderedJobs), and theorchestrator adds it to the release right away. This can make a release slightly inconsistent, because a page may miss
changes published while the release was running. That is acceptable: every publish schedules an incremental release,
which picks those changes up (unless automatic releases are paused).
The cache flush before re-rendering a node moved from the render workers to the orchestrator. It now happens once per
node and retry iteration, before the node's jobs are queued. The node's cache tag is not dimension specific, so when
workers flushed it, they also wiped variants other workers had just rendered, which made those incomplete again and
caused further retries.