Repository navigation
feat(wf nested condition): allow nested condition on gateway step - #2064
Merged
Merged
Conversation
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (2)
🛟 Help
|
arnaud-moncel
force-pushed
the
feat/wf-nested-condition
branch
from
November 6, 2026 10:16
2f61628 to
bf29fb2
Compare
christophebrun-forest
left a comment
Member
There was a problem hiding this comment.
No blocker. Three small points below.
Package docs: packages/workflow-executor/CLAUDE.md:40 still says "Top-to-bottom, first-match-wins, and/or aggregator". It should also say that:
- an option's conditions can hold
and/orgroups, nested at any depth; - an empty group is rejected at the schema boundary;
- each group entry in
evaluations[].conditionscarries its ownmetand the results of its ownconditions.
forest-bot
added a commit
that referenced
this pull request
Nov 10, 2026
# @forestadmin/workflow-executor [1.36.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/workflow-executor@1.35.8...@forestadmin/workflow-executor@1.36.0) (2026-11-10) ### Features * **wf nested condition:** allow nested condition on gateway step ([#2064](#2064)) ([aa0c257](aa0c257))
christophebrun-forest
added a commit
that referenced
this pull request
Nov 10, 2026
Resolves the conflict with #2064 (nested condition groups): - the server condition node carries `sourceType`, nullable like the schema; - a condition node is dispatched on its shape instead of through z.union, so an unknown source type, operator or sub-workflow End rule names the field at fault instead of a bare "Invalid input"; - tests cover a sub-workflow End condition inside a group, mixed with Get Data, and a second call of a workflow not seeing the Ends of the first. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definition of Done
Fixes PRD-1171
General
Security
Note
Add nested
and/orcondition groups to deterministic condition-step optionsCondition step options in gateway steps now accept recursive
and/orgroups, not just flat condition lists.aggregator(and/or).ConditionStepExecutor.evaluateGrouprecursively evaluates each child and aggregates per level, recording nested results and not-loaded reasons in the evaluation trace (condition-step-executor.ts).ConditionEvaluation.conditionsnow uses the new recursiveConditionResulttype (step-execution-data.ts); server-side types mirror the shape (server-types.ts).ConditionEvaluation.conditionssee the new nestedConditionResultshape instead of the previous flat inline fields.Changes since #2064 opened
workflow-executorinto a discriminated union of leaf and group results [b8b7d99]ConditionStepExecutorAI decision tests inworkflow-executorfor group evaluation [b8b7d99]workflow-executordocumentation to cover nested condition groups [b8b7d99]Macroscope summarized 0c53a99.