Skip to content

fix(datasource-sql): improve the connect management errors #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Scra3 merged 1 commit into from
Jun 9, 2023
Merged

fix(datasource-sql): improve the connect management errors #721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/datasource-sql/src/connection/handle-errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function handleProxyErrors(
): void {
// eslint-disable-next-line max-len
// @link: list of errors thrown by the proxy https://github.com/JoshGlazebrook/socks/blob/76d013e4c9a2d956f07868477d8f12ec0b96edfc/src/common/constants.ts#LL10C10-L10C10
if (error?.stack.includes('SocksClient')) {
if (error?.stack?.includes('SocksClient')) {
if (
error.message.includes('Socket closed') ||
error.message.includes('Socks5 proxy rejected connection')
Expand Down
8 changes: 8 additions & 0 deletions packages/datasource-sql/test/connection/handle-errors.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ describe('handleErrors', () => {
});
});

describe('when the error has an empty stack trace', () => {
it('should throw an error', () => {
const error = new Error('An error');
error.stack = null;
expect(() => handleErrors(error, null, null)).toThrow(error);
});
});

describe('when the error is thrown by the proxy', () => {
describe('when the proxy has an error with database uri', () => {
it('should throw an error', () => {
Expand Down