[LateButEarly]

I wanted to leave a few notes here:

My conditional checks the _has_paid_plans attribute; however, the conditionals only a few lines above this check using a _has_addons function.

I think these should be consistent throughout the code - for example, maybe we could benefit from having a _has_paid_plans function? I'm not sure how you want to keep that structured, but it was kind of confusing having some internal functions using _has_xyz returning their _has_xyz attribute.

Let me know if I can be of any help. 👍

[LateButEarly]

Oops, I just noticed this was pulled to master. Let me know if this should be pulled to dev.

[fs-contributor]

Hey @irkanu, that's our first pull-request - #exciting! Thanks for spending the time to check the code. I'm not sure if you noticed, but the last param of add_submenu_item() is $show_submenu, and $this->has_paid_plan() is part of the last param provided to the call. So basically, if the plugin doesn't have any paid plans the submenu item won't be visible. Am I missing something?

_has_paid_plans is a private member of the Freemius class. There is a public function named has_paid_plan() which you can use from outside. The best way to see all the public methods that would always be back compatible is by checking the abstract class Freemius_Abstract at class-freemius-abstract.php.

Let me know if you still think that a pull request is required.