You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Confirmed on current main: AppLoggingConfig::include_sensitive_diagnostics uses #[serde(default = "default_true")] and the Default impl sets true, while all three locale files (zh-CN/zh-TW/en-US), the capability docs ("Enable only when explicitly needed and after reviewing the privacy risk") and the settings-page fallback (?? false) all promise off-by-default. The frontend FrontendLogLevelSync fallbacks (: true) drift the same way.
I'd flip the backend default to false (serde default + Default impl + the pinned defaults test), align the two frontend fallbacks, and keep explicit user values untouched. If that sounds right, I'll send a PR against main.
Activity
xiechimon commentedon Sep 23, 2026
Confirmed on current main:
AppLoggingConfig::include_sensitive_diagnosticsuses#[serde(default = "default_true")]and theDefaultimpl setstrue, while all three locale files (zh-CN/zh-TW/en-US), the capability docs ("Enable only when explicitly needed and after reviewing the privacy risk") and the settings-page fallback (?? false) all promise off-by-default. The frontendFrontendLogLevelSyncfallbacks (: true) drift the same way.I'd flip the backend default to false (serde default +
Defaultimpl + the pinned defaults test), align the two frontend fallbacks, and keep explicit user values untouched. If that sounds right, I'll send a PR against main.