Skip to content

feat: remove requirement to input IP - #3015

Merged
dgibbs64 merged 27 commits into
developfrom
feature/ip
Sep 12, 2020
Merged

dgibbs64 merged 27 commits into
developfrom
feature/ip

Conversation

@dgibbs64

@dgibbs64 dgibbs64 commented Sep 5, 2020 •

Copy link
Copy Markdown
Member

Description

Removes a long time annoyance for any users who have servers with multiple IP addresses.

Now if the server has more than one IP address LinuxGSM will automatically try query all IP's until it gets a response.

The default IP in settings will now be 0.0.0.0 this also helps resolve issues with source servers and LAN browser #2534

If required it is still possible to manually enter the IP address you want to use. Also, displayip setting is useful if you want your alert to specify an IP address

IP variables for reference
ip the default IP for the server if using 0.0.0.0 LinuxGSM will query all available IP addresses
queryips a list of the ip addresses that will be queried
queryip the ip address that is being queried
displayip the ip/hostname you want to show up in alerts. if unset the internet-facing IP will be used
extip the external internet-facing IP address

Fixes #1973

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64 dgibbs64 added this to the v20.5.0 milestone Sep 12, 2020
@dgibbs64 dgibbs64 added the type: feature New feature or request label Sep 12, 2020
@dgibbs64 dgibbs64 linked an issue Sep 12, 2020 that may be closed by this pull request
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IP address handling review If only 1 IP address insert in to game config Getting servers to show up in the "LAN" tab of Steam's server browser

1 participant