Repository navigation
feat: remove requirement to input IP - #3015
Merged
Merged
Conversation
This was referenced Sep 13, 2020
1 of 13 tasks
This was
linked to
issues
Sep 20, 2020
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes a long time annoyance for any users who have servers with multiple IP addresses.
Now if the server has more than one IP address LinuxGSM will automatically try query all IP's until it gets a response.
The default IP in settings will now be 0.0.0.0 this also helps resolve issues with source servers and LAN browser #2534
If required it is still possible to manually enter the IP address you want to use. Also, displayip setting is useful if you want your alert to specify an IP address
IP variables for reference
ipthe default IP for the server if using 0.0.0.0 LinuxGSM will query all available IP addressesqueryipsa list of the ip addresses that will be queriedqueryipthe ip address that is being querieddisplayipthe ip/hostname you want to show up in alerts. if unset the internet-facing IP will be usedextipthe external internet-facing IP addressFixes #1973
Type of change
Checklist
PR will not be merged until all steps are complete.
developbranch as its base.Documentation
If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.
Thank you for your Pull Request!