Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,30 +1,30 @@
{
"name": "BASH Dev Container",
"image": "mcr.microsoft.com/devcontainers/base:ubuntu",
"features": {
"ghcr.io/devcontainers-community/npm-features/prettier:1": {
"plugins": "prettier-plugin-sh"
},
"ghcr.io/devcontainers-extra/features/actionlint:1": {},
"ghcr.io/devcontainers-extra/features/checkov:1": {},
"ghcr.io/devcontainers-extra/features/markdownlint-cli:1": {},
"ghcr.io/devcontainers-extra/features/shellcheck:1": {},
"ghcr.io/devcontainers-extra/features/yamllint:2": {},
"ghcr.io/devcontainers/features/github-cli:1": {}
},
"customizations": {
"vscode": {
"extensions": [
"DavidAnson.vscode-markdownlint",
"editorconfig.editorconfig",
"esbenp.prettier-vscode",
"github.vscode-github-actions",
"GitHub.vscode-pull-request-github",
"redhat.vscode-yaml",
"timonwong.shellcheck",
"yzhang.markdown-all-in-one"
]
}
},
"postCreateCommand": "npm init -y >/dev/null 2>&1 || true && npm install --no-save prettier prettier-plugin-sh prettier-plugin-jinja-template"
"name": "BASH Dev Container",
"image": "mcr.microsoft.com/devcontainers/base:ubuntu",
"features": {
"ghcr.io/devcontainers-community/npm-features/prettier:1": {
"plugins": "prettier-plugin-sh"
},
"ghcr.io/devcontainers-extra/features/actionlint:1": {},
"ghcr.io/devcontainers-extra/features/checkov:1": {},
"ghcr.io/devcontainers-extra/features/markdownlint-cli:1": {},
"ghcr.io/devcontainers-extra/features/shellcheck:1": {},
"ghcr.io/devcontainers-extra/features/yamllint:2": {},
"ghcr.io/devcontainers/features/github-cli:1": {}
},
"customizations": {
"vscode": {
"extensions": [
"DavidAnson.vscode-markdownlint",
"editorconfig.editorconfig",
"esbenp.prettier-vscode",
"github.vscode-github-actions",
"GitHub.vscode-pull-request-github",
"redhat.vscode-yaml",
"timonwong.shellcheck",
"yzhang.markdown-all-in-one"
]
}
},
"postCreateCommand": "npm init -y >/dev/null 2>&1 || true && npm install --no-save prettier prettier-plugin-sh prettier-plugin-jinja-template && sudo apt-get update && sudo apt-get install -y ripgrep"
}
4 changes: 2 additions & 2 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ trim_trailing_whitespace = true
indent_size = 4
indent_style = tab

# JSON Files (Biome formatting)
# JSON Files
[*.json]
indent_style = tab
indent_style = space
indent_size = 2

# Steam appmanifest files (Valve ACF format)
Expand Down
81 changes: 80 additions & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,51 @@ body:
attributes:
value: |
Thanks for taking the time to fill out this bug report!
- type: dropdown
id: severity
attributes:
label: Severity
description: Triage metadata used for prioritization.
options:
- "severity: low"
- "severity: medium"
- "severity: high"
- "severity: critical"
validations:
required: true
- type: dropdown
id: reproducibility
attributes:
label: Reproducibility
description: Triage metadata used for prioritization.
options:
- "reproducible: always"
- "reproducible: sometimes"
- "reproducible: unable"
validations:
required: true
- type: dropdown
id: regression
attributes:
label: Regression
description: Triage metadata used for prioritization.
options:
- "regression: yes"
- "regression: no"
- "regression: unknown"
validations:
required: true
- type: dropdown
id: affects-latest
attributes:
label: Affects latest release
description: Triage metadata used for prioritization.
options:
- "latest-release: yes"
- "latest-release: no"
- "latest-release: unknown"
validations:
required: true
- type: input
id: user-story
attributes:
Expand All @@ -16,6 +61,14 @@ body:
placeholder: As a [user description], I want [desired action] so that [desired outcome].
validations:
required: true
- type: input
id: script-name
attributes:
label: Script name
description: LinuxGSM script name in use.
placeholder: vhserver
validations:
required: true
- type: input
id: game
attributes:
Expand Down Expand Up @@ -66,6 +119,22 @@ body:
- "command: send"
validations:
required: true
- type: textarea
id: expected-behavior
attributes:
label: Expected behavior
description: What should happen?
placeholder: Describe the expected result.
validations:
required: true
- type: textarea
id: actual-behavior
attributes:
label: Actual behavior
description: What actually happens?
placeholder: Describe the observed result.
validations:
required: true
- type: textarea
id: further-info
attributes:
Expand All @@ -74,11 +143,19 @@ body:
placeholder: Tell us what you see!
validations:
required: true
- type: checkboxes
id: prechecks
attributes:
label: Pre-checks
description: Confirm standard troubleshooting has been completed.
options:
- label: I ran update and validate before reporting this issue.
required: true
- type: textarea
id: logs
attributes:
label: Relevant log output
description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks.
description: Include the exact command used and the full related output (debug/details if available). This will be automatically formatted into code.
render: shell
- type: textarea
id: steps
Expand All @@ -90,3 +167,5 @@ body:
2. Click on '....'
3. Scroll down to '....'
4. See error
validations:
required: true
3 changes: 3 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@ contact_links:
- name: Discord Server
about: Join the LinuxGSM Discord community server. Discuss your LinuxGSM setup, get help and advice
url: https://linuxgsm.com/discord
- name: Report a security vulnerability
about: Please report security vulnerabilities privately, not in public issues.
url: https://github.com/GameServerManagers/LinuxGSM/security/advisories/new
42 changes: 41 additions & 1 deletion .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,17 @@ body:
attributes:
value: |
Thanks for taking the time to fill out this feature request!
- type: dropdown
id: priority
attributes:
label: Priority
description: How important is this feature to you?
options:
- "priority: low"
- "priority: medium"
- "priority: high"
validations:
required: true
- type: input
id: user-story
attributes:
Expand Down Expand Up @@ -64,12 +75,41 @@ body:
- "command: update-lgsm"
- "command: wipe"
- "command: send"
validations:
required: false
- type: textarea
id: problem-statement
attributes:
label: Problem statement
description: What is painful today, and why is this needed?
placeholder: Describe the current limitation or pain point.
validations:
required: true
- type: dropdown
id: scope-impact
attributes:
label: Scope and impact
description: Which area would this change impact?
options:
- "scope: single game"
- "scope: multiple games"
- "scope: all servers"
- "scope: documentation only"
- "scope: ci/cd or automation"
- "scope: other"
validations:
required: true
- type: textarea
id: further-info
attributes:
label: Further information
description: A clear description of what the feature is and any ideas on how to achieve this.
description: A clear description of the proposed solution and any implementation ideas.
validations:
required: true
- type: textarea
id: alternatives
attributes:
label: Alternatives considered
description: Describe alternatives or workarounds you considered.
validations:
required: false
38 changes: 33 additions & 5 deletions .github/ISSUE_TEMPLATE/server_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,27 @@ body:
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this game server!
Thanks for taking the time to fill out this game server request!
- type: input
id: game-server
attributes:
label: Game server
description: What game server would you like to add?
validations:
required: true
- type: checkboxes
id: dedicated-server
attributes:
label: Dedicated server
description: Confirm this is a dedicated server request and not client hosting.
options:
- label: "Yes, this is a dedicated server (not client hosting)."
required: true
- type: checkboxes
id: on-linux
attributes:
label: Linux support
description: Does this game server have Linux support? (not wine)
description: Does this game server have native Linux server support? (not wine)
options:
- label: "Yes"
validations:
Expand All @@ -38,20 +46,40 @@ body:
id: steam-id
attributes:
label: Steam appid
description: What is the Steam appid of the game server? Use SteamDB to get the appid. (https://steamdb.info).
description: What is the Steam appid of the dedicated server? Required when Steam is Yes. Use SteamDB to get the appid (https://steamdb.info).
placeholder: "892970"
validations:
required: false
- type: textarea
id: official-docs
attributes:
label: Official dedicated server documentation
description: Provide official documentation links for installing/running the dedicated server.
placeholder: |
https://example.com/docs/server-setup
https://example.com/docs/dedicated-server
validations:
required: true
- type: textarea
id: linux-binary-proof
attributes:
label: Linux binary proof
description: Provide evidence that Linux server binaries are available (official docs/download links/version notes).
placeholder: |
https://example.com/downloads/linux-dedicated-server
https://example.com/release-notes/linux-server
validations:
required: true
- type: textarea
id: guides
attributes:
label: Guides
description: Links to guides on how to install the game server
description: Links to community or third-party guides on how to install the game server.
- type: checkboxes
id: terms
attributes:
label: Code of Conduct
description: By submitting this issue, you agree to follow our [Code of Conduct](https://example.com)
description: By submitting this issue, you agree to follow our [Code of Conduct](https://github.com/GameServerManagers/LinuxGSM/blob/master/CODE_OF_CONDUCT.md)
options:
- label: I agree to follow this project's Code of Conduct
required: true
29 changes: 29 additions & 0 deletions .github/instructions/pr-review.instructions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
---
title: "LinuxGSM PR Review Guidance"
applyTo: "**"
description: "Use when reviewing pull requests in LinuxGSM; prioritize regressions, behavior changes, shell safety, and missing tests over style-only feedback."
---

Focus review effort on correctness and operational safety first.

Primary priorities:

- Identify behavior regressions and compatibility risks.
- Flag unsafe shell patterns (`rm -rf`, unquoted vars, unchecked command failures).
- Verify workflow changes do not weaken permissions or secret handling.
- Check for missing tests/validation when logic changes.
- Confirm labels, templates, and automation rules stay internally consistent.

Feedback expectations:

- Give concrete, actionable findings with file and reason.
- Prefer high-signal issues over style nits.
- If no defects are found, state that clearly and mention residual risk areas.
- Suggest minimal, low-risk fixes before proposing broad refactors.

LinuxGSM-specific checks:

- Shell scripts should preserve robust defaults (`set -euo pipefail` where appropriate).
- Label/workflow updates should avoid duplicate or stale taxonomy.
- Automation should fail safe (log and continue for advisory AI; block on true CI errors).
- Keep issue/PR automation rules aligned with templates and existing labels.
Loading
Loading