Repository navigation
feat(ci): fail PR Body Check when a Fixes issue is not linked in Development - #5139
Merged
Merged
Conversation
…lopment Closing keywords never create a Development link on pull requests into develop, so the link has to be added by hand and was often missed. The check now compares the issues named after Fixes, Closes or Resolves with the pull request's closingIssuesReferences and fails on any issue that is not linked. Related to and no-issue pull requests still only warn.
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR Body Check now fails when the body names an issue with a closing keyword (
Fixes,ClosesorResolves #N) that is not linked in the pull request's Development section.Closing keywords only create a Development link on pull requests into the default branch (
master). On pull requests intodevelopthey never link, so the issue's sidebar stays empty unless someone links it by hand, and that step was regularly missed: 14 open issues waiting for v26.5.0 had a mergedFixesPR with no link.closingIssuesReferences(which includes manual links) and compares it with the issue numbers after closing keywords in the body.Related to #Nand pull requests with no issue are unchanged: they still only get a warning.issues: readandpull-requests: readto the workflow token for the GraphQL lookups.No linked issue: this is maintenance found while auditing issue links.
Affected servers: none (CI only)
Type of change
Testing
context/coreand real GitHub GraphQL calls, against merged pull requests;prettier --checkandactionlinton the workflow.Fixesissues linked by hand): pass.Checklist
PR will not be merged until all steps are complete.