Conversation
Replace the launcher icons of the Compose and UI Components sample apps with the artwork from design-system-tokens (chat/android-compose and chat/android). The exported foreground covers only the 72dp visible area, so it is padded to the 108dp adaptive layer to stay inside the launcher mask. The adaptive background is now the gradient shape from the design README. The splash screen background only accepts a color, so it gets a separate splash_background color.
Contributor
Author
|
@CodeRabbit review |
✅ Action performedReview finished.
|
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (40)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughBoth Android sample apps now use blue gradient backgrounds for adaptive launcher icons. Their splash screen themes use a blue background color. ChangesSample app backgrounds
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to Both sample apps now have the intended blue gradient launcher backgrounds and solid blue splash backgrounds. The checked resource references are consistent, with no actionable merge risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit sees blue across the screen, Comment |
Contributor
SDK Size Comparison 📏
|
|
andremion
marked this pull request as ready for review
September 23, 2026 11:05
jurgenploeger
approved these changes
Sep 23, 2026
andremion
deleted the
andrerego/and-1559-adopt-the-new-chat-sample-app-launcher-icons
branch
September 23, 2026 13:19
Contributor
|
🚀 Available in v7.12.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Closes AND-1559
Both chat sample apps get the new launcher icons from design-system-tokens (
assets/app-icons/chat/).Implementation
chat/android-composeand UI Components sample useschat/android.foreground.pngis exported as the 72dp visible area. It is padded to the 108dp adaptive layer so the launcher mask does not cut the glyph.<shape>from the design README (#0A86FFto#005FFF), replacing the black@color/ic_launcher_background.windowSplashScreenBackgroundonly accepts a color, so the splash uses a newsplash_backgroundcolor (#005FFF, the gradient end color).ic_launcherandic_launcher_roundstay circles, regenerated as lossless webp at every density.ic_launcher-playstore.pngregenerated at 512px.🎨 UI Changes
Launcher icons and splash screens of both sample apps, on an API 35 emulator.
Testing
assembleDemoDebugfor both samples fromorigin/developand from this branch, and compared the launcher and splash on an API 35 emulator.spotlessCheckon both sample modules passes. The change is resources only, so there are no unit tests or API dumps to update.Summary by CodeRabbit