feat(ci): Add opt-in offline persistence for E2E tests - #2853
Conversation
📝 WalkthroughWalkthroughIntegration test helpers now accept a persistence option, propagate it through ChangesPersistence Configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@sample_app/lib/auth/auth_controller.dart`:
- Around line 273-274: Replace the invalid closePersistenceConnection call in
debugReset() with a publicly supported Stream persistence cleanup or shutdown
path that clears the database before the next test. If no public cleanup API is
available, remove this teardown call rather than relying on the non-public
method.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a56f7584-c2c2-4535-be84-0be1e5924582
📒 Files selected for processing (3)
sample_app/integration_test/support/stream_test_case.dartsample_app/integration_test/support/stream_test_env.dartsample_app/lib/auth/auth_controller.dart
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2853 +/- ##
=======================================
Coverage 72.83% 72.83%
=======================================
Files 428 428
Lines 27657 27657
=======================================
Hits 20144 20144
Misses 7513 7513 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Submit a pull request
Linear: FLU-643
CLA
Description of the pull request
persistenceopt-in flag on thestreamTestWithEnv: When on - wires aStreamChatPersistenceClientin theChatClientundergoing the testSummary by CodeRabbit
New Features
Bug Fixes