fix(ui): press StreamBackButton when its unread badge is tapped - #3025
Conversation
The unread indicator is overlaid on top of the button and absorbed taps, so tapping the badge on the channel and thread header back button did nothing. The indicator now ignores pointer events. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthrough
ChangesBack button tap handling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change makes unread-badge taps press the back button as intended. No merge-blocking issue was identified; merge after normal checks pass. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3025 +/- ##
=======================================
Coverage 76.78% 76.78%
=======================================
Files 448 448
Lines 29167 29168 +1
=======================================
+ Hits 22397 22398 +1
Misses 6770 6770 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Submit a pull request
Linear: FLU-
Github Issue: #
CLA
Description of the pull request
StreamBackButtonoverlays itsunreadIndicatoron the top-end corner of the button. The overlay absorbed taps, so tapping the unread badge on the channel header (and thread header) back button did nothing.The indicator is now wrapped in
IgnorePointer, so a tap on it presses the button. TheunreadIndicatordartdoc states this.Companion to GetStream/stream-core-flutter#193, which makes the same fix in
StreamBadgeNotification'schildoverlay. The two are independent:StreamBackButtondraws its own overlay.Verified: new test
tapping the unread badge presses the buttoninback_button_test.darttaps the badge's centre and expectsonPressed; it fails without the change and passes with it. The other back button tests pass; no visual change.Screenshots / Videos
N/A — no visual change.
🤖 Generated with Claude Code
Summary by CodeRabbit